ed26993976
Before this change, `-quiet` mode in clang-tidy generated meaningless
messages `xxx warnings generated` in output:
```cpp
// main.cpp
#include <iostream>
int main() {
std::cout << 42;
}
```
```console
> clang-tidy -checks='-*,readability-magic-numbers' -quiet main.cpp
82 warnings generated.
main.cpp:4:16: warning: 42 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
4 | std::cout << 42;
| ^
```
As you can see, `82 warnings generated.` does not say much `quiet` mode,
this patch removes this message completely:
```console
> ./build/bin/clang-tidy -p build -checks='-*,readability-magic-numbers' -quiet main.cpp
main.cpp:4:16: warning: 42 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
4 | std::cout << 42;
| ^
```
In contrast, when running without `quiet`, It gives some meaningful
information because we know how many messages were suppressed thus
calculating total messages count:
```console
> clang-tidy -checks='-*,readability-magic-numbers' main.cpp
82 warnings generated.
main.cpp:4:16: warning: 42 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
4 | std::cout << 42;
| ^
Suppressed 81 warnings (81 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
```
Fixes #47042
132 lines
4.6 KiB
C++
132 lines
4.6 KiB
C++
//===--- ClangTidy.h - clang-tidy -------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_CLANGTIDY_H
|
|
#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_CLANGTIDY_H
|
|
|
|
#include "ClangTidyDiagnosticConsumer.h"
|
|
#include "ClangTidyOptions.h"
|
|
#include "llvm/ADT/StringSet.h"
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
namespace llvm {
|
|
class raw_ostream;
|
|
} // namespace llvm
|
|
|
|
namespace clang {
|
|
|
|
class ASTConsumer;
|
|
class CompilerInstance;
|
|
namespace tooling {
|
|
class CompilationDatabase;
|
|
} // namespace tooling
|
|
|
|
namespace tidy {
|
|
|
|
class ClangTidyCheckFactories;
|
|
|
|
class ClangTidyASTConsumerFactory {
|
|
public:
|
|
ClangTidyASTConsumerFactory(
|
|
ClangTidyContext &Context,
|
|
IntrusiveRefCntPtr<llvm::vfs::OverlayFileSystem> OverlayFS = nullptr);
|
|
|
|
/// Returns an ASTConsumer that runs the specified clang-tidy checks.
|
|
std::unique_ptr<clang::ASTConsumer>
|
|
createASTConsumer(clang::CompilerInstance &Compiler, StringRef File);
|
|
|
|
/// Get the list of enabled checks.
|
|
std::vector<std::string> getCheckNames();
|
|
|
|
/// Get the union of options from all checks.
|
|
ClangTidyOptions::OptionMap getCheckOptions();
|
|
|
|
private:
|
|
ClangTidyContext &Context;
|
|
IntrusiveRefCntPtr<llvm::vfs::OverlayFileSystem> OverlayFS;
|
|
std::unique_ptr<ClangTidyCheckFactories> CheckFactories;
|
|
};
|
|
|
|
/// Fills the list of check names that are enabled when the provided
|
|
/// filters are applied.
|
|
std::vector<std::string> getCheckNames(const ClangTidyOptions &Options,
|
|
bool AllowEnablingAnalyzerAlphaCheckers);
|
|
|
|
struct ChecksAndOptions {
|
|
llvm::StringSet<> Checks;
|
|
llvm::StringSet<> Options;
|
|
};
|
|
|
|
ChecksAndOptions
|
|
getAllChecksAndOptions(bool AllowEnablingAnalyzerAlphaCheckers = true);
|
|
|
|
/// Returns the effective check-specific options.
|
|
///
|
|
/// The method configures ClangTidy with the specified \p Options and collects
|
|
/// effective options from all created checks. The returned set of options
|
|
/// includes default check-specific options for all keys not overridden by \p
|
|
/// Options.
|
|
ClangTidyOptions::OptionMap
|
|
getCheckOptions(const ClangTidyOptions &Options,
|
|
bool AllowEnablingAnalyzerAlphaCheckers);
|
|
|
|
/// Filters CheckOptions in \p Options to only include options specified in
|
|
/// the \p EnabledChecks which is a sorted vector.
|
|
void filterCheckOptions(ClangTidyOptions &Options,
|
|
const std::vector<std::string> &EnabledChecks);
|
|
|
|
/// Run a set of clang-tidy checks on a set of files.
|
|
///
|
|
/// \param EnableCheckProfile If provided, it enables check profile collection
|
|
/// in MatchFinder, and will contain the result of the profile.
|
|
/// \param StoreCheckProfile If provided, and EnableCheckProfile is true,
|
|
/// the profile will not be output to stderr, but will instead be stored
|
|
/// as a JSON file in the specified directory.
|
|
std::vector<ClangTidyError>
|
|
runClangTidy(clang::tidy::ClangTidyContext &Context,
|
|
const tooling::CompilationDatabase &Compilations,
|
|
ArrayRef<std::string> InputFiles,
|
|
llvm::IntrusiveRefCntPtr<llvm::vfs::OverlayFileSystem> BaseFS,
|
|
bool ApplyAnyFix, bool EnableCheckProfile = false,
|
|
llvm::StringRef StoreCheckProfile = StringRef(),
|
|
bool Quiet = false);
|
|
|
|
/// Controls what kind of fixes clang-tidy is allowed to apply.
|
|
enum FixBehaviour {
|
|
/// Don't try to apply any fix.
|
|
FB_NoFix,
|
|
/// Only apply fixes added to warnings.
|
|
FB_Fix,
|
|
/// Apply fixes found in notes.
|
|
FB_FixNotes
|
|
};
|
|
|
|
// FIXME: This interface will need to be significantly extended to be useful.
|
|
// FIXME: Implement confidence levels for displaying/fixing errors.
|
|
//
|
|
/// Displays the found \p Errors to the users. If \p Fix is \ref FB_Fix or \ref
|
|
/// FB_FixNotes, \p Errors containing fixes are automatically applied and
|
|
/// reformatted. If no clang-format configuration file is found, the given \P
|
|
/// FormatStyle is used.
|
|
void handleErrors(llvm::ArrayRef<ClangTidyError> Errors,
|
|
ClangTidyContext &Context, FixBehaviour Fix,
|
|
unsigned &WarningsAsErrorsCount,
|
|
llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem> BaseFS);
|
|
|
|
/// Serializes replacements into YAML and writes them to the specified
|
|
/// output stream.
|
|
void exportReplacements(StringRef MainFilePath,
|
|
const std::vector<ClangTidyError> &Errors,
|
|
raw_ostream &OS);
|
|
|
|
} // end namespace tidy
|
|
} // end namespace clang
|
|
|
|
#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_CLANGTIDY_H
|