aee4925507
Based on post-commit review discussion on 2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith. Other uses of forcing HasEmptyPlaceHolder to false seem OK to me - they're all around pointer/reference types where the pointer/reference token will appear at the rightmost side of the left side of the type name, so they make nested types (eg: the "int" in "int *") behave as though there is a non-empty placeholder (because the "*" is essentially the placeholder as far as the "int" is concerned). This was originally committed in 277623f4d5a672d707390e2c3eaf30a9eb4b075c Reverted in f9ad1d1c775a8e264bebc15d75e0c6e5c20eefc7 due to breakages outside of clang - lldb seems to have some strange/strong dependence on "char [N]" versus "char[N]" when printing strings (not due to that name appearing in DWARF, but probably due to using clang to stringify type names) that'll need to be addressed, plus a few other odds and ends in other subprojects (clang-tools-extra, compiler-rt, etc).
13 lines
937 B
C
13 lines
937 B
C
// RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/var1.c
|
|
// RUN: %clang_cc1 -emit-pch -o %t.2.ast %S/Inputs/var2.c
|
|
// RUN: %clang_cc1 -ast-merge %t.1.ast -ast-merge %t.2.ast -fsyntax-only -fdiagnostics-show-note-include-stack %s 2>&1 | FileCheck %s
|
|
|
|
// CHECK: var2.c:2:9: warning: external variable 'x1' declared with incompatible types in different translation units ('double *' vs. 'float **')
|
|
// CHECK: var1.c:2:9: note: declared here with type 'float **'
|
|
// CHECK: var2.c:3:5: warning: external variable 'x2' declared with incompatible types in different translation units ('int' vs. 'double')
|
|
// CHECK: In file included from{{.*}}var1.c:3:
|
|
// CHECK: var1.h:1:8: note: declared here with type 'double'
|
|
// CHECK: warning: external variable 'xarray3' declared with incompatible types in different translation units ('int[17]' vs. 'int[18]')
|
|
// CHECK: var1.c:7:5: note: declared here with type 'int[18]'
|
|
// CHECK: 3 warnings generated
|