0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
99 lines
2.3 KiB
C++
99 lines
2.3 KiB
C++
// RUN: %clang_cc1 -verify %s
|
|
|
|
namespace test0 {
|
|
struct A {
|
|
static int x;
|
|
};
|
|
struct B : A {};
|
|
struct C : B {};
|
|
|
|
int test() {
|
|
return A::x
|
|
+ B::x
|
|
+ C::x;
|
|
}
|
|
}
|
|
|
|
namespace test1 {
|
|
struct A {
|
|
private: static int x; // expected-note 5 {{declared private here}}
|
|
static int test() { return x; }
|
|
};
|
|
struct B : public A {
|
|
static int test() { return x; } // expected-error {{private member}}
|
|
};
|
|
struct C : private A {
|
|
static int test() { return x; } // expected-error {{private member}}
|
|
};
|
|
|
|
struct D {
|
|
public: static int x; // expected-note{{member is declared here}}
|
|
static int test() { return x; }
|
|
};
|
|
struct E : private D { // expected-note{{constrained by private inheritance}}
|
|
static int test() { return x; }
|
|
};
|
|
|
|
int test() {
|
|
return A::x // expected-error {{private member}}
|
|
+ B::x // expected-error {{private member}}
|
|
+ C::x // expected-error {{private member}}
|
|
+ D::x
|
|
+ E::x; // expected-error {{private member}}
|
|
}
|
|
}
|
|
|
|
namespace test2 {
|
|
class A {
|
|
protected: static int x; // expected-note{{member is declared here}}
|
|
};
|
|
|
|
class B : private A {}; // expected-note {{private inheritance}}
|
|
class C : private A {
|
|
int test(B *b) {
|
|
return b->x; // expected-error {{private member}}
|
|
}
|
|
};
|
|
}
|
|
|
|
namespace test3 {
|
|
class A {
|
|
protected: static int x;
|
|
};
|
|
|
|
class B : public A {};
|
|
class C : private A {
|
|
int test(B *b) {
|
|
// x is accessible at C when named in A.
|
|
// A is an accessible base of B at C.
|
|
// Therefore this succeeds.
|
|
return b->x;
|
|
}
|
|
};
|
|
}
|
|
|
|
// Don't crash.
|
|
// Note that 'field' is indeed a private member of X but that access
|
|
// is indeed ultimately constrained by the protected inheritance from Y.
|
|
// If someone wants to put the effort into improving this diagnostic,
|
|
// they can feel free; even explaining it in person would be a pain.
|
|
namespace test4 {
|
|
class Z;
|
|
class X {
|
|
public:
|
|
void f(Z *p);
|
|
|
|
private:
|
|
int field; // expected-note {{member is declared here}}
|
|
};
|
|
|
|
class Y : public X { };
|
|
class Z : protected Y { }; // expected-note {{constrained by protected inheritance here}}
|
|
|
|
void X::f(Z *p) {
|
|
p->field = 0; // expected-error {{'field' is a private member of 'test4::X'}}
|
|
}
|
|
}
|
|
|
|
// TODO: flesh out these cases
|