0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
345 lines
13 KiB
Objective-C
345 lines
13 KiB
Objective-C
// RUN: %clang_cc1 -triple x86_64-apple-darwin9.0.0 -fsyntax-only -verify %s
|
|
// RUN: %clang_cc1 -D WARN_PARTIAL -Wpartial-availability -triple x86_64-apple-darwin9.0.0 -fsyntax-only -verify %s
|
|
|
|
@protocol P
|
|
- (void)proto_method __attribute__((availability(macosx,introduced=10.1,deprecated=10.2))); // expected-note 2 {{'proto_method' has been explicitly marked deprecated here}}
|
|
|
|
#if defined(WARN_PARTIAL)
|
|
// expected-note@+2 2 {{'partial_proto_method' has been marked as being introduced in macOS 10.8 here, but the deployment target is macOS 10.5}}
|
|
#endif
|
|
- (void)partial_proto_method __attribute__((availability(macosx,introduced=10.8)));
|
|
@end
|
|
|
|
@interface A <P>
|
|
- (void)method __attribute__((availability(macosx,introduced=10.1,deprecated=10.2))); // expected-note {{'method' has been explicitly marked deprecated here}}
|
|
#if defined(WARN_PARTIAL)
|
|
// expected-note@+2 2 {{'partialMethod' has been marked as being introduced in macOS 10.8 here, but the deployment target is macOS 10.5}}
|
|
#endif
|
|
- (void)partialMethod __attribute__((availability(macosx,introduced=10.8)));
|
|
|
|
- (void)overridden __attribute__((availability(macosx,introduced=10.3))); // expected-note{{overridden method is here}}
|
|
- (void)overridden2 __attribute__((availability(macosx,introduced=10.3)));
|
|
- (void)overridden3 __attribute__((availability(macosx,deprecated=10.3)));
|
|
- (void)overridden4 __attribute__((availability(macosx,deprecated=10.3))); // expected-note{{overridden method is here}}
|
|
- (void)overridden5 __attribute__((availability(macosx,unavailable)));
|
|
- (void)overridden6 __attribute__((availability(macosx,introduced=10.3))); // expected-note{{overridden method is here}}
|
|
- (void)unavailableMethod __attribute__((unavailable));
|
|
@end
|
|
|
|
@interface B : A
|
|
- (void)method; // NOTE: we expect 'method' to *not* inherit availability.
|
|
- (void)partialMethod; // Likewise.
|
|
- (void)overridden __attribute__((availability(macosx,introduced=10.4))); // expected-warning{{overriding method introduced after overridden method on macOS (10.4 vs. 10.3)}}
|
|
- (void)overridden2 __attribute__((availability(macosx,introduced=10.2)));
|
|
- (void)overridden3 __attribute__((availability(macosx,deprecated=10.4)));
|
|
- (void)overridden4 __attribute__((availability(macosx,deprecated=10.2))); // expected-warning{{overriding method deprecated before overridden method on macOS (10.3 vs. 10.2)}}
|
|
- (void)overridden5 __attribute__((availability(macosx,introduced=10.3)));
|
|
- (void)overridden6 __attribute__((availability(macosx,unavailable))); // expected-warning{{overriding method cannot be unavailable on macOS when its overridden method is available}}
|
|
- (void)unavailableMethod; // does *not* inherit unavailability
|
|
@end
|
|
|
|
void f(A *a, B *b) {
|
|
[a method]; // expected-warning{{'method' is deprecated: first deprecated in macOS 10.2}}
|
|
[b method]; // no-warning
|
|
[a proto_method]; // expected-warning{{'proto_method' is deprecated: first deprecated in macOS 10.2}}
|
|
[b proto_method]; // expected-warning{{'proto_method' is deprecated: first deprecated in macOS 10.2}}
|
|
|
|
#if defined(WARN_PARTIAL)
|
|
// expected-warning@+2 {{'partialMethod' is only available on macOS 10.8 or newer}} expected-note@+2 {{enclose 'partialMethod' in an @available check to silence this warning}}
|
|
#endif
|
|
[a partialMethod];
|
|
[b partialMethod]; // no warning
|
|
#if defined(WARN_PARTIAL)
|
|
// expected-warning@+2 {{'partial_proto_method' is only available on macOS 10.8 or newer}} expected-note@+2 {{enclose 'partial_proto_method' in an @available check to silence this warning}}
|
|
#endif
|
|
[a partial_proto_method];
|
|
#if defined(WARN_PARTIAL)
|
|
// expected-warning@+2 {{'partial_proto_method' is only available on macOS 10.8 or newer}} expected-note@+2 {{enclose 'partial_proto_method' in an @available check to silence this warning}}
|
|
#endif
|
|
[b partial_proto_method];
|
|
}
|
|
|
|
@interface A (NewAPI)
|
|
- (void)partialMethod;
|
|
- (void)partial_proto_method;
|
|
@end
|
|
|
|
void f_after_redecl(A *a, B *b) {
|
|
#ifdef WARN_PARTIAL
|
|
// expected-warning@+2{{'partialMethod' is only available on macOS 10.8 or newer}} expected-note@+2 {{@available}}
|
|
#endif
|
|
[a partialMethod];
|
|
[b partialMethod]; // no warning
|
|
[a partial_proto_method]; // no warning
|
|
[b partial_proto_method]; // no warning
|
|
}
|
|
|
|
// Warn about using a deprecated method when that method is re-implemented in a
|
|
// subclass where the redeclared method is not deprecated.
|
|
@interface C
|
|
- (void) method __attribute__((availability(macosx,introduced=10.1,deprecated=10.2))); // expected-note {{'method' has been explicitly marked deprecated here}}
|
|
@end
|
|
|
|
@interface D : C
|
|
- (void) method;
|
|
@end
|
|
|
|
@interface E : D
|
|
- (void) method;
|
|
@end
|
|
|
|
@implementation D
|
|
- (void) method {
|
|
[super method]; // expected-warning {{'method' is deprecated: first deprecated in macOS 10.2}}
|
|
}
|
|
@end
|
|
|
|
@implementation E
|
|
- (void) method {
|
|
[super method]; // no-warning
|
|
}
|
|
@end
|
|
|
|
@class NSMutableArray;
|
|
|
|
@interface NSDictionary
|
|
+ (instancetype)dictionaryWithObjectsAndKeys:(id)firstObject, ... __attribute__((sentinel(0,1)));
|
|
@end
|
|
|
|
@class NSString;
|
|
|
|
extern NSString *NSNibTopLevelObjects __attribute__((availability(macosx,introduced=10.0 ,deprecated=10.8,message="" )));
|
|
id NSNibOwner, topNibObjects;
|
|
|
|
@interface AppDelegate (SIEImport) // expected-error {{cannot find interface declaration for 'AppDelegate'}}
|
|
|
|
-(void)__attribute__((ibaction))importFromSIE:(id)sender;
|
|
|
|
@end
|
|
|
|
@implementation AppDelegate (SIEImport) // expected-error {{cannot find interface declaration for 'AppDelegate'}}
|
|
|
|
-(void)__attribute__((ibaction))importFromSIE:(id)sender {
|
|
|
|
NSMutableArray *topNibObjects;
|
|
NSDictionary *nibLoadDict = [NSDictionary dictionaryWithObjectsAndKeys:self, NSNibOwner, topNibObjects, NSNibTopLevelObjects, ((void *)0)];
|
|
}
|
|
|
|
@end
|
|
|
|
@protocol PartialProt
|
|
- (void)ppartialMethod __attribute__((availability(macosx,introduced=10.8)));
|
|
+ (void)ppartialMethod __attribute__((availability(macosx,introduced=10.8)));
|
|
@end
|
|
|
|
@interface PartialI <PartialProt>
|
|
#ifdef WARN_PARTIAL
|
|
// expected-note@+3{{'partialMethod' has been marked as being introduced in macOS 10.8 here, but the deployment target is macOS 10.5}}
|
|
// expected-note@+3{{'partialMethod' has been marked as being introduced in macOS 10.8 here, but the deployment target is macOS 10.5}}
|
|
#endif
|
|
- (void)partialMethod __attribute__((availability(macosx,introduced=10.8)));
|
|
+ (void)partialMethod __attribute__((availability(macosx,introduced=10.8)));
|
|
@end
|
|
|
|
@interface PartialI ()
|
|
- (void)ipartialMethod1 __attribute__((availability(macosx,introduced=10.8)));
|
|
#if defined(WARN_PARTIAL)
|
|
// expected-note@+2 {{'ipartialMethod2' has been marked as being introduced in macOS 10.8 here, but the deployment target is macOS 10.5}}
|
|
#endif
|
|
- (void)ipartialMethod2 __attribute__((availability(macosx,introduced=10.8)));
|
|
+ (void)ipartialMethod1 __attribute__((availability(macosx,introduced=10.8)));
|
|
#if defined(WARN_PARTIAL)
|
|
// expected-note@+2 {{'ipartialMethod2' has been marked as being introduced in macOS 10.8 here, but the deployment target is macOS 10.5}}
|
|
#endif
|
|
+ (void)ipartialMethod2 __attribute__((availability(macosx,introduced=10.8)));
|
|
@end
|
|
|
|
@interface PartialI (Redecls)
|
|
- (void)partialMethod;
|
|
- (void)ipartialMethod1;
|
|
- (void)ppartialMethod;
|
|
+ (void)partialMethod;
|
|
+ (void)ipartialMethod1;
|
|
+ (void)ppartialMethod;
|
|
@end
|
|
|
|
void partialfun(PartialI* a) {
|
|
#ifdef WARN_PARTIAL
|
|
// expected-warning@+2 {{'partialMethod' is only available on macOS 10.8 or newer}} expected-note@+2{{@available}}
|
|
#endif
|
|
[a partialMethod];
|
|
[a ipartialMethod1]; // no warning
|
|
#if defined(WARN_PARTIAL)
|
|
// expected-warning@+2 {{'ipartialMethod2' is only available on macOS 10.8 or newer}} expected-note@+2 {{enclose 'ipartialMethod2' in an @available check to silence this warning}}
|
|
#endif
|
|
[a ipartialMethod2];
|
|
[a ppartialMethod]; // no warning
|
|
#ifdef WARN_PARTIAL
|
|
// expected-warning@+2 {{'partialMethod' is only available on macOS 10.8 or newer}} expected-note@+2 {{@available}}
|
|
#endif
|
|
[PartialI partialMethod];
|
|
[PartialI ipartialMethod1]; // no warning
|
|
#if defined(WARN_PARTIAL)
|
|
// expected-warning@+2 {{'ipartialMethod2' is only available on macOS 10.8 or newer}} expected-note@+2 {{enclose 'ipartialMethod2' in an @available check to silence this warning}}
|
|
#endif
|
|
[PartialI ipartialMethod2];
|
|
[PartialI ppartialMethod]; // no warning
|
|
}
|
|
|
|
#if defined(WARN_PARTIAL)
|
|
// expected-note@+2 2 {{'PartialI2' has been marked as being introduced in macOS 10.8 here, but the deployment target is macOS 10.5}}
|
|
#endif
|
|
__attribute__((availability(macosx, introduced = 10.8))) @interface PartialI2
|
|
@end
|
|
|
|
#if defined(WARN_PARTIAL)
|
|
// expected-warning@+2 {{'PartialI2' is only available on macOS 10.8 or newer}} expected-note@+2 {{annotate 'partialinter1' with an availability attribute to silence}}
|
|
#endif
|
|
void partialinter1(PartialI2* p) {
|
|
}
|
|
|
|
@class PartialI2;
|
|
|
|
#ifdef WARN_PARTIAL
|
|
// expected-warning@+2 {{'PartialI2' is only available on macOS 10.8 or newer}} expected-note@+2 {{annotate 'partialinter2' with an availability attribute to silence}}
|
|
#endif
|
|
void partialinter2(PartialI2* p) {
|
|
}
|
|
|
|
|
|
// Test that both the use of the 'typedef' and the enum constant
|
|
// produces an error.
|
|
#define UNAVAILABLE __attribute__((unavailable("not available")))
|
|
|
|
typedef enum MyEnum : int MyEnum;
|
|
enum MyEnum : int { // expected-note {{'MyEnum' has been explicitly marked unavailable here}}
|
|
MyEnum_Blah UNAVAILABLE, // expected-note {{'MyEnum_Blah' has been explicitly marked unavailable here}}
|
|
} UNAVAILABLE;
|
|
|
|
void use_myEnum(void) {
|
|
// expected-error@+2 {{'MyEnum' is unavailable: not available}}
|
|
// expected-error@+1 {{MyEnum_Blah' is unavailable: not available}}
|
|
MyEnum e = MyEnum_Blah;
|
|
}
|
|
|
|
// Test that the availability of (optional) protocol methods is not
|
|
// inherited be implementations of those protocol methods.
|
|
@protocol AvailabilityP2
|
|
@optional
|
|
-(void)methodA __attribute__((availability(macosx,introduced=10.1,deprecated=10.2))); // expected-note 4{{'methodA' has been explicitly marked deprecated here}}
|
|
-(void)methodB __attribute__((unavailable)); // expected-note 4{{'methodB' has been explicitly marked unavailable here}}
|
|
-(void)methodC;
|
|
@end
|
|
|
|
void testAvailabilityP2(id<AvailabilityP2> obj) {
|
|
[obj methodA]; // expected-warning{{'methodA' is deprecated: first deprecated in macOS 10.2}}
|
|
[obj methodB]; // expected-error{{'methodB' is unavailable}}
|
|
}
|
|
|
|
@interface ImplementsAvailabilityP2a <AvailabilityP2>
|
|
-(void)methodA;
|
|
-(void)methodB;
|
|
@end
|
|
|
|
void testImplementsAvailabilityP2a(ImplementsAvailabilityP2a *obj) {
|
|
[obj methodA]; // okay: availability not inherited
|
|
[obj methodB]; // okay: unavailability not inherited
|
|
}
|
|
|
|
__attribute__((objc_root_class))
|
|
@interface ImplementsAvailabilityP2b <AvailabilityP2>
|
|
@end
|
|
|
|
@implementation ImplementsAvailabilityP2b
|
|
-(void)methodA {
|
|
// Make sure we're not inheriting availability.
|
|
id<AvailabilityP2> obj = self;
|
|
[obj methodA]; // expected-warning{{'methodA' is deprecated: first deprecated in macOS 10.2}}
|
|
[obj methodB]; // expected-error{{'methodB' is unavailable}}
|
|
}
|
|
-(void)methodB {
|
|
// Make sure we're not inheriting unavailability.
|
|
id<AvailabilityP2> obj = self;
|
|
[obj methodA]; // expected-warning{{'methodA' is deprecated: first deprecated in macOS 10.2}}
|
|
[obj methodB]; // expected-error{{'methodB' is unavailable}}
|
|
}
|
|
|
|
@end
|
|
|
|
void testImplementsAvailabilityP2b(ImplementsAvailabilityP2b *obj) {
|
|
// still get warnings/errors because we see the protocol version.
|
|
|
|
[obj methodA]; // expected-warning{{'methodA' is deprecated: first deprecated in macOS 10.2}}
|
|
[obj methodB]; // expected-error{{'methodB' is unavailable}}
|
|
}
|
|
|
|
__attribute__((objc_root_class))
|
|
@interface ImplementsAvailabilityP2c <AvailabilityP2>
|
|
-(void)methodA __attribute__((availability(macosx,introduced=10.2)));
|
|
-(void)methodB __attribute__((unavailable));
|
|
@end
|
|
|
|
__attribute__((objc_root_class))
|
|
@interface ImplementsAvailabilityP2d <AvailabilityP2>
|
|
@end
|
|
|
|
@implementation ImplementsAvailabilityP2d
|
|
-(void)methodA __attribute__((availability(macosx,introduced=10.2)))
|
|
{
|
|
}
|
|
-(void)methodB __attribute__((unavailable)) {
|
|
}
|
|
@end
|
|
|
|
__attribute__((objc_root_class))
|
|
@interface InheritUnavailableSuper
|
|
-(void)method __attribute__((unavailable)); // expected-note{{'method' has been explicitly marked unavailable here}}
|
|
@end
|
|
|
|
@interface InheritUnavailableSub : InheritUnavailableSuper
|
|
-(void)method;
|
|
@end
|
|
|
|
@implementation InheritUnavailableSub
|
|
-(void)method {
|
|
InheritUnavailableSuper *obj = self;
|
|
[obj method]; // expected-error{{'method' is unavailable}}
|
|
}
|
|
@end
|
|
|
|
#if defined(WARN_PARTIAL)
|
|
|
|
int fn_10_5(void) __attribute__((availability(macosx, introduced=10.5)));
|
|
int fn_10_7(void) __attribute__((availability(macosx, introduced=10.7))); // expected-note{{'fn_10_7' has been marked as being introduced in macOS 10.7 here, but the deployment target is macOS 10.5}}
|
|
int fn_10_8(void) __attribute__((availability(macosx, introduced=10.8))) { // expected-note{{'fn_10_8' has been marked as being introduced in macOS 10.8 here, but the deployment target is macOS 10.5}}
|
|
return fn_10_7();
|
|
}
|
|
|
|
__attribute__((objc_root_class))
|
|
@interface LookupAvailabilityBase
|
|
-(void) method1;
|
|
@end
|
|
|
|
@implementation LookupAvailabilityBase
|
|
-(void)method1 { fn_10_7(); } // expected-warning{{only available on macOS 10.7}} expected-note{{@available}}
|
|
@end
|
|
|
|
__attribute__((availability(macosx, introduced=10.7)))
|
|
@interface LookupAvailability : LookupAvailabilityBase
|
|
- (void)method2;
|
|
- (void)method3;
|
|
- (void)method4 __attribute__((availability(macosx, introduced=10.8)));
|
|
@end
|
|
|
|
@implementation LookupAvailability
|
|
-(void)method2 { fn_10_7(); }
|
|
-(void)method3 { fn_10_8(); } // expected-warning{{only available on macOS 10.8}} expected-note{{@available}}
|
|
-(void)method4 { fn_10_8(); }
|
|
@end
|
|
|
|
int old_func(void) __attribute__((availability(macos, introduced=10.4))) {
|
|
fn_10_5();
|
|
}
|
|
|
|
#endif
|