shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
llvm-project/clang/test/SemaOpenACC/no-empty-pqr-list.cpp
Erich Keane d1cce66469
[OpenACC] Switch Clang to use the Flang 'appertainment' rules for cla… (#135372) 
…uses

The Flang implemenation of OpenACC uses a .td file in the llvm/Frontend
directory to determine appertainment in 4 categories:

-Required: If this list has items in it, the directive requires at least
1 of these be present.

-AllowedExclusive: Items on this list are all allowed, but only 1 from
the list may be here (That is, they are exclusive of eachother).

-AllowedOnce: Items on this list are all allowed, but may not be
duplicated.

Allowed: Items on this list are allowed. Note th at the actual list of
'allowed' is all 4 of these lists together.

This is a draft patch to swtich Clang over to use those tables. Surgery
to get this to happen in Clang Sema was somewhat reasonable. However,
some gaps in the implementations are obvious, the existing clang
implementation disagrees with the Flang interpretation of it. SO, we're
keeping a task list here based on what gets discovered.

Changes to Clang:
- [x] Switch 'directive-kind' enum conversions to use tablegen See
ff1a7bddd9435b6ae2890c07eae60bb07898bbf5
- [x] Switch 'clause-kind' enum conversions to use tablegen See
ff1a7bddd9435b6ae2890c07eae60bb07898bbf5
- [x] Investigate 'parse' test differences to see if any new
disagreements arise.
- [x] Clang/Flang disagree as to whether 'collapse' can be multiple
times on a loop. Further research showed no prose to limit this, and the
comment on the clang implementation said "no good reason to allow", so
no standards justification.
- [x] Clang/Flang disagree whether 'num_gangs' can appear >1 on a
compute/combined construct. This ended up being an unjustified
restriction.
- [x] Clang/Flang disagree as to the list of required clauses on a 'set'
construct. My research shows that Clang mistakenly included 'if' in the
list, and that it should be just 'default_async', 'device_num', and
'device_type'.
- [x] Order of 'at least one of' diagnostic has changed. Tests were
updated.
- [x] Ensure we are properly 'de-aliasing' clause names in appertainment
checks?
- [x] What is 'shortloop'? 'shortloop' seems to be an old non-standard
extension that isn't supported by flang, but is parsed for backward
compat reasons. Clang won't parse, but we at least have a spot for it in
the clause list.
- [x] Implemented proposed change for 'routine' gang/worker/vector/seq.
(see issue 539)
- [x] Implement init/shutdown can only have 1 'if' (see issue 540)
- [x] Clang/Flang disagree as to whether 'tile' is permitted more than
once on a 'loop' or combined constructs (Flang prohibits >1). I see no
justification for this in the standard. EDIT: I found a comment in clang
that I did this to make SOMETHING around duplicate checks easier.
Discussion showed we should actually have a better behavior around
'device_type' and duplicates, so I've since implemented that.
- [x] Clang/Flang disagree whether 'gang', 'worker', or 'vector' may
appear on the same construct as a 'seq' on a 'loop' or 'combined'. There
is prose for this in 2022: (a gang, worker, or vector clause may not
appear if a 'seq' clause appears). EDIT: These don't actually disagree,
but aren't in the .td file, so I restored the existing code to do this.
- [x] Clang/Flang disagree on whether 'bind' can appear >1 on a
'routine'. I believe line 3096 (A bind clause may not bind to a routine
name that has a visible bind clause) makes this limitation (Flang
permits >1 bind). we discussed and decided this should have the same
rules as worker/vector/etc, except without the 'exactly 1 of' rule (so
no dupes in individual sections).
- [x] Clang/Flang disagree on whether 'init'/'shutdown' can have
multiple 'device_num' clauses. I believe there is no supporting prose
for this limitation., We decided that `device_num` should only happen
1x.
- [x] Clang/Flang disagree whether 'num_gangs' can appear >1 on a
'kernels' construct. Line 1173 (On a kernels construct, the num_gangs
clause must have a single argument) justifies limiting on a
per-arguement basis, but doesn't do so for multiple num_gangs clauses.
WE decided to do this with the '1-per-device-type' region for num_gangs,
num_workers, and vector_length, see openacc bug here:
https://github.com/OpenACC/openacc-spec/issues/541

Changes to Flang:
- [x] Clang/Flang disgree on whether 'atomic' can take an 'if' clause.
This was added in OpenACC3.3_Next See #135451
- [x] Clang/Flang disagree on whether 'finalize' can be allowed >1 times
on a 'exit_data' construct. see #135415.
- [x] Clang/Flang disagree whether 'if_present' should be allowed >1
times on a 'host_data'/'update' construct. see #135422
- [x] Clang/Flang disagree on whether 'init'/'shutdown' can have
multiple 'device_type' clauses. I believe there is no supporting prose
for this limitation.
- [ ] SEE change for num_gangs/etc above.


Changes that need discussion/research:
2025-04-18 14:54:21 -07:00

438 lines
12 KiB
C++
Raw Permalink Blame History

// RUN: %clang_cc1 %s -fopenacc -verify
void Compute() {
// expected-error@+1{{expected expression}}
#pragma acc parallel wait()
;
// expected-error@+1{{expected expression}}
#pragma acc serial wait()
;
// expected-error@+1{{expected expression}}
#pragma acc kernels wait()
;
// expected-error@+1{{expected expression}}
#pragma acc parallel num_gangs()
;
// expected-error@+1{{expected expression}}
#pragma acc serial num_gangs()
;
// expected-error@+1{{expected expression}}
#pragma acc kernels num_gangs()
;
// expected-error@+1{{expected expression}}
#pragma acc parallel num_workers()
;
// expected-error@+1{{expected expression}}
#pragma acc serial num_workers()
;
// expected-error@+1{{expected expression}}
#pragma acc kernels num_workers()
;
// expected-error@+1{{expected expression}}
#pragma acc parallel vector_length()
;
// expected-error@+1{{expected expression}}
#pragma acc serial vector_length()
;
// expected-error@+1{{expected expression}}
#pragma acc kernels vector_length()
;
// expected-error@+1{{expected expression}}
#pragma acc parallel reduction(+:)
;
// expected-error@+1{{expected expression}}
#pragma acc serial reduction(+:)
;
// expected-error@+1{{expected expression}}
#pragma acc parallel copy()
;
// expected-error@+1{{expected expression}}
#pragma acc serial copy()
;
// expected-error@+1{{expected expression}}
#pragma acc kernels copy()
;
// expected-error@+1{{expected expression}}
#pragma acc parallel copyin()
;
// expected-error@+1{{expected expression}}
#pragma acc serial copyin(readonly:)
;
// expected-error@+1{{expected expression}}
#pragma acc kernels copyin()
;
// expected-error@+1{{expected expression}}
#pragma acc parallel copyout()
;
// expected-error@+1{{expected expression}}
#pragma acc serial copyout(zero:)
;
// expected-error@+1{{expected expression}}
#pragma acc kernels copyout()
;
// expected-error@+1{{expected expression}}
#pragma acc parallel create()
;
// expected-error@+1{{expected expression}}
#pragma acc serial create(zero:)
;
// expected-error@+1{{expected expression}}
#pragma acc kernels create()
;
// expected-error@+1{{expected expression}}
#pragma acc parallel no_create()
;
// expected-error@+1{{expected expression}}
#pragma acc serial no_create()
;
// expected-error@+1{{expected expression}}
#pragma acc kernels no_create()
;
// expected-error@+1{{expected expression}}
#pragma acc parallel present()
;
// expected-error@+1{{expected expression}}
#pragma acc serial present()
;
// expected-error@+1{{expected expression}}
#pragma acc kernels present()
;
// expected-error@+1{{expected expression}}
#pragma acc parallel deviceptr()
;
// expected-error@+1{{expected expression}}
#pragma acc serial deviceptr()
;
// expected-error@+1{{expected expression}}
#pragma acc kernels deviceptr()
;
// expected-error@+1{{expected expression}}
#pragma acc parallel attach()
;
// expected-error@+1{{expected expression}}
#pragma acc serial attach()
;
// expected-error@+1{{expected expression}}
#pragma acc kernels attach()
;
// expected-error@+1{{expected expression}}
#pragma acc parallel private()
;
// expected-error@+1{{expected expression}}
#pragma acc serial private()
;
// expected-error@+1{{expected expression}}
#pragma acc parallel firstprivate()
;
// expected-error@+1{{expected expression}}
#pragma acc serial firstprivate()
;
// expected-error@+1{{expected identifier}}
#pragma acc parallel device_type()
;
// expected-error@+1{{expected identifier}}
#pragma acc serial device_type()
;
// expected-error@+1{{expected identifier}}
#pragma acc kernels device_type()
;
}
void Data(int i) {
// expected-error@+1{{expected expression}}
#pragma acc data default(none) wait()
// expected-error@+1{{expected expression}}
#pragma acc enter data copyin(i) wait()
// expected-error@+1{{expected expression}}
#pragma acc exit data copyout(i) wait()
// expected-error@+1{{expected identifier}}
#pragma acc data default(none) device_type()
// expected-error@+1{{expected expression}}
#pragma acc data copy()
// expected-error@+1{{expected expression}}
#pragma acc data copyin()
// expected-error@+1{{expected expression}}
#pragma acc enter data copyin()
// expected-error@+1{{expected expression}}
#pragma acc data copyout()
// expected-error@+1{{expected expression}}
#pragma acc exit data copyout()
// expected-error@+1{{expected expression}}
#pragma acc exit data delete()
// expected-error@+1{{expected expression}}
#pragma acc exit data detach()
// expected-error@+1{{expected expression}}
#pragma acc data create()
// expected-error@+1{{expected expression}}
#pragma acc enter data create()
// expected-error@+1{{expected expression}}
#pragma acc data default(none) no_create()
// expected-error@+1{{expected expression}}
#pragma acc data present()
// expected-error@+1{{expected expression}}
#pragma acc data deviceptr()
// expected-error@+1{{expected expression}}
#pragma acc data attach()
// expected-error@+1{{expected expression}}
#pragma acc enter data attach()
// expected-error@+1{{expected expression}}
#pragma acc host_data use_device()
;
}
void Executable(int i) {
// expected-error@+1{{expected identifier}}
#pragma acc init device_type()
// expected-error@+1{{expected identifier}}
#pragma acc shutdown device_type()
// expected-error@+1{{expected identifier}}
#pragma acc set device_num(i) device_type()
// expected-error@+1{{expected identifier}}
#pragma acc update self(i) device_type()
// expected-error@+1{{expected expression}}
#pragma acc update self(i) wait()
// expected-error@+1{{expected expression}}
#pragma acc update self()
// expected-error@+1{{expected expression}}
#pragma acc update host()
// expected-error@+1{{expected expression}}
#pragma acc update device()
// expected-error@+1{{expected expression}}
#pragma acc wait()
}
void Other() {
// expected-error@+1{{expected expression}}
#pragma acc loop gang()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc loop worker()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc loop vector()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc loop tile()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected identifier}}
#pragma acc loop device_type()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc loop private()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc loop reduction(+:)
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc cache()
// expected-error@+1{{expected expression}}
#pragma acc declare copy()
// expected-error@+1{{expected expression}}
#pragma acc declare copyin()
// expected-error@+1{{expected expression}}
#pragma acc declare copyout()
// expected-error@+1{{expected expression}}
#pragma acc declare create()
// expected-error@+1{{expected expression}}
#pragma acc declare present()
// expected-error@+1{{expected expression}}
#pragma acc declare deviceptr()
// expected-error@+1{{expected expression}}
#pragma acc declare device_resident()
// expected-error@+1{{expected expression}}
#pragma acc declare link()
auto L1 =[]{};
// expected-error@+1{{expected identifier}}
#pragma acc routine(L1) seq device_type()
// expected-error@+1{{expected identifier}}
#pragma acc routine seq device_type()
auto L2 =[]{};
}
void Combined() {
// expected-error@+1{{expected expression}}
#pragma acc parallel loop gang()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc serial loop gang()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc kernels loop gang()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc parallel loop tile()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc serial loop tile()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc kernels loop tile()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected identifier}}
#pragma acc parallel loop device_type()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected identifier}}
#pragma acc serial loop device_type()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected identifier}}
#pragma acc kernels loop device_type()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc parallel loop reduction(+:)
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc serial loop reduction(+:)
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc kernels loop reduction(+:)
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc parallel loop wait()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc serial loop wait()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc kernels loop wait()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc parallel loop num_gangs()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc kernels loop num_gangs()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc parallel loop copy()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc serial loop copy()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc kernels loop copy()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc parallel loop copyin()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc serial loop copyin()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc kernels loop copyin()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc parallel loop copyout()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc serial loop copyout()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc kernels loop copyout()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc parallel loop create()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc serial loop create()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc kernels loop create()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc parallel loop no_create()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc serial loop no_create()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc parallel loop present()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc serial loop present()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc kernels loop present()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc parallel loop deviceptr()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc serial loop deviceptr()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc kernels loop deviceptr()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc parallel loop attach()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc serial loop attach()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc kernels loop attach()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc parallel loop private()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc serial loop private()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc kernels loop private()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc parallel loop firstprivate()
for(int i = 0; i < 5; ++i);
// expected-error@+1{{expected expression}}
#pragma acc serial loop firstprivate()
for(int i = 0; i < 5; ++i);
}
Reference in New Issue View Git Blame Copy Permalink