llvm-project/lldb/unittests/API/SBMutexTest.cpp
Jonas Devlieghere 0b8c8ed042
[lldb] Fix use-after-free in SBMutexTest (#133840)
The `locked` variable can be accessed from the asynchronous thread until
the call to f.wait() completes. However, the variable is scoped in a
lexical block that ends before that, leading to a use-after-free.
2025-03-31 19:36:05 -07:00

57 lines
1.6 KiB
C++

//===-- SBMutexTest.cpp ---------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// Use the umbrella header for -Wdocumentation.
#include "lldb/API/LLDB.h"
#include "TestingSupport/SubsystemRAII.h"
#include "lldb/API/SBDebugger.h"
#include "lldb/API/SBTarget.h"
#include "gtest/gtest.h"
#include <atomic>
#include <chrono>
#include <future>
#include <mutex>
using namespace lldb;
using namespace lldb_private;
class SBMutexTest : public testing::Test {
protected:
void SetUp() override { debugger = SBDebugger::Create(); }
void TearDown() override { SBDebugger::Destroy(debugger); }
SubsystemRAII<lldb::SBDebugger> subsystems;
SBDebugger debugger;
};
TEST_F(SBMutexTest, LockTest) {
lldb::SBTarget target = debugger.GetDummyTarget();
std::atomic<bool> locked = false;
std::future<void> f;
{
lldb::SBMutex lock = target.GetAPIMutex();
std::lock_guard<lldb::SBMutex> lock_guard(lock);
ASSERT_FALSE(locked.exchange(true));
f = std::async(std::launch::async, [&]() {
ASSERT_TRUE(locked);
target.BreakpointCreateByName("foo", "bar");
ASSERT_FALSE(locked);
});
ASSERT_TRUE(f.valid());
// Wait 500ms to confirm the thread is blocked.
auto status = f.wait_for(std::chrono::milliseconds(500));
ASSERT_EQ(status, std::future_status::timeout);
ASSERT_TRUE(locked.exchange(false));
}
f.wait();
}