363f05b83d
Summary: The only use of this class was to implement the SharedCluster of ValueObjects. However, the same functionality can be implemented using a regular std::shared_ptr, and its little-known "sub-object pointer" feature, where the pointer can point to one thing, but actually delete something else when it goes out of scope. This patch reimplements SharedCluster using this feature -- SharedClusterPointer::GetObject now returns a std::shared_pointer which points to the ValueObject, but actually owns the whole cluster. The only change I needed to make here is that now the SharedCluster object needs to be created before the root ValueObject. This means that all private ValueObject constructors get a ClusterManager argument, and their static Create functions do the create-a-manager-and-pass-it-to-value-object dance. Reviewers: teemperor, JDevlieghere, jingham Subscribers: mgorny, jfb, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D74153
59 lines
1.7 KiB
C++
59 lines
1.7 KiB
C++
//===-- SharedClusterTest.cpp ---------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Utility/SharedCluster.h"
|
|
#include "gmock/gmock.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace lldb_private;
|
|
|
|
namespace {
|
|
class DestructNotifier {
|
|
public:
|
|
DestructNotifier(std::vector<int> &Queue, int Key) : Queue(Queue), Key(Key) {}
|
|
~DestructNotifier() { Queue.push_back(Key); }
|
|
|
|
std::vector<int> &Queue;
|
|
const int Key;
|
|
};
|
|
} // namespace
|
|
|
|
TEST(SharedCluster, ClusterManager) {
|
|
std::vector<int> Queue;
|
|
{
|
|
auto CM = ClusterManager<DestructNotifier>::Create();
|
|
auto *One = new DestructNotifier(Queue, 1);
|
|
auto *Two = new DestructNotifier(Queue, 2);
|
|
CM->ManageObject(One);
|
|
CM->ManageObject(Two);
|
|
|
|
ASSERT_THAT(Queue, testing::IsEmpty());
|
|
{
|
|
std::shared_ptr<DestructNotifier> OnePtr = CM->GetSharedPointer(One);
|
|
ASSERT_EQ(OnePtr->Key, 1);
|
|
ASSERT_THAT(Queue, testing::IsEmpty());
|
|
|
|
{
|
|
std::shared_ptr<DestructNotifier> OnePtrCopy = OnePtr;
|
|
ASSERT_EQ(OnePtrCopy->Key, 1);
|
|
ASSERT_THAT(Queue, testing::IsEmpty());
|
|
}
|
|
|
|
{
|
|
std::shared_ptr<DestructNotifier> TwoPtr = CM->GetSharedPointer(Two);
|
|
ASSERT_EQ(TwoPtr->Key, 2);
|
|
ASSERT_THAT(Queue, testing::IsEmpty());
|
|
}
|
|
|
|
ASSERT_THAT(Queue, testing::IsEmpty());
|
|
}
|
|
ASSERT_THAT(Queue, testing::IsEmpty());
|
|
}
|
|
ASSERT_THAT(Queue, testing::ElementsAre(1, 2));
|
|
}
|