db5e078690
In PGO, a C++ external linkage function `foo` has a private counter `__profc_foo` and a private `__profd_foo` in a `comdat nodeduplicate`. A `__attribute__((weak))` function `foo` has a weak hidden counter `__profc_foo` and a private `__profd_foo` in a `comdat nodeduplicate`. In `ld.lld a.o b.o`, say a.o defines an external linkage `foo` and b.o defines a weak `foo`. Currently we treat `comdat nodeduplicate` as `comdat any`, ld.lld will incorrectly consider `b.o:__profc_foo` non-prevailing. In the worst case when `b.o:__profd_foo` is retained and `b.o:__profc_foo` isn't, there will be dangling reference causing an `undefined hidden symbol` error. Add SelectionKind to `Comdat` in IRSymtab and let linkers ignore nodeduplicate comdat. Differential Revision: https://reviews.llvm.org/D106228
40 lines
1.8 KiB
LLVM
40 lines
1.8 KiB
LLVM
; RUN: env LLVM_OVERRIDE_PRODUCER=producer opt -o %t %s
|
|
; RUN: llvm-bcanalyzer -dump -show-binary-blobs %t | FileCheck --check-prefix=BCA %s
|
|
|
|
; Same producer, does not require upgrade.
|
|
; RUN: env LLVM_OVERRIDE_PRODUCER=producer llvm-lto2 dump-symtab %t | FileCheck --check-prefix=SYMTAB %s
|
|
|
|
; Different producer, requires upgrade.
|
|
; RUN: env LLVM_OVERRIDE_PRODUCER=consumer llvm-lto2 dump-symtab %t | FileCheck --check-prefix=SYMTAB %s
|
|
|
|
; BCA: <SYMTAB_BLOCK
|
|
; Version stored at offset 0.
|
|
; BCA-NEXT: <BLOB abbrevid=4/> blob data = '\x03\x00\x00\x00\x06\x00\x00\x00\x08\x00\x00\x00L\x00\x00\x00\x01\x00\x00\x00X\x00\x00\x00\x00\x00\x00\x00X\x00\x00\x00\x02\x00\x00\x00\x88\x00\x00\x00\x00\x00\x00\x00\x0E\x00\x00\x00\x18\x00\x00\x00&\x00\x00\x00\x0B\x00\x00\x00\x03\x00\x00\x00\x00\x00\x00\x00\x88\x00\x00\x00\x02\x00\x00\x00\x00\x00\x00\x00\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x03\x00\x00\x00\x00\x00\x00\x00\x03\x00\x00\x00\xFF\xFF\xFF\xFF\x00$\x00\x00\x03\x00\x00\x00\x03\x00\x00\x00\x03\x00\x00\x00\x03\x00\x00\x00\xFF\xFF\xFF\xFF\x08$\x00\x00\x00\x00\x00\x00\x03\x00\x00\x00\x03\x00\x00\x00\x03\x00\x00\x00'
|
|
; BCA-NEXT: </SYMTAB_BLOCK>
|
|
; BCA-NEXT: <STRTAB_BLOCK
|
|
; BCA-NEXT: <BLOB abbrevid=4/> blob data = 'foobarproducerx86_64-unknown-linux-gnuirsymtab.ll'
|
|
; BCA-NEXT: </STRTAB_BLOCK>
|
|
|
|
; SYMTAB: version: 3
|
|
; SYMTAB-NEXT: producer: producer
|
|
; SYMTAB-NEXT: target triple: x86_64-unknown-linux-gnu
|
|
; SYMTAB-NEXT: source filename: irsymtab.ll
|
|
; SYMTAB-NEXT: {{^dependent libraries: \"foo\" \"bar\"$}}
|
|
; SYMTAB-NEXT: D------X foo
|
|
; SYMTAB-NEXT: DU-----X bar
|
|
|
|
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-unknown-linux-gnu"
|
|
source_filename = "irsymtab.ll"
|
|
|
|
define void @foo() {
|
|
ret void
|
|
}
|
|
|
|
declare void @bar()
|
|
|
|
!llvm.dependent-libraries = !{!0, !1}
|
|
|
|
!0 = !{!"foo"}
|
|
!1 = !{!"bar"}
|