b209b9e11c
Before bb94611d6545c2c5271f5bb01de1aa4228a37250, we didn't check that the sections in the COFF executable actually contained enough raw data, when looking up what section contains tables pointed to by the data directories. That commit added checking, to avoid setting a pointer that points out of bounds - by rejecting such executables. It turns out that some binaries (e.g.g a "helper.exe" provided by NSIS) contains a base relocation table data directory that points into the wrong section. It points inside the virtual address space allocated for that section, but the section contains much less raw data, and the table points outside of the provided raw data. No longer reject such binaries (to let tools operate on them and inspect them), but don't set the table pointers (so that when printing e.g. base relocations, we don't print anything). This should fix the regression pointed out in https://reviews.llvm.org/D126898#3565834. Differential Revision: https://reviews.llvm.org/D127345
11 lines
465 B
Plaintext
11 lines
465 B
Plaintext
; Check an executable, where the baes relocation data directory points into
|
|
; a section (within the range specified by VirtualSize), but outside of the
|
|
; raw data provided in the executable. Make sure that we don't error out on
|
|
; the executable - but we don't try to print any base relocs (as their data
|
|
; is missing).
|
|
|
|
RUN: yaml2obj %p/Inputs/COFF/data-dir-out-of-bounds.yaml | llvm-readobj --coff-basereloc - | FileCheck %s
|
|
|
|
CHECK: BaseReloc [
|
|
CHECK-NEXT: ]
|