
Now that #149310 has restricted lifetime intrinsics to only work on allocas, we can also drop the explicit size argument. Instead, the size is implied by the alloca. This removes the ability to only mark a prefix of an alloca alive/dead. We never used that capability, so we should remove the need to handle that possibility everywhere (though many key places, including stack coloring, did not actually respect this).
213 lines
7.7 KiB
LLVM
213 lines
7.7 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 3
|
|
; RUN: opt < %s -passes=inline -S | FileCheck %s
|
|
; RUN: opt < %s -passes='cgscc(inline)' -S | FileCheck %s
|
|
|
|
; The verifier does catch problems with inlining of byval arguments that has a
|
|
; different address space compared to the alloca. But running instcombine
|
|
; after inline used to trigger asserts unless we disallow such inlining.
|
|
; RUN: opt < %s -passes=inline,instcombine -disable-output 2>/dev/null
|
|
|
|
target datalayout = "p:32:32-p1:64:64-p2:16:16-n16:32:64"
|
|
|
|
; Inlining a byval struct should cause an explicit copy into an alloca.
|
|
|
|
%struct.ss = type { i32, i64 }
|
|
@.str = internal constant [10 x i8] c"%d, %lld\0A\00" ; <ptr> [#uses=1]
|
|
|
|
define internal void @f(ptr byval(%struct.ss) %b) nounwind {
|
|
entry:
|
|
%tmp = getelementptr %struct.ss, ptr %b, i32 0, i32 0 ; <ptr> [#uses=2]
|
|
%tmp1 = load i32, ptr %tmp, align 4 ; <i32> [#uses=1]
|
|
%tmp2 = add i32 %tmp1, 1 ; <i32> [#uses=1]
|
|
store i32 %tmp2, ptr %tmp, align 4
|
|
ret void
|
|
}
|
|
|
|
declare i32 @printf(ptr, ...) nounwind
|
|
|
|
define i32 @test1() nounwind {
|
|
; CHECK-LABEL: define i32 @test1(
|
|
; CHECK-SAME: ) #[[ATTR0:[0-9]+]] {
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: [[S1:%.*]] = alloca [[STRUCT_SS:%.*]], align 8
|
|
; CHECK-NEXT: [[S:%.*]] = alloca [[STRUCT_SS]], align 8
|
|
; CHECK-NEXT: [[TMP1:%.*]] = getelementptr [[STRUCT_SS]], ptr [[S]], i32 0, i32 0
|
|
; CHECK-NEXT: store i32 1, ptr [[TMP1]], align 8
|
|
; CHECK-NEXT: [[TMP4:%.*]] = getelementptr [[STRUCT_SS]], ptr [[S]], i32 0, i32 1
|
|
; CHECK-NEXT: store i64 2, ptr [[TMP4]], align 4
|
|
; CHECK-NEXT: call void @llvm.lifetime.start.p0(ptr [[S1]])
|
|
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 8 [[S1]], ptr [[S]], i64 12, i1 false)
|
|
; CHECK-NEXT: [[TMP1_I:%.*]] = load i32, ptr [[S1]], align 4
|
|
; CHECK-NEXT: [[TMP2_I:%.*]] = add i32 [[TMP1_I]], 1
|
|
; CHECK-NEXT: store i32 [[TMP2_I]], ptr [[S1]], align 4
|
|
; CHECK-NEXT: call void @llvm.lifetime.end.p0(ptr [[S1]])
|
|
; CHECK-NEXT: ret i32 0
|
|
;
|
|
entry:
|
|
%S = alloca %struct.ss ; <ptr> [#uses=4]
|
|
%tmp1 = getelementptr %struct.ss, ptr %S, i32 0, i32 0 ; <ptr> [#uses=1]
|
|
store i32 1, ptr %tmp1, align 8
|
|
%tmp4 = getelementptr %struct.ss, ptr %S, i32 0, i32 1 ; <ptr> [#uses=1]
|
|
store i64 2, ptr %tmp4, align 4
|
|
call void @f(ptr byval(%struct.ss) %S) nounwind
|
|
ret i32 0
|
|
}
|
|
|
|
; Inlining a byval struct should NOT cause an explicit copy
|
|
; into an alloca if the function is readonly
|
|
|
|
define internal i32 @f2(ptr byval(%struct.ss) %b) nounwind readonly {
|
|
entry:
|
|
%tmp = getelementptr %struct.ss, ptr %b, i32 0, i32 0 ; <ptr> [#uses=2]
|
|
%tmp1 = load i32, ptr %tmp, align 4 ; <i32> [#uses=1]
|
|
%tmp2 = add i32 %tmp1, 1 ; <i32> [#uses=1]
|
|
ret i32 %tmp2
|
|
}
|
|
|
|
define i32 @test2() nounwind {
|
|
; CHECK-LABEL: define i32 @test2(
|
|
; CHECK-SAME: ) #[[ATTR0]] {
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: [[S:%.*]] = alloca [[STRUCT_SS:%.*]], align 8
|
|
; CHECK-NEXT: [[TMP1:%.*]] = getelementptr [[STRUCT_SS]], ptr [[S]], i32 0, i32 0
|
|
; CHECK-NEXT: store i32 1, ptr [[TMP1]], align 8
|
|
; CHECK-NEXT: [[TMP4:%.*]] = getelementptr [[STRUCT_SS]], ptr [[S]], i32 0, i32 1
|
|
; CHECK-NEXT: store i64 2, ptr [[TMP4]], align 4
|
|
; CHECK-NEXT: [[TMP1_I:%.*]] = load i32, ptr [[S]], align 4
|
|
; CHECK-NEXT: [[TMP2_I:%.*]] = add i32 [[TMP1_I]], 1
|
|
; CHECK-NEXT: ret i32 [[TMP2_I]]
|
|
;
|
|
entry:
|
|
%S = alloca %struct.ss ; <ptr> [#uses=4]
|
|
%tmp1 = getelementptr %struct.ss, ptr %S, i32 0, i32 0 ; <ptr> [#uses=1]
|
|
store i32 1, ptr %tmp1, align 8
|
|
%tmp4 = getelementptr %struct.ss, ptr %S, i32 0, i32 1 ; <ptr> [#uses=1]
|
|
store i64 2, ptr %tmp4, align 4
|
|
%X = call i32 @f2(ptr byval(%struct.ss) %S) nounwind
|
|
ret i32 %X
|
|
}
|
|
|
|
|
|
; Inlining a byval with an explicit alignment needs to use *at least* that
|
|
; alignment on the generated alloca.
|
|
; PR8769
|
|
declare void @g3(ptr %p)
|
|
|
|
define internal void @f3(ptr byval(%struct.ss) align 64 %b) nounwind {
|
|
call void @g3(ptr %b) ;; Could make alignment assumptions!
|
|
ret void
|
|
}
|
|
|
|
define void @test3() nounwind {
|
|
; CHECK-LABEL: define void @test3(
|
|
; CHECK-SAME: ) #[[ATTR0]] {
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: [[S1:%.*]] = alloca [[STRUCT_SS:%.*]], align 64
|
|
; CHECK-NEXT: [[S:%.*]] = alloca [[STRUCT_SS]], align 1
|
|
; CHECK-NEXT: call void @llvm.lifetime.start.p0(ptr [[S1]])
|
|
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 64 [[S1]], ptr align 64 [[S]], i64 12, i1 false)
|
|
; CHECK-NEXT: call void @g3(ptr align 64 [[S1]]) #[[ATTR0]]
|
|
; CHECK-NEXT: call void @llvm.lifetime.end.p0(ptr [[S1]])
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
entry:
|
|
%S = alloca %struct.ss, align 1 ;; May not be aligned.
|
|
call void @f3(ptr byval(%struct.ss) align 64 %S) nounwind
|
|
ret void
|
|
}
|
|
|
|
|
|
; Inlining a byval struct should NOT cause an explicit copy
|
|
; into an alloca if the function is readonly, but should increase an alloca's
|
|
; alignment to satisfy an explicit alignment request.
|
|
|
|
define internal i32 @f4(ptr byval(%struct.ss) align 64 %b) nounwind readonly {
|
|
call void @g3(ptr %b)
|
|
ret i32 4
|
|
}
|
|
|
|
define i32 @test4() nounwind {
|
|
; CHECK-LABEL: define i32 @test4(
|
|
; CHECK-SAME: ) #[[ATTR0]] {
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: [[S:%.*]] = alloca [[STRUCT_SS:%.*]], align 64
|
|
; CHECK-NEXT: call void @g3(ptr align 64 [[S]]) #[[ATTR0]]
|
|
; CHECK-NEXT: ret i32 4
|
|
;
|
|
entry:
|
|
%S = alloca %struct.ss, align 2 ; <ptr> [#uses=4]
|
|
%X = call i32 @f4(ptr byval(%struct.ss) align 64 %S) nounwind
|
|
ret i32 %X
|
|
}
|
|
|
|
%struct.S0 = type { i32 }
|
|
|
|
@b = global %struct.S0 { i32 1 }, align 4
|
|
@a = common global i32 0, align 4
|
|
|
|
define internal void @f5(ptr byval(%struct.S0) nocapture readonly align 4 %p) {
|
|
entry:
|
|
store i32 0, ptr @b, align 4
|
|
%0 = load i32, ptr %p, align 4
|
|
store i32 %0, ptr @a, align 4
|
|
ret void
|
|
}
|
|
|
|
define i32 @test5() {
|
|
; CHECK-LABEL: define i32 @test5() {
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: [[B:%.*]] = alloca [[STRUCT_S0:%.*]], align 8
|
|
; CHECK-NEXT: call void @llvm.lifetime.start.p0(ptr [[B]])
|
|
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 8 [[B]], ptr align 4 @b, i64 4, i1 false)
|
|
; CHECK-NEXT: store i32 0, ptr @b, align 4
|
|
; CHECK-NEXT: [[TMP0:%.*]] = load i32, ptr [[B]], align 4
|
|
; CHECK-NEXT: store i32 [[TMP0]], ptr @a, align 4
|
|
; CHECK-NEXT: call void @llvm.lifetime.end.p0(ptr [[B]])
|
|
; CHECK-NEXT: [[TMP1:%.*]] = load i32, ptr @a, align 4
|
|
; CHECK-NEXT: ret i32 [[TMP1]]
|
|
;
|
|
entry:
|
|
tail call void @f5(ptr byval(%struct.S0) align 4 @b)
|
|
%0 = load i32, ptr @a, align 4
|
|
ret i32 %0
|
|
}
|
|
|
|
; Inlining a byval struct that is in a different address space compared to the
|
|
; alloca address space is at the moment not expected. That would need
|
|
; adjustments inside the inlined function since the address space attribute of
|
|
; the inlined argument changes.
|
|
|
|
%struct.S1 = type { i32 }
|
|
|
|
@d = addrspace(1) global %struct.S1 { i32 1 }, align 4
|
|
@c = common addrspace(1) global i32 0, align 4
|
|
|
|
define internal void @f5_as1(ptr addrspace(1) byval(%struct.S1) nocapture readonly align 4 %p) {
|
|
; CHECK-LABEL: define internal void @f5_as1(
|
|
; CHECK-SAME: ptr addrspace(1) readonly byval([[STRUCT_S1:%.*]]) align 4 captures(none) [[P:%.*]]) {
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: store i32 0, ptr addrspace(1) @d, align 4
|
|
; CHECK-NEXT: [[TMP0:%.*]] = load i32, ptr addrspace(1) [[P]], align 4
|
|
; CHECK-NEXT: store i32 [[TMP0]], ptr addrspace(1) @c, align 4
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
entry:
|
|
store i32 0, ptr addrspace(1) @d, align 4
|
|
%0 = load i32, ptr addrspace(1) %p, align 4
|
|
store i32 %0, ptr addrspace(1) @c, align 4
|
|
ret void
|
|
}
|
|
|
|
define i32 @test5_as1() {
|
|
; CHECK-LABEL: define i32 @test5_as1() {
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: tail call void @f5_as1(ptr addrspace(1) byval([[STRUCT_S1:%.*]]) align 4 @d)
|
|
; CHECK-NEXT: [[TMP0:%.*]] = load i32, ptr addrspace(1) @c, align 4
|
|
; CHECK-NEXT: ret i32 [[TMP0]]
|
|
;
|
|
entry:
|
|
tail call void @f5_as1(ptr addrspace(1) byval(%struct.S1) align 4 @d)
|
|
%0 = load i32, ptr addrspace(1) @c, align 4
|
|
ret i32 %0
|
|
}
|