0b89d1d59f
Some compiler provided type traits like __has_trivial_constructor have been documented as deprecated for quite some time. Still, some people apparently still use them, even though mixing them with concepts and with deleted functions leads to weird results. There's also disagreement about some edge cases between GCC (which Clang claims to follow) and MSVC. This patch adds deprecation warnings for the usage of those builtins, except for __has_trivial_destructor which doesn't have a GCC alternative. I made the warning on by default, so I had to silence it for some tests but it's not too many. Some (decade old) history of issues with those builtins: https://github.com/llvm/llvm-project/issues/18187 https://github.com/llvm/llvm-project/issues/18559 https://github.com/llvm/llvm-project/issues/22161 https://github.com/llvm/llvm-project/issues/33063 The abseil usage of them that triggered me to add this warning: https://github.com/abseil/abseil-cpp/issues/1201 Weird interaction of those builtins with C++20's conditionally trivial special member functions: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106085 Reviewed By: #clang-language-wg, aaron.ballman Differential Revision: https://reviews.llvm.org/D129170
59 lines
1.9 KiB
C++
59 lines
1.9 KiB
C++
// RUN: rm -rf %t
|
|
// RUN: %clang_cc1 -x objective-c++ -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -Wno-deprecated-builtins -I %S/Inputs %s -verify -std=c++11
|
|
// RUN: %clang_cc1 -x objective-c++ -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -Wno-deprecated-builtins -I %S/Inputs %s -ast-dump -ast-dump-filter merge -std=c++11 | FileCheck %s
|
|
|
|
// expected-no-diagnostics
|
|
|
|
void use_implicit_new() { operator new[](3); }
|
|
|
|
@import dummy;
|
|
@import cxx_decls.imported;
|
|
|
|
void test_delete(int *p) {
|
|
// We can call the normal global deallocation function even though it has only
|
|
// ever been explicitly declared in an unimported submodule.
|
|
delete p;
|
|
}
|
|
|
|
void friend_1(HasFriends s) {
|
|
s.private_thing();
|
|
}
|
|
void test_friends(HasFriends s) {
|
|
friend_1(s);
|
|
friend_2(s);
|
|
}
|
|
|
|
static_assert(!__is_trivial(HasNontrivialDefaultConstructor), "");
|
|
static_assert(!__has_trivial_constructor(HasNontrivialDefaultConstructor), "");
|
|
|
|
void use_implicit_new_again() { operator new[](3); }
|
|
|
|
int importMergeUsedFlag = getMergeUsedFlag();
|
|
|
|
int use_name_for_linkage(NameForLinkage &nfl) {
|
|
return nfl.n + nfl.m;
|
|
}
|
|
int use_overrides_virtual_functions(OverridesVirtualFunctions ovf) { return 0; }
|
|
|
|
@import cxx_decls_merged;
|
|
|
|
NameForLinkage2Inner use_name_for_linkage2_inner;
|
|
NameForLinkage2 use_name_for_linkage2;
|
|
|
|
int name_for_linkage_test = use_name_for_linkage(name_for_linkage);
|
|
int overrides_virtual_functions_test =
|
|
use_overrides_virtual_functions(overrides_virtual_functions);
|
|
|
|
void use_extern_c_function() { ExternCFunction(); }
|
|
|
|
int use_namespace_alias() { return Alias::a + Alias::b; }
|
|
|
|
@import cxx_decls_premerged;
|
|
|
|
void use_extern_c_function_2() { ExternCFunction(); }
|
|
|
|
InhCtorB inhctorb(2);
|
|
|
|
// CHECK: VarDecl [[mergeUsedFlag:0x[0-9a-f]*]] {{.*}} in cxx_decls.imported used mergeUsedFlag
|
|
// CHECK: VarDecl {{0x[0-9a-f]*}} prev [[mergeUsedFlag]] {{.*}} in cxx_decls_merged used mergeUsedFlag
|