f21ead0675
Following of https://github.com/llvm/llvm-project/pull/76930 This follows the idea of "only writes what we writes", which I think is the most natural and efficient way to implement this optimization. We start writing the BMI from the first declaration in module purview instead of the global module fragment, so that everything in the GMF untouched won't be written in the BMI naturally. The exception is, as I said in https://github.com/llvm/llvm-project/pull/76930, when we write a declaration we need to write its decl context, and when we write the decl context, we need to write everything from it. So when we see `std::vector`, we basically need to write everything under namespace std. This violates our intention. To fix this, this patch delays the writing of namespace in the GMF. From my local measurement, the size of the BMI decrease to 90M from 112M for a local modules build. I think this is significant. This feature will be covered under the experimental reduced BMI so that it won't affect any existing users. So I'd like to land this when the CI gets green. Documents will be added seperately.
80 lines
2.0 KiB
C++
80 lines
2.0 KiB
C++
// RUN: rm -rf %t
|
|
// RUN: mkdir -p %t
|
|
// RUN: split-file %s %t
|
|
//
|
|
// RUN: %clang_cc1 -std=c++20 -emit-module-interface %t/a.cppm -o %t/a.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/b.cppm -fprebuilt-module-path=%t -emit-module-interface -o %t/b.pcm -verify
|
|
//
|
|
// Testing the behavior of `-fskip-odr-check-in-gmf`
|
|
// RUN: %clang_cc1 -std=c++20 -fskip-odr-check-in-gmf -emit-module-interface %t/a.cppm -o \
|
|
// RUN: %t/a.pcm
|
|
// RUN: %clang_cc1 -std=c++20 -fskip-odr-check-in-gmf %t/b.cppm -fprebuilt-module-path=%t \
|
|
// RUN: -emit-module-interface -DSKIP_ODR_CHECK_IN_GMF -o %t/b.pcm -verify
|
|
|
|
// RUN: %clang_cc1 -std=c++20 -emit-reduced-module-interface %t/a.cppm -o %t/a.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/b.cppm -fprebuilt-module-path=%t -emit-reduced-module-interface \
|
|
// RUN: -o %t/b.pcm -verify -DREDUCED
|
|
|
|
//--- foo.h
|
|
|
|
namespace std
|
|
{
|
|
template<class _Dom1>
|
|
void operator &&(_Dom1 __v, _Dom1 __w)
|
|
{
|
|
return;
|
|
}
|
|
}
|
|
|
|
//--- bar.h
|
|
namespace std
|
|
{
|
|
template<typename... _Types>
|
|
struct _Traits
|
|
{
|
|
static constexpr bool _S_copy_ctor =
|
|
(__is_trivial(_Types) && ...);
|
|
};
|
|
|
|
template<typename... _Types>
|
|
struct variant
|
|
{
|
|
void
|
|
swap(variant& __rhs)
|
|
noexcept((__is_trivial(_Types) && ...))
|
|
{
|
|
}
|
|
};
|
|
}
|
|
|
|
//--- a.cppm
|
|
module;
|
|
// The operator&& defined in 'foo.h' will pollute the
|
|
// expression '__is_trivial(_Types) && ...' in bar.h
|
|
#include "foo.h"
|
|
#include "bar.h"
|
|
export module a;
|
|
export namespace std {
|
|
using std::variant;
|
|
using std::_Traits;
|
|
using std::operator&&;
|
|
}
|
|
|
|
//--- b.cppm
|
|
module;
|
|
#include "bar.h"
|
|
export module b;
|
|
import a;
|
|
export namespace std {
|
|
using std::variant;
|
|
using std::_Traits;
|
|
using std::operator&&;
|
|
}
|
|
|
|
#ifdef SKIP_ODR_CHECK_IN_GMF
|
|
// expected-no-diagnostics
|
|
#else
|
|
// expected-error@* {{has different definitions in different modules; first difference is defined here found data member '_S_copy_ctor' with an initializer}}
|
|
// expected-note@* {{but in 'a.<global>' found data member '_S_copy_ctor' with a different initializer}}
|
|
#endif
|