
The poisoned_hash_helper header was relying on an implicit forward declaration of std::hash located in <type_traits>. When we improve the modularization of the library, that causes issues, in addition to being a fundamentally non-portable assumption in the test suite. It turns out that the reason for relying on a forward declaration is to be able to test that std::hash is *not* provided if we don't include any header that provides it. But testing that is actually both non-portable and not really useful. Indeed, what harm does it make if additional headers provide std::hash specializations? That would certainly be conforming -- the Standard never requires an implementation to avoid providing a declaration when a given header is included, instead it mandates what *must* be provided for sure. In that spirit, it would be conforming for e.g. `<cstddef>` to define the hash specializations if that was our desire. I also don't read https://wg21.link/P0513R0 as going against that statement. Hence, this patch just removes that test which doesn't carry its weight. Fixes #56938
80 lines
2.1 KiB
C++
80 lines
2.1 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// UNSUPPORTED: c++03, c++11, c++14
|
|
// <optional>
|
|
|
|
// template <class T> struct hash<optional<T>>;
|
|
|
|
#include <optional>
|
|
#include <string>
|
|
#include <memory>
|
|
#include <cassert>
|
|
|
|
#include "poisoned_hash_helper.h"
|
|
|
|
#include "test_macros.h"
|
|
|
|
struct A {};
|
|
struct B {};
|
|
|
|
template <>
|
|
struct std::hash<B> {
|
|
std::size_t operator()(B const&) noexcept(false) { return 0; }
|
|
};
|
|
|
|
int main(int, char**)
|
|
{
|
|
using std::optional;
|
|
const std::size_t nullopt_hash =
|
|
std::hash<optional<double>>{}(optional<double>{});
|
|
|
|
|
|
{
|
|
optional<B> opt;
|
|
ASSERT_NOT_NOEXCEPT(std::hash<optional<B>>()(opt));
|
|
ASSERT_NOT_NOEXCEPT(std::hash<optional<const B>>()(opt));
|
|
}
|
|
|
|
{
|
|
typedef int T;
|
|
optional<T> opt;
|
|
assert(std::hash<optional<T>>{}(opt) == nullopt_hash);
|
|
opt = 2;
|
|
assert(std::hash<optional<T>>{}(opt) == std::hash<T>{}(*opt));
|
|
}
|
|
{
|
|
typedef std::string T;
|
|
optional<T> opt;
|
|
assert(std::hash<optional<T>>{}(opt) == nullopt_hash);
|
|
opt = std::string("123");
|
|
assert(std::hash<optional<T>>{}(opt) == std::hash<T>{}(*opt));
|
|
}
|
|
{
|
|
typedef std::unique_ptr<int> T;
|
|
optional<T> opt;
|
|
assert(std::hash<optional<T>>{}(opt) == nullopt_hash);
|
|
opt = std::unique_ptr<int>(new int(3));
|
|
assert(std::hash<optional<T>>{}(opt) == std::hash<T>{}(*opt));
|
|
}
|
|
{
|
|
test_hash_enabled<std::optional<int> >();
|
|
test_hash_enabled<std::optional<int*> >();
|
|
test_hash_enabled<std::optional<const int> >();
|
|
test_hash_enabled<std::optional<int* const> >();
|
|
|
|
test_hash_disabled<std::optional<A>>();
|
|
test_hash_disabled<std::optional<const A>>();
|
|
|
|
test_hash_enabled<std::optional<B>>();
|
|
test_hash_enabled<std::optional<const B>>();
|
|
}
|
|
|
|
return 0;
|
|
}
|