38818b60c5
Use deduction guides instead of helper functions.
The only non-automatic changes have been:
1. ArrayRef(some_uint8_pointer, 0) needs to be changed into ArrayRef(some_uint8_pointer, (size_t)0) to avoid an ambiguous call with ArrayRef((uint8_t*), (uint8_t*))
2. CVSymbol sym(makeArrayRef(symStorage)); needed to be rewritten as CVSymbol sym{ArrayRef(symStorage)}; otherwise the compiler is confused and thinks we have a (bad) function prototype. There was a few similar situation across the codebase.
3. ADL doesn't seem to work the same for deduction-guides and functions, so at some point the llvm namespace must be explicitly stated.
4. The "reference mode" of makeArrayRef(ArrayRef<T> &) that acts as no-op is not supported (a constructor cannot achieve that).
Per reviewers' comment, some useless makeArrayRef have been removed in the process.
This is a follow-up to https://reviews.llvm.org/D140896 that introduced
the deduction guides.
Differential Revision: https://reviews.llvm.org/D140955
39 lines
1.4 KiB
C++
39 lines
1.4 KiB
C++
//===- EnumTables.cpp - Enum to string conversion tables --------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/DebugInfo/PDB/Native/EnumTables.h"
|
|
#include "llvm/DebugInfo/PDB/Native/RawConstants.h"
|
|
#include "llvm/Support/ScopedPrinter.h"
|
|
|
|
using namespace llvm;
|
|
using namespace llvm::pdb;
|
|
|
|
#define PDB_ENUM_CLASS_ENT(enum_class, enum) \
|
|
{ #enum, std::underlying_type_t<enum_class>(enum_class::enum) }
|
|
|
|
#define PDB_ENUM_ENT(ns, enum) \
|
|
{ #enum, ns::enum }
|
|
|
|
static const EnumEntry<uint16_t> OMFSegMapDescFlagNames[] = {
|
|
PDB_ENUM_CLASS_ENT(OMFSegDescFlags, Read),
|
|
PDB_ENUM_CLASS_ENT(OMFSegDescFlags, Write),
|
|
PDB_ENUM_CLASS_ENT(OMFSegDescFlags, Execute),
|
|
PDB_ENUM_CLASS_ENT(OMFSegDescFlags, AddressIs32Bit),
|
|
PDB_ENUM_CLASS_ENT(OMFSegDescFlags, IsSelector),
|
|
PDB_ENUM_CLASS_ENT(OMFSegDescFlags, IsAbsoluteAddress),
|
|
PDB_ENUM_CLASS_ENT(OMFSegDescFlags, IsGroup),
|
|
};
|
|
|
|
namespace llvm {
|
|
namespace pdb {
|
|
ArrayRef<EnumEntry<uint16_t>> getOMFSegMapDescFlagNames() {
|
|
return ArrayRef(OMFSegMapDescFlagNames);
|
|
}
|
|
}
|
|
}
|