43222bd309
This pull request aims to remove any dependency on OpenCL/SPIR-V type information in LLVM IR metadata. While, using metadata might simplify and prettify the resulting SPIR-V output (and restore some of the information missed in the transformation to opaque pointers), the overall methodology for resolving kernel parameter types is highly inefficient. The high-level strategy is to assign kernel parameter types in this order: 1. Resolving the types using builtin function calls as mangled names must contain type information or by looking up builtin definition in SPIRVBuiltins.td. Then: - Assigning the type temporarily using an intrinsic and later setting the right SPIR-V type in SPIRVGlobalRegistry after IRTranslation - Inserting a bitcast 2. Defaulting to LLVM IR types (in case of pointers the generic i8* type or types from byval/byref attributes) In case of type incompatibility (e.g. parameter defined initially as sampler_t and later used as image_t) the error will be found early on before IRTranslation (in the SPIRVEmitIntrinsics pass).
86 lines
3.4 KiB
C++
86 lines
3.4 KiB
C++
//===--- SPIRVMetadata.cpp ---- IR Metadata Parsing Funcs -------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file contains functions needed for parsing LLVM IR metadata relevant
|
|
// to the SPIR-V target.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "SPIRVMetadata.h"
|
|
|
|
using namespace llvm;
|
|
|
|
static MDString *getOCLKernelArgAttribute(const Function &F, unsigned ArgIdx,
|
|
const StringRef AttributeName) {
|
|
assert(
|
|
F.getCallingConv() == CallingConv::SPIR_KERNEL &&
|
|
"Kernel attributes are attached/belong only to OpenCL kernel functions");
|
|
|
|
// Lookup the argument attribute in metadata attached to the kernel function.
|
|
MDNode *Node = F.getMetadata(AttributeName);
|
|
if (Node && ArgIdx < Node->getNumOperands())
|
|
return cast<MDString>(Node->getOperand(ArgIdx));
|
|
|
|
// Sometimes metadata containing kernel attributes is not attached to the
|
|
// function, but can be found in the named module-level metadata instead.
|
|
// For example:
|
|
// !opencl.kernels = !{!0}
|
|
// !0 = !{void ()* @someKernelFunction, !1, ...}
|
|
// !1 = !{!"kernel_arg_addr_space", ...}
|
|
// In this case the actual index of searched argument attribute is ArgIdx + 1,
|
|
// since the first metadata node operand is occupied by attribute name
|
|
// ("kernel_arg_addr_space" in the example above).
|
|
unsigned MDArgIdx = ArgIdx + 1;
|
|
NamedMDNode *OpenCLKernelsMD =
|
|
F.getParent()->getNamedMetadata("opencl.kernels");
|
|
if (!OpenCLKernelsMD || OpenCLKernelsMD->getNumOperands() == 0)
|
|
return nullptr;
|
|
|
|
// KernelToMDNodeList contains kernel function declarations followed by
|
|
// corresponding MDNodes for each attribute. Search only MDNodes "belonging"
|
|
// to the currently lowered kernel function.
|
|
MDNode *KernelToMDNodeList = OpenCLKernelsMD->getOperand(0);
|
|
bool FoundLoweredKernelFunction = false;
|
|
for (const MDOperand &Operand : KernelToMDNodeList->operands()) {
|
|
ValueAsMetadata *MaybeValue = dyn_cast<ValueAsMetadata>(Operand);
|
|
if (MaybeValue &&
|
|
dyn_cast<Function>(MaybeValue->getValue())->getName() == F.getName()) {
|
|
FoundLoweredKernelFunction = true;
|
|
continue;
|
|
}
|
|
if (MaybeValue && FoundLoweredKernelFunction)
|
|
return nullptr;
|
|
|
|
MDNode *MaybeNode = dyn_cast<MDNode>(Operand);
|
|
if (FoundLoweredKernelFunction && MaybeNode &&
|
|
cast<MDString>(MaybeNode->getOperand(0))->getString() ==
|
|
AttributeName &&
|
|
MDArgIdx < MaybeNode->getNumOperands())
|
|
return cast<MDString>(MaybeNode->getOperand(MDArgIdx));
|
|
}
|
|
return nullptr;
|
|
}
|
|
|
|
namespace llvm {
|
|
|
|
MDString *getOCLKernelArgAccessQual(const Function &F, unsigned ArgIdx) {
|
|
assert(
|
|
F.getCallingConv() == CallingConv::SPIR_KERNEL &&
|
|
"Kernel attributes are attached/belong only to OpenCL kernel functions");
|
|
return getOCLKernelArgAttribute(F, ArgIdx, "kernel_arg_access_qual");
|
|
}
|
|
|
|
MDString *getOCLKernelArgTypeQual(const Function &F, unsigned ArgIdx) {
|
|
assert(
|
|
F.getCallingConv() == CallingConv::SPIR_KERNEL &&
|
|
"Kernel attributes are attached/belong only to OpenCL kernel functions");
|
|
return getOCLKernelArgAttribute(F, ArgIdx, "kernel_arg_type_qual");
|
|
}
|
|
|
|
} // namespace llvm
|