304f1d59ca
This switches everything to use the memory attribute proposed in https://discourse.llvm.org/t/rfc-unify-memory-effect-attributes/65579. The old argmemonly, inaccessiblememonly and inaccessiblemem_or_argmemonly attributes are dropped. The readnone, readonly and writeonly attributes are restricted to parameters only. The old attributes are auto-upgraded both in bitcode and IR. The bitcode upgrade is a policy requirement that has to be retained indefinitely. The IR upgrade is mainly there so it's not necessary to update all tests using memory attributes in this patch, which is already large enough. We could drop that part after migrating tests, or retain it longer term, to make it easier to import IR from older LLVM versions. High-level Function/CallBase APIs like doesNotAccessMemory() or setDoesNotAccessMemory() are mapped transparently to the memory attribute. Code that directly manipulates attributes (e.g. via AttributeList) on the other hand needs to switch to working with the memory attribute instead. Differential Revision: https://reviews.llvm.org/D135780
34 lines
1.2 KiB
LLVM
34 lines
1.2 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --check-attributes
|
|
; RUN: opt -passes=function-attrs -S < %s | FileCheck %s
|
|
|
|
; Atomic load/store to local doesn't affect whether a function is
|
|
; readnone/readonly.
|
|
define i32 @test1(i32 %x) uwtable ssp {
|
|
; CHECK: Function Attrs: mustprogress nofree norecurse nosync nounwind ssp willreturn memory(none) uwtable
|
|
; CHECK-LABEL: @test1(
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: [[X_ADDR:%.*]] = alloca i32, align 4
|
|
; CHECK-NEXT: store atomic i32 [[X:%.*]], ptr [[X_ADDR]] seq_cst, align 4
|
|
; CHECK-NEXT: [[R:%.*]] = load atomic i32, ptr [[X_ADDR]] seq_cst, align 4
|
|
; CHECK-NEXT: ret i32 [[R]]
|
|
;
|
|
entry:
|
|
%x.addr = alloca i32, align 4
|
|
store atomic i32 %x, ptr %x.addr seq_cst, align 4
|
|
%r = load atomic i32, ptr %x.addr seq_cst, align 4
|
|
ret i32 %r
|
|
}
|
|
|
|
; A function with an Acquire load is not readonly.
|
|
define i32 @test2(ptr %x) uwtable ssp {
|
|
; CHECK: Function Attrs: mustprogress nofree norecurse nounwind ssp willreturn memory(argmem: readwrite) uwtable
|
|
; CHECK-LABEL: @test2(
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: [[R:%.*]] = load atomic i32, ptr [[X:%.*]] seq_cst, align 4
|
|
; CHECK-NEXT: ret i32 [[R]]
|
|
;
|
|
entry:
|
|
%r = load atomic i32, ptr %x seq_cst, align 4
|
|
ret i32 %r
|
|
}
|