a1b78fb929
Currently, JT creates and updates local instances of BPI\BFI. As a result global ones have to be invalidated if JT made any changes. In fact, JT doesn't use any information from BPI/BFI for the sake of the transformation itself. It only creates BPI/BFI to keep them up to date. But since it updates local copies (besides cases when it updates profile metadata) it just waste of time. Current patch is a rework of D124439. D124439 makes one step and replaces local copies with global ones retrieved through AnalysisPassManager. Here we do one more step and don't create BPI/BFI if the only reason of creation is to keep BPI/BFI up to date. Overall logic is the following. If there is cached BPI/BFI then update it along the transformations. If there is no existing BPI/BFI, then create it only if it is required to update profile metadata. Please note if BPI/BFI exists on exit from JT (either cached or created) it is always up to date and no reason to invalidate it. Reviewed By: mkazantsev Differential Revision: https://reviews.llvm.org/D136827
30 lines
652 B
LLVM
30 lines
652 B
LLVM
; RUN: opt -passes=jump-threading -S < %s | FileCheck %s
|
|
|
|
; Check that all zero branch weights do not cause a crash.
|
|
define void @zero_branch_weights(i32 %tmp, i32 %tmp3) {
|
|
bb:
|
|
%tmp1 = icmp eq i32 %tmp, 1
|
|
br i1 %tmp1, label %bb5, label %bb2
|
|
; CHECK-NOT: br i1 %tmp1,{{.*}} !prof
|
|
|
|
bb2:
|
|
%tmp4 = icmp ne i32 %tmp3, 1
|
|
br label %bb5
|
|
; CHECK: br i1 %tmp4, {{.*}} !prof ![[PROF:[0-9]+]]
|
|
|
|
bb5:
|
|
%tmp6 = phi i1 [ false, %bb ], [ %tmp4, %bb2 ]
|
|
br i1 %tmp6, label %bb8, label %bb7, !prof !{!"branch_weights", i32 0, i32 0}
|
|
|
|
bb7:
|
|
br label %bb9
|
|
|
|
bb8:
|
|
br label %bb9
|
|
|
|
bb9:
|
|
ret void
|
|
}
|
|
|
|
;CHECK: ![[PROF]] = !{!"branch_weights", i32 -2147483648, i32 0}
|