08c94c0ac3
Some plugins were returning the number of specifications they have added, while others were returning the total final number. Particularly devious plugins (Minidump) were clearing the specification list altogether. This resulted in nondeterministic failures (depending on plugin ininitialization order) in TestSBModule. This PR defines the problem away by having each plugin only return the specifications it is responsible for. If the caller wants to merge them, it is free to do so. This *might* be slighly less efficient, but this is hardly hot code. I'm not touching the ObjectFile::GetModuleSpecifications function (the caller of all these functions) as the PR is big enough, although the same approach might be warranted there as well. Fixes https://github.com/llvm/llvm-project/issues/178625.
67 lines
2.7 KiB
C++
67 lines
2.7 KiB
C++
//===-- ObjectFileMinidump.h ---------------------------------- -*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
/// \file
|
|
/// Placeholder plugin for the save core functionality.
|
|
///
|
|
/// ObjectFileMinidump is created only to be able to save minidump core files
|
|
/// from existing processes with the ObjectFileMinidump::SaveCore function.
|
|
/// Minidump files are not ObjectFile objects, but they are core files and
|
|
/// currently LLDB's ObjectFile plug-ins handle emitting core files. If the
|
|
/// core file saving ever moves into a new plug-in type within LLDB, this code
|
|
/// should move as well, but for now this is the best place architecturally.
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLDB_SOURCE_PLUGINS_OBJECTFILE_MINIDUMP_OBJECTFILEMINIDUMP_H
|
|
#define LLDB_SOURCE_PLUGINS_OBJECTFILE_MINIDUMP_OBJECTFILEMINIDUMP_H
|
|
|
|
#include "lldb/Symbol/ObjectFile.h"
|
|
#include "lldb/Symbol/SaveCoreOptions.h"
|
|
#include "lldb/Utility/ArchSpec.h"
|
|
|
|
class ObjectFileMinidump : public lldb_private::PluginInterface {
|
|
public:
|
|
// Static Functions
|
|
static void Initialize();
|
|
static void Terminate();
|
|
|
|
static llvm::StringRef GetPluginNameStatic() { return "minidump"; }
|
|
static const char *GetPluginDescriptionStatic() {
|
|
return "Minidump object file.";
|
|
}
|
|
|
|
// PluginInterface protocol
|
|
llvm::StringRef GetPluginName() override { return GetPluginNameStatic(); }
|
|
|
|
static lldb_private::ObjectFile *
|
|
CreateInstance(const lldb::ModuleSP &module_sp,
|
|
lldb::DataExtractorSP extractor_sp, lldb::offset_t data_offset,
|
|
const lldb_private::FileSpec *file, lldb::offset_t offset,
|
|
lldb::offset_t length);
|
|
|
|
static lldb_private::ObjectFile *CreateMemoryInstance(
|
|
const lldb::ModuleSP &module_sp, lldb::WritableDataBufferSP data_sp,
|
|
const lldb::ProcessSP &process_sp, lldb::addr_t header_addr);
|
|
|
|
static lldb_private::ModuleSpecList
|
|
GetModuleSpecifications(const lldb_private::FileSpec &file,
|
|
lldb::DataExtractorSP &extractor_sp,
|
|
lldb::offset_t data_offset,
|
|
lldb::offset_t file_offset, lldb::offset_t length);
|
|
|
|
// Saves dump in Minidump file format
|
|
static bool SaveCore(const lldb::ProcessSP &process_sp,
|
|
lldb_private::SaveCoreOptions &options,
|
|
lldb_private::Status &error);
|
|
|
|
private:
|
|
ObjectFileMinidump() = default;
|
|
};
|
|
|
|
#endif // LLDB_SOURCE_PLUGINS_OBJECTFILE_MINIDUMP_OBJECTFILEMINIDUMP_H
|