
The original commit was missing a `ClangASTImporter::CopyType` call. Original commit message: This commit teaches the `std::coroutine_handle` pretty-printer to devirtualize type-erased promise types. This is particularly useful to resonstruct call stacks, either of asynchronous control flow or of recursive invocations of `std::generator`. For the example recently introduced by https://reviews.llvm.org/D132451, printing the `__promise` variable now shows ``` (std::__coroutine_traits_sfinae<task, void>::promise_type) __promise = { continuation = coro frame = 0x555555562430 { resume = 0x0000555555556310 (a.out`task detail::chain_fn<1>() at llvm-nested-example.cpp:66) destroy = 0x0000555555556700 (a.out`task detail::chain_fn<1>() at llvm-nested-example.cpp:66) promise = { continuation = coro frame = 0x5555555623e0 { resume = 0x0000555555557070 (a.out`task detail::chain_fn<2>() at llvm-nested-example.cpp:66) destroy = 0x0000555555557460 (a.out`task detail::chain_fn<2>() at llvm-nested-example.cpp:66) promise = { ... } } result = 0 } } result = 0 } ``` (shortened to keep the commit message readable) instead of ``` (std::__coroutine_traits_sfinae<task, void>::promise_type) __promise = { continuation = coro frame = 0x555555562430 { resume = 0x0000555555556310 (a.out`task detail::chain_fn<1>() at llvm-nested-example.cpp:66) destroy = 0x0000555555556700 (a.out`task detail::chain_fn<1>() at llvm-nested-example.cpp:66) } result = 0 } ``` Note how the new debug output reveals the complete asynchronous call stack: our own function resumes `chain_fn<1>` which in turn will resume `chain_fn<2>` and so on. Thereby this change allows users of lldb to inspect the logical coroutine call stack without using any custom debug scripts (although the display is still a bit clumsy. It would be nicer to also integrate this into lldb's backtrace feature, but I don't know how to do so) The devirtualization currently works by introspecting the function pointed to by the `destroy` pointer. (The `resume` pointer is not worth much, given that for the final suspend point `resume` is set to a nullptr. We have to use the `destroy` pointer instead.) We then look for a `__promise` variable inside the `destroy` function. This `__promise` variable is synthetically generated by LLVM, and looking at its type reveals the type-erased promise_type. This approach only works for clang-generated code, though. While gcc also adds a `_Coro_promise` variable to the `resume` function, it does not do so for the `destroy` function. However, we can't use the `resume` function, as it will be reset to a nullptr at the final suspension point. For the time being, I am happy with de-virtualization only working for clang. A follow-up commit will further improve devirtualization and also expose the variables spilled to the coroutine frame. As part of this, I will also revisit gcc support. Differential Revision: https://reviews.llvm.org/D132624
208 lines
6.7 KiB
C++
208 lines
6.7 KiB
C++
//===-- Coroutines.cpp ----------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "Coroutines.h"
|
|
|
|
#include "Plugins/ExpressionParser/Clang/ClangASTImporter.h"
|
|
#include "Plugins/TypeSystem/Clang/TypeSystemClang.h"
|
|
#include "lldb/Symbol/Function.h"
|
|
#include "lldb/Symbol/VariableList.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
using namespace lldb_private::formatters;
|
|
|
|
static ValueObjectSP GetCoroFramePtrFromHandle(ValueObject &valobj) {
|
|
ValueObjectSP valobj_sp(valobj.GetNonSyntheticValue());
|
|
if (!valobj_sp)
|
|
return nullptr;
|
|
|
|
// We expect a single pointer in the `coroutine_handle` class.
|
|
// We don't care about its name.
|
|
if (valobj_sp->GetNumChildren() != 1)
|
|
return nullptr;
|
|
ValueObjectSP ptr_sp(valobj_sp->GetChildAtIndex(0, true));
|
|
if (!ptr_sp)
|
|
return nullptr;
|
|
if (!ptr_sp->GetCompilerType().IsPointerType())
|
|
return nullptr;
|
|
|
|
return ptr_sp;
|
|
}
|
|
|
|
static Function *ExtractDestroyFunction(ValueObjectSP &frame_ptr_sp) {
|
|
lldb::TargetSP target_sp = frame_ptr_sp->GetTargetSP();
|
|
lldb::ProcessSP process_sp = frame_ptr_sp->GetProcessSP();
|
|
auto ptr_size = process_sp->GetAddressByteSize();
|
|
|
|
AddressType addr_type;
|
|
lldb::addr_t frame_ptr_addr = frame_ptr_sp->GetPointerValue(&addr_type);
|
|
if (!frame_ptr_addr || frame_ptr_addr == LLDB_INVALID_ADDRESS)
|
|
return nullptr;
|
|
lldbassert(addr_type == AddressType::eAddressTypeLoad);
|
|
|
|
Status error;
|
|
// The destroy pointer is the 2nd pointer inside the compiler-generated
|
|
// `pair<resumePtr,destroyPtr>`.
|
|
auto destroy_func_ptr_addr = frame_ptr_addr + ptr_size;
|
|
lldb::addr_t destroy_func_addr =
|
|
process_sp->ReadPointerFromMemory(destroy_func_ptr_addr, error);
|
|
if (error.Fail())
|
|
return nullptr;
|
|
|
|
Address destroy_func_address;
|
|
if (!target_sp->ResolveLoadAddress(destroy_func_addr, destroy_func_address))
|
|
return nullptr;
|
|
|
|
Function *destroy_func =
|
|
destroy_func_address.CalculateSymbolContextFunction();
|
|
if (!destroy_func)
|
|
return nullptr;
|
|
|
|
return destroy_func;
|
|
}
|
|
|
|
static CompilerType InferPromiseType(Function &destroy_func) {
|
|
Block &block = destroy_func.GetBlock(true);
|
|
auto variable_list = block.GetBlockVariableList(true);
|
|
|
|
// clang generates an artificial `__promise` variable inside the
|
|
// `destroy` function. Look for it.
|
|
auto promise_var = variable_list->FindVariable(ConstString("__promise"));
|
|
if (!promise_var)
|
|
return {};
|
|
if (!promise_var->IsArtificial())
|
|
return {};
|
|
|
|
Type *promise_type = promise_var->GetType();
|
|
if (!promise_type)
|
|
return {};
|
|
return promise_type->GetForwardCompilerType();
|
|
}
|
|
|
|
static CompilerType GetCoroutineFrameType(TypeSystemClang &ast_ctx,
|
|
CompilerType promise_type) {
|
|
CompilerType void_type = ast_ctx.GetBasicType(lldb::eBasicTypeVoid);
|
|
CompilerType coro_func_type = ast_ctx.CreateFunctionType(
|
|
/*result_type=*/void_type, /*args=*/&void_type, /*num_args=*/1,
|
|
/*is_variadic=*/false, /*qualifiers=*/0);
|
|
CompilerType coro_abi_type;
|
|
if (promise_type.IsVoidType()) {
|
|
coro_abi_type = ast_ctx.CreateStructForIdentifier(
|
|
ConstString(), {{"resume", coro_func_type.GetPointerType()},
|
|
{"destroy", coro_func_type.GetPointerType()}});
|
|
} else {
|
|
coro_abi_type = ast_ctx.CreateStructForIdentifier(
|
|
ConstString(), {{"resume", coro_func_type.GetPointerType()},
|
|
{"destroy", coro_func_type.GetPointerType()},
|
|
{"promise", promise_type}});
|
|
}
|
|
return coro_abi_type;
|
|
}
|
|
|
|
bool lldb_private::formatters::StdlibCoroutineHandleSummaryProvider(
|
|
ValueObject &valobj, Stream &stream, const TypeSummaryOptions &options) {
|
|
ValueObjectSP ptr_sp(GetCoroFramePtrFromHandle(valobj));
|
|
if (!ptr_sp)
|
|
return false;
|
|
|
|
if (!ptr_sp->GetValueAsUnsigned(0)) {
|
|
stream << "nullptr";
|
|
} else {
|
|
stream.Printf("coro frame = 0x%" PRIx64, ptr_sp->GetValueAsUnsigned(0));
|
|
}
|
|
return true;
|
|
}
|
|
|
|
lldb_private::formatters::StdlibCoroutineHandleSyntheticFrontEnd::
|
|
StdlibCoroutineHandleSyntheticFrontEnd(lldb::ValueObjectSP valobj_sp)
|
|
: SyntheticChildrenFrontEnd(*valobj_sp),
|
|
m_ast_importer(std::make_unique<ClangASTImporter>()) {
|
|
if (valobj_sp)
|
|
Update();
|
|
}
|
|
|
|
lldb_private::formatters::StdlibCoroutineHandleSyntheticFrontEnd::
|
|
~StdlibCoroutineHandleSyntheticFrontEnd() = default;
|
|
|
|
size_t lldb_private::formatters::StdlibCoroutineHandleSyntheticFrontEnd::
|
|
CalculateNumChildren() {
|
|
if (!m_frame_ptr_sp)
|
|
return 0;
|
|
|
|
return m_frame_ptr_sp->GetNumChildren();
|
|
}
|
|
|
|
lldb::ValueObjectSP lldb_private::formatters::
|
|
StdlibCoroutineHandleSyntheticFrontEnd::GetChildAtIndex(size_t idx) {
|
|
if (!m_frame_ptr_sp)
|
|
return lldb::ValueObjectSP();
|
|
|
|
return m_frame_ptr_sp->GetChildAtIndex(idx, true);
|
|
}
|
|
|
|
bool lldb_private::formatters::StdlibCoroutineHandleSyntheticFrontEnd::
|
|
Update() {
|
|
m_frame_ptr_sp.reset();
|
|
|
|
ValueObjectSP valobj_sp = m_backend.GetSP();
|
|
if (!valobj_sp)
|
|
return false;
|
|
|
|
ValueObjectSP ptr_sp(GetCoroFramePtrFromHandle(m_backend));
|
|
if (!ptr_sp)
|
|
return false;
|
|
|
|
// Get the `promise_type` from the template argument
|
|
CompilerType promise_type(
|
|
valobj_sp->GetCompilerType().GetTypeTemplateArgument(0));
|
|
if (!promise_type)
|
|
return false;
|
|
|
|
// Try to infer the promise_type if it was type-erased
|
|
auto ts = valobj_sp->GetCompilerType().GetTypeSystem();
|
|
auto ast_ctx = ts.dyn_cast_or_null<TypeSystemClang>();
|
|
if (!ast_ctx)
|
|
return false;
|
|
if (promise_type.IsVoidType()) {
|
|
if (Function *destroy_func = ExtractDestroyFunction(ptr_sp)) {
|
|
if (CompilerType inferred_type = InferPromiseType(*destroy_func)) {
|
|
// Copy the type over to the correct `TypeSystemClang` instance
|
|
promise_type = m_ast_importer->CopyType(*ast_ctx, inferred_type);
|
|
}
|
|
}
|
|
}
|
|
|
|
// Build the coroutine frame type
|
|
CompilerType coro_frame_type = GetCoroutineFrameType(*ast_ctx, promise_type);
|
|
|
|
m_frame_ptr_sp = ptr_sp->Cast(coro_frame_type.GetPointerType());
|
|
|
|
return false;
|
|
}
|
|
|
|
bool lldb_private::formatters::StdlibCoroutineHandleSyntheticFrontEnd::
|
|
MightHaveChildren() {
|
|
return true;
|
|
}
|
|
|
|
size_t StdlibCoroutineHandleSyntheticFrontEnd::GetIndexOfChildWithName(
|
|
ConstString name) {
|
|
if (!m_frame_ptr_sp)
|
|
return UINT32_MAX;
|
|
|
|
return m_frame_ptr_sp->GetIndexOfChildWithName(name);
|
|
}
|
|
|
|
SyntheticChildrenFrontEnd *
|
|
lldb_private::formatters::StdlibCoroutineHandleSyntheticFrontEndCreator(
|
|
CXXSyntheticChildren *, lldb::ValueObjectSP valobj_sp) {
|
|
return (valobj_sp ? new StdlibCoroutineHandleSyntheticFrontEnd(valobj_sp)
|
|
: nullptr);
|
|
}
|