ffe7950ebc
I'm trying to remove unused options from the `Analyses.def` file, then merge the rest of the useful options into the `AnalyzerOptions.def`. Then make sure one can set these by an `-analyzer-config XXX=YYY` style flag. Then surface the `-analyzer-config` to the `clang` frontend; After all of this, we can pursue the tablegen approach described https://discourse.llvm.org/t/rfc-tablegen-clang-static-analyzer-engine-options-for-better-documentation/61488 In this patch, I'm proposing flag deprecations. We should support deprecated analyzer flags for exactly one release. In this case I'm planning to drop this flag in `clang-16`. In the clang frontend, now we won't pass this option to the cc1 frontend, rather emit a warning diagnostic reminding the users about this deprecated flag, which will be turned into error in clang-16. Unfortunately, I had to remove all the tests referring to this flag, causing a mass change. I've also added a test for checking this warning. I've seen that `scan-build` also uses this flag, but I think we should remove that part only after we turn this into a hard error. Reviewed By: martong Differential Revision: https://reviews.llvm.org/D126215
57 lines
1.5 KiB
Objective-C
57 lines
1.5 KiB
Objective-C
// RUN: %clang_analyze_cc1 -analyzer-checker=core,unix.Malloc -verify -Wno-objc-root-class -fblocks %s
|
|
#include "Inputs/system-header-simulator-objc.h"
|
|
|
|
@class NSString;
|
|
typedef __typeof(sizeof(int)) size_t;
|
|
void *malloc(size_t);
|
|
void free(void *);
|
|
|
|
// RDar10579586 - Test use of malloc() with Objective-C string literal as a
|
|
// test condition. Not really a malloc() issue, but this also exercises
|
|
// the check that malloc() returns uninitialized memory.
|
|
@interface RDar10579586
|
|
struct rdar0579586_str {
|
|
char str_c;
|
|
};
|
|
@end
|
|
|
|
void rdar10579586(char x);
|
|
|
|
@implementation RDar10579586
|
|
+ (NSString *)foobar
|
|
{
|
|
struct rdar0579586_str *buffer = ((void*)0);
|
|
NSString *error = ((void*)0);
|
|
|
|
if ((buffer = malloc(sizeof(struct rdar0579586_str))) == ((void*)0))
|
|
error = @"buffer allocation failure";
|
|
|
|
if (error != ((void*)0))
|
|
return error;
|
|
|
|
rdar10579586(buffer->str_c); // expected-warning {{1st function call argument is an uninitialized value}}
|
|
free(buffer);
|
|
return ((void*)0);
|
|
}
|
|
@end
|
|
|
|
@interface MyArray : NSObject {
|
|
id * objects;
|
|
}
|
|
@end
|
|
|
|
void _ArrayCreate(void) {
|
|
MyArray *array = (MyArray *)malloc(12);
|
|
array = [array init];
|
|
free(array); // no-warning
|
|
}
|
|
|
|
void testNSDataTruePositiveLeak(void) {
|
|
char *b = (char *)malloc(12);
|
|
NSData *d = [[NSData alloc] initWithBytes: b length: 12]; // expected-warning {{Potential leak of memory pointed to by 'b'}}
|
|
}
|
|
|
|
id wrapInNSValue(void) {
|
|
void *buffer = malloc(4);
|
|
return [NSValue valueWithPointer:buffer]; // no-warning
|
|
} |