
This patch simplifies the diagnostic message in the core.StackAddrEscape for stack memory associated with compound literals by removing the redundant "returned to caller" suffix. Example: https://godbolt.org/z/KxM67vr7c ```c // clang --analyze -Xanalyzer -analyzer-checker=core.StackAddressEscape void* compound_literal() { return &(unsigned short){((unsigned short)0x22EF)}; } ``` warning: Address of stack memory associated with a compound literal declared on line 2 **returned to caller returned to caller** [core.StackAddressEscape]
151 lines
4.4 KiB
C
151 lines
4.4 KiB
C
// RUN: %clang_analyze_cc1 -analyzer-checker=core,unix.Malloc -fblocks -verify %s
|
|
|
|
int* f1(void) {
|
|
int x = 0;
|
|
return &x; // expected-warning{{Address of stack memory associated with local variable 'x' returned}} expected-warning{{address of stack memory associated with local variable 'x' returned}}
|
|
}
|
|
|
|
int* f2(int y) {
|
|
return &y; // expected-warning{{Address of stack memory associated with local variable 'y' returned}} expected-warning{{address of stack memory associated with parameter 'y' returned}}
|
|
}
|
|
|
|
int* f3(int x, int *y) {
|
|
int w = 0;
|
|
|
|
if (x)
|
|
y = &w;
|
|
|
|
return y; // expected-warning{{Address of stack memory associated with local variable 'w' returned to caller}}
|
|
}
|
|
|
|
void* compound_literal(int x, int y) {
|
|
if (x)
|
|
return &(unsigned short){((unsigned short)0x22EF)};
|
|
// expected-warning-re@-1{{Address of stack memory associated with a compound literal declared on line {{[0-9]+}} returned to caller [core.StackAddressEscape]}}
|
|
// expected-warning@-2{{address of stack memory}}
|
|
|
|
int* array[] = {};
|
|
struct s { int z; double y; int w; };
|
|
|
|
if (y)
|
|
return &((struct s){ 2, 0.4, 5 * 8 });
|
|
// expected-warning-re@-1{{Address of stack memory associated with a compound literal declared on line {{[0-9]+}} returned to caller [core.StackAddressEscape]}}
|
|
// expected-warning@-2{{address of stack memory}}
|
|
|
|
void* p = &((struct s){ 42, 0.4, x ? 42 : 0 });
|
|
return p;
|
|
// expected-warning-re@-1{{Address of stack memory associated with a compound literal declared on line {{[0-9]+}} returned to caller [core.StackAddressEscape]}}
|
|
}
|
|
|
|
void* alloca_test(void) {
|
|
void* p = __builtin_alloca(10);
|
|
return p; // expected-warning{{Address of stack memory}}
|
|
}
|
|
|
|
int array_test(int x[2]) {
|
|
return x[0]; // no-warning
|
|
}
|
|
|
|
struct baz {
|
|
int x;
|
|
int y[2];
|
|
};
|
|
|
|
int struct_test(struct baz byVal, int flag) {
|
|
if (flag)
|
|
return byVal.x; // no-warning
|
|
else {
|
|
return byVal.y[0]; // no-warning
|
|
}
|
|
}
|
|
|
|
typedef int (^ComparatorBlock)(int a, int b);
|
|
ComparatorBlock test_return_block(void) {
|
|
// This block is a global since it has no captures.
|
|
ComparatorBlock b = ^int(int a, int b){ return a > b; };
|
|
return b; // no-warning
|
|
}
|
|
|
|
ComparatorBlock test_return_block_with_capture(int x) {
|
|
// This block is stack allocated because it has captures.
|
|
ComparatorBlock b = ^int(int a, int b){ return a > b + x; };
|
|
return b; // expected-warning{{Address of stack-allocated block}}
|
|
}
|
|
|
|
ComparatorBlock test_return_block_neg_aux(void);
|
|
ComparatorBlock test_return_block_neg(void) {
|
|
ComparatorBlock b = test_return_block_neg_aux();
|
|
return b; // no-warning
|
|
}
|
|
|
|
int *rdar_7523821_f2(void) {
|
|
int a[3];
|
|
return a; // expected-warning 2 {{ddress of stack memory associated with local variable 'a' returned}}
|
|
};
|
|
|
|
// Handle blocks that have no captures or are otherwise declared 'static'.
|
|
typedef int (^RDar10348049)(int value);
|
|
RDar10348049 test_rdar10348049(void) {
|
|
static RDar10348049 b = ^int(int x) {
|
|
return x + 2;
|
|
};
|
|
return b; // no-warning
|
|
}
|
|
|
|
void testRegister(register const char *reg) {
|
|
if (reg) (void)reg[0];
|
|
}
|
|
void callTestRegister(void) {
|
|
char buf[20];
|
|
testRegister(buf); // no-warning
|
|
}
|
|
|
|
void top_level_leaking(int **out) {
|
|
int local = 42;
|
|
*out = &local; // expected-warning{{Address of stack memory associated with local variable 'local' is still referred to by the caller variable 'out'}}
|
|
}
|
|
|
|
void callee_leaking_via_param(int **out) {
|
|
int local = 1;
|
|
*out = &local;
|
|
// expected-warning@-1{{Address of stack memory associated with local variable 'local' is still referred to by the caller variable 'ptr'}}
|
|
}
|
|
|
|
void caller_for_leaking_callee() {
|
|
int *ptr = 0;
|
|
callee_leaking_via_param(&ptr);
|
|
}
|
|
|
|
void callee_nested_leaking(int **out) {
|
|
int local = 1;
|
|
*out = &local;
|
|
// expected-warning@-1{{Address of stack memory associated with local variable 'local' is still referred to by the caller variable 'ptr'}}
|
|
}
|
|
|
|
void caller_mid_for_nested_leaking(int **mid) {
|
|
callee_nested_leaking(mid);
|
|
}
|
|
|
|
void caller_for_nested_leaking() {
|
|
int *ptr = 0;
|
|
caller_mid_for_nested_leaking(&ptr);
|
|
}
|
|
|
|
// This used to crash StackAddrEscapeChecker because
|
|
// it features a symbol conj_$1{struct c *, LC1, S763, #1}
|
|
// that has no origin region.
|
|
struct a {
|
|
int member;
|
|
};
|
|
|
|
struct c {
|
|
struct a *nested_ptr;
|
|
};
|
|
void opaque(struct c*);
|
|
struct c* get_c(void);
|
|
void no_crash_for_symbol_without_origin_region(void) {
|
|
struct c *ptr = get_c();
|
|
opaque(ptr);
|
|
ptr->nested_ptr->member++;
|
|
} // No crash at the end of the function
|