7c402b8b81
The checks for the 'z' and 't' format specifiers added in the original PR #143653 had some issues and were overly strict, causing some build failures and were consequently reverted at4c85bf2fe8. In the latest commit27c58629ec, I relaxed the checks for the 'z' and 't' format specifiers, so warnings are now only issued when they are used with mismatched types. The original intent of these checks was to diagnose code that assumes the underlying type of `size_t` is `unsigned` or `unsigned long`, for example: ```c printf("%zu", 1ul); // Not portable, but not an error when size_t is unsigned long ``` However, it produced a significant number of false positives. This was partly because Clang does not treat the `typedef` `size_t` and `__size_t` as having a common "sugar" type, and partly because a large amount of existing code either assumes `unsigned` (or `unsigned long`) is `size_t`, or they define the equivalent of size_t in their own way (such as sanitizer_internal_defs.h).2e67dcfdcd/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h (L203)
247 lines
8.4 KiB
C
247 lines
8.4 KiB
C
// RUN: %clang_analyze_cc1 %s \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=unix.StdCLibraryFunctions \
|
|
// RUN: -analyzer-checker=debug.ExprInspection \
|
|
// RUN: -analyzer-config eagerly-assume=false \
|
|
// RUN: -analyzer-config unix.StdCLibraryFunctions:ModelPOSIX=false \
|
|
// RUN: -triple i686-unknown-linux \
|
|
// RUN: -verify
|
|
|
|
// RUN: %clang_analyze_cc1 %s \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=unix.StdCLibraryFunctions \
|
|
// RUN: -analyzer-checker=debug.ExprInspection \
|
|
// RUN: -analyzer-config eagerly-assume=false \
|
|
// RUN: -analyzer-config unix.StdCLibraryFunctions:ModelPOSIX=false \
|
|
// RUN: -triple x86_64-unknown-linux \
|
|
// RUN: -verify
|
|
|
|
// RUN: %clang_analyze_cc1 %s \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=unix.StdCLibraryFunctions \
|
|
// RUN: -analyzer-checker=debug.ExprInspection \
|
|
// RUN: -analyzer-config eagerly-assume=false \
|
|
// RUN: -analyzer-config unix.StdCLibraryFunctions:ModelPOSIX=false \
|
|
// RUN: -triple armv7-a15-linux \
|
|
// RUN: -verify
|
|
|
|
// RUN: %clang_analyze_cc1 %s \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=unix.StdCLibraryFunctions \
|
|
// RUN: -analyzer-checker=debug.ExprInspection \
|
|
// RUN: -analyzer-config eagerly-assume=false \
|
|
// RUN: -analyzer-config unix.StdCLibraryFunctions:ModelPOSIX=false \
|
|
// RUN: -triple thumbv7-a15-linux \
|
|
// RUN: -verify
|
|
|
|
// RUN: %clang_analyze_cc1 %s \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=unix.StdCLibraryFunctions \
|
|
// RUN: -analyzer-config unix.StdCLibraryFunctions:DisplayLoadedSummaries=true \
|
|
// RUN: -analyzer-checker=debug.ExprInspection \
|
|
// RUN: -analyzer-config eagerly-assume=false \
|
|
// RUN: -analyzer-config unix.StdCLibraryFunctions:ModelPOSIX=false \
|
|
// RUN: -triple i686-unknown-linux 2>&1 | FileCheck %s
|
|
|
|
// CHECK: Loaded summary for: int isalnum(int)
|
|
// CHECK-NEXT: Loaded summary for: int isalpha(int)
|
|
// CHECK-NEXT: Loaded summary for: int isascii(int)
|
|
// CHECK-NEXT: Loaded summary for: int isblank(int)
|
|
// CHECK-NEXT: Loaded summary for: int isdigit(int)
|
|
// CHECK-NEXT: Loaded summary for: int isgraph(int)
|
|
// CHECK-NEXT: Loaded summary for: int islower(int)
|
|
// CHECK-NEXT: Loaded summary for: int isprint(int)
|
|
// CHECK-NEXT: Loaded summary for: int ispunct(int)
|
|
// CHECK-NEXT: Loaded summary for: int isspace(int)
|
|
// CHECK-NEXT: Loaded summary for: int isupper(int)
|
|
// CHECK-NEXT: Loaded summary for: int isxdigit(int)
|
|
// CHECK-NEXT: Loaded summary for: int toupper(int)
|
|
// CHECK-NEXT: Loaded summary for: int tolower(int)
|
|
// CHECK-NEXT: Loaded summary for: int toascii(int)
|
|
// CHECK-NEXT: Loaded summary for: int getchar(void)
|
|
// CHECK-NEXT: Loaded summary for: __size_t fread(void *restrict, size_t, size_t, FILE *restrict)
|
|
// CHECK-NEXT: Loaded summary for: __size_t fwrite(const void *restrict, size_t, size_t, FILE *restrict)
|
|
// CHECK-NEXT: Loaded summary for: ssize_t read(int, void *, size_t)
|
|
// CHECK-NEXT: Loaded summary for: ssize_t write(int, const void *, size_t)
|
|
// CHECK-NEXT: Loaded summary for: ssize_t getline(char **restrict, size_t *restrict, FILE *restrict)
|
|
// CHECK-NEXT: Loaded summary for: ssize_t getdelim(char **restrict, size_t *restrict, int, FILE *restrict)
|
|
// CHECK-NEXT: Loaded summary for: char *getenv(const char *)
|
|
// CHECK-NEXT: Loaded summary for: int getc(FILE *)
|
|
// CHECK-NEXT: Loaded summary for: int fgetc(FILE *)
|
|
|
|
#include "Inputs/std-c-library-functions.h"
|
|
|
|
void clang_analyzer_eval(int);
|
|
|
|
int glob;
|
|
|
|
void test_getc(FILE *fp) {
|
|
int x;
|
|
while ((x = getc(fp)) != EOF) {
|
|
clang_analyzer_eval(x > 255); // expected-warning{{FALSE}}
|
|
clang_analyzer_eval(x >= 0); // expected-warning{{TRUE}}
|
|
}
|
|
}
|
|
|
|
void test_fgets(FILE *fp) {
|
|
clang_analyzer_eval(fgetc(fp) < 256); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(fgetc(fp) >= 0); // expected-warning{{UNKNOWN}}
|
|
}
|
|
|
|
void test_read_write(int fd, char *buf) {
|
|
glob = 1;
|
|
ssize_t x = write(fd, buf, 10);
|
|
clang_analyzer_eval(glob); // expected-warning{{UNKNOWN}}
|
|
if (x >= 0) {
|
|
clang_analyzer_eval(x <= 10); // expected-warning{{TRUE}}
|
|
ssize_t y = read(fd, &glob, sizeof(glob));
|
|
if (y >= 0) {
|
|
clang_analyzer_eval(y <= sizeof(glob)); // expected-warning{{TRUE}}
|
|
} else {
|
|
// -1 overflows on promotion!
|
|
clang_analyzer_eval(y <= sizeof(glob)); // expected-warning{{FALSE}}
|
|
}
|
|
} else {
|
|
clang_analyzer_eval(x == -1); // expected-warning{{TRUE}}
|
|
}
|
|
}
|
|
|
|
void test_fread_fwrite(FILE *fp, int *buf) {
|
|
|
|
size_t x = fwrite(buf, sizeof(int), 10, fp);
|
|
clang_analyzer_eval(x <= 10); // expected-warning{{TRUE}}
|
|
|
|
size_t y = fread(buf, sizeof(int), 10, fp);
|
|
clang_analyzer_eval(y <= 10); // expected-warning{{TRUE}}
|
|
|
|
size_t z = fwrite(buf, sizeof(int), y, fp);
|
|
clang_analyzer_eval(z <= y); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void test_fread_uninitialized(void) {
|
|
void *ptr;
|
|
size_t sz;
|
|
size_t nmem;
|
|
FILE *fp;
|
|
(void)fread(ptr, sz, nmem, fp); // expected-warning {{1st function call argument is an uninitialized value}}
|
|
}
|
|
|
|
void test_getline(FILE *fp) {
|
|
char *line = 0;
|
|
size_t n = 0;
|
|
ssize_t len;
|
|
while ((len = getline(&line, &n, fp)) != -1) {
|
|
clang_analyzer_eval(len == 0); // expected-warning{{FALSE}}
|
|
}
|
|
}
|
|
|
|
void test_isascii(int x) {
|
|
clang_analyzer_eval(isascii(123)); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(isascii(-1)); // expected-warning{{FALSE}}
|
|
if (isascii(x)) {
|
|
clang_analyzer_eval(x < 128); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(x >= 0); // expected-warning{{TRUE}}
|
|
} else {
|
|
if (x > 42)
|
|
clang_analyzer_eval(x >= 128); // expected-warning{{TRUE}}
|
|
else
|
|
clang_analyzer_eval(x < 0); // expected-warning{{TRUE}}
|
|
}
|
|
glob = 1;
|
|
isascii('a');
|
|
clang_analyzer_eval(glob); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void test_islower(int x) {
|
|
clang_analyzer_eval(islower('x')); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(islower('X')); // expected-warning{{FALSE}}
|
|
if (islower(x))
|
|
clang_analyzer_eval(x < 'a'); // expected-warning{{FALSE}}
|
|
}
|
|
|
|
void test_getchar(void) {
|
|
int x = getchar();
|
|
if (x == EOF)
|
|
return;
|
|
clang_analyzer_eval(x < 0); // expected-warning{{FALSE}}
|
|
clang_analyzer_eval(x < 256); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void test_isalpha(void) {
|
|
clang_analyzer_eval(isalpha(']')); // expected-warning{{FALSE}}
|
|
clang_analyzer_eval(isalpha('Q')); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(isalpha(128)); // expected-warning{{UNKNOWN}}
|
|
}
|
|
|
|
void test_alnum(void) {
|
|
clang_analyzer_eval(isalnum('1')); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(isalnum(')')); // expected-warning{{FALSE}}
|
|
}
|
|
|
|
void test_isblank(void) {
|
|
clang_analyzer_eval(isblank('\t')); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(isblank(' ')); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(isblank('\n')); // expected-warning{{FALSE}}
|
|
}
|
|
|
|
void test_ispunct(int x) {
|
|
clang_analyzer_eval(ispunct(' ')); // expected-warning{{FALSE}}
|
|
clang_analyzer_eval(ispunct(-1)); // expected-warning{{FALSE}}
|
|
clang_analyzer_eval(ispunct('#')); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(ispunct('_')); // expected-warning{{TRUE}}
|
|
if (ispunct(x))
|
|
clang_analyzer_eval(x < 127); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void test_isupper(int x) {
|
|
if (isupper(x))
|
|
clang_analyzer_eval(x < 'A'); // expected-warning{{FALSE}}
|
|
}
|
|
|
|
void test_isgraph_isprint(int x) {
|
|
char y = x;
|
|
if (isgraph(y))
|
|
clang_analyzer_eval(isprint(x)); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void test_mixed_branches(int x) {
|
|
if (isdigit(x)) {
|
|
clang_analyzer_eval(isgraph(x)); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(isblank(x)); // expected-warning{{FALSE}}
|
|
} else if (isascii(x)) {
|
|
// isalnum() bifurcates here.
|
|
clang_analyzer_eval(isalnum(x)); // expected-warning{{TRUE}} // expected-warning{{FALSE}}
|
|
clang_analyzer_eval(isprint(x)); // expected-warning{{TRUE}} // expected-warning{{FALSE}}
|
|
}
|
|
}
|
|
|
|
void test_isspace(int x) {
|
|
if (!isascii(x))
|
|
return;
|
|
char y = x;
|
|
if (y == ' ')
|
|
clang_analyzer_eval(isspace(x)); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void test_isxdigit(int x) {
|
|
if (isxdigit(x) && isupper(x)) {
|
|
clang_analyzer_eval(x >= 'A'); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(x <= 'F'); // expected-warning{{TRUE}}
|
|
}
|
|
}
|
|
|
|
void test_call_by_pointer(void) {
|
|
typedef int (*func)(int);
|
|
func f = isascii;
|
|
clang_analyzer_eval(f('A')); // expected-warning{{TRUE}}
|
|
f = ispunct;
|
|
clang_analyzer_eval(f('A')); // expected-warning{{FALSE}}
|
|
}
|
|
|
|
void test_getenv(void) {
|
|
// getenv() bifurcates here.
|
|
clang_analyzer_eval(getenv("FOO") == 0);
|
|
// expected-warning@-1 {{TRUE}}
|
|
// expected-warning@-2 {{FALSE}}
|
|
}
|