04b4190489
If clang is passed "-include foo.h", it will rewrite to "-include-pch foo.h.pch" before passing it to cc1, if foo.h.pch exists. Existence is checked, but validity is not. This is probably a reasonable assumption for the compiler itself, but not for clang-based tools where the actual compiler may be a different version of clang, or even GCC. In the end, we lose our -include, we gain a -include-pch that can't be used, and the file often fails to parse. I would like to turn this off for all non-clang invocations (i.e. createInvocationFromCommandLine), but we have explicit tests of this behavior for libclang and I can't work out the implications of changing it. Instead this patch: - makes it optional in the driver, default on (no change) - makes it optional in createInvocationFromCommandLine, default on (no change) - changes driver to do IO through the VFS so it can be tested - tests the option - turns the option off in clangd where the problem was reported Subsequent patches should make libclang opt in explicitly and flip the default for all other tools. It's probably also time to extract an options struct for createInvocationFromCommandLine. Fixes https://github.com/clangd/clangd/issues/856 Fixes https://github.com/clangd/vscode-clangd/issues/324 Differential Revision: https://reviews.llvm.org/D124970
116 lines
4.3 KiB
C++
116 lines
4.3 KiB
C++
//===--- CreateInvocationFromCommandLine.cpp - CompilerInvocation from Args ==//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Construct a compiler invocation object for command line driver arguments
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/Basic/DiagnosticOptions.h"
|
|
#include "clang/Driver/Action.h"
|
|
#include "clang/Driver/Compilation.h"
|
|
#include "clang/Driver/Driver.h"
|
|
#include "clang/Driver/Options.h"
|
|
#include "clang/Driver/Tool.h"
|
|
#include "clang/Frontend/CompilerInstance.h"
|
|
#include "clang/Frontend/FrontendDiagnostic.h"
|
|
#include "clang/Frontend/Utils.h"
|
|
#include "llvm/ADT/STLExtras.h"
|
|
#include "llvm/ADT/StringRef.h"
|
|
#include "llvm/Option/ArgList.h"
|
|
#include "llvm/Support/Host.h"
|
|
using namespace clang;
|
|
using namespace llvm::opt;
|
|
|
|
std::unique_ptr<CompilerInvocation>
|
|
clang::createInvocation(ArrayRef<const char *> ArgList,
|
|
CreateInvocationOptions Opts) {
|
|
assert(!ArgList.empty());
|
|
auto Diags = Opts.Diags
|
|
? std::move(Opts.Diags)
|
|
: CompilerInstance::createDiagnostics(new DiagnosticOptions);
|
|
|
|
SmallVector<const char *, 16> Args(ArgList.begin(), ArgList.end());
|
|
|
|
// FIXME: Find a cleaner way to force the driver into restricted modes.
|
|
Args.insert(
|
|
llvm::find_if(
|
|
Args, [](const char *Elem) { return llvm::StringRef(Elem) == "--"; }),
|
|
"-fsyntax-only");
|
|
|
|
// FIXME: We shouldn't have to pass in the path info.
|
|
driver::Driver TheDriver(Args[0], llvm::sys::getDefaultTargetTriple(), *Diags,
|
|
"clang LLVM compiler", Opts.VFS);
|
|
|
|
// Don't check that inputs exist, they may have been remapped.
|
|
TheDriver.setCheckInputsExist(false);
|
|
TheDriver.setProbePrecompiled(Opts.ProbePrecompiled);
|
|
|
|
std::unique_ptr<driver::Compilation> C(TheDriver.BuildCompilation(Args));
|
|
if (!C)
|
|
return nullptr;
|
|
|
|
// Just print the cc1 options if -### was present.
|
|
if (C->getArgs().hasArg(driver::options::OPT__HASH_HASH_HASH)) {
|
|
C->getJobs().Print(llvm::errs(), "\n", true);
|
|
return nullptr;
|
|
}
|
|
|
|
// We expect to get back exactly one command job, if we didn't something
|
|
// failed. Offload compilation is an exception as it creates multiple jobs. If
|
|
// that's the case, we proceed with the first job. If caller needs a
|
|
// particular job, it should be controlled via options (e.g.
|
|
// --cuda-{host|device}-only for CUDA) passed to the driver.
|
|
const driver::JobList &Jobs = C->getJobs();
|
|
bool OffloadCompilation = false;
|
|
if (Jobs.size() > 1) {
|
|
for (auto &A : C->getActions()){
|
|
// On MacOSX real actions may end up being wrapped in BindArchAction
|
|
if (isa<driver::BindArchAction>(A))
|
|
A = *A->input_begin();
|
|
if (isa<driver::OffloadAction>(A)) {
|
|
OffloadCompilation = true;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
bool PickFirstOfMany = OffloadCompilation || Opts.RecoverOnError;
|
|
if (Jobs.size() == 0 || (Jobs.size() > 1 && !PickFirstOfMany)) {
|
|
SmallString<256> Msg;
|
|
llvm::raw_svector_ostream OS(Msg);
|
|
Jobs.Print(OS, "; ", true);
|
|
Diags->Report(diag::err_fe_expected_compiler_job) << OS.str();
|
|
return nullptr;
|
|
}
|
|
auto Cmd = llvm::find_if(Jobs, [](const driver::Command &Cmd) {
|
|
return StringRef(Cmd.getCreator().getName()) == "clang";
|
|
});
|
|
if (Cmd == Jobs.end()) {
|
|
Diags->Report(diag::err_fe_expected_clang_command);
|
|
return nullptr;
|
|
}
|
|
|
|
const ArgStringList &CCArgs = Cmd->getArguments();
|
|
if (Opts.CC1Args)
|
|
*Opts.CC1Args = {CCArgs.begin(), CCArgs.end()};
|
|
auto CI = std::make_unique<CompilerInvocation>();
|
|
if (!CompilerInvocation::CreateFromArgs(*CI, CCArgs, *Diags, Args[0]) &&
|
|
!Opts.RecoverOnError)
|
|
return nullptr;
|
|
return CI;
|
|
}
|
|
|
|
std::unique_ptr<CompilerInvocation> clang::createInvocationFromCommandLine(
|
|
ArrayRef<const char *> Args, IntrusiveRefCntPtr<DiagnosticsEngine> Diags,
|
|
IntrusiveRefCntPtr<llvm::vfs::FileSystem> VFS, bool ShouldRecoverOnErrors,
|
|
std::vector<std::string> *CC1Args, bool ProbePrecompiled) {
|
|
return createInvocation(
|
|
Args, CreateInvocationOptions{Diags, VFS, ShouldRecoverOnErrors,
|
|
ProbePrecompiled, CC1Args});
|
|
}
|