c000f754bf
Found while running libc++'s test suite with MSVC's STL, where we use
both MSVC's compiler and Clang/LLVM.
MSVC's compiler rejects the non-Standard extension of zero-length
arrays. For conformance, I'm changing these occurrences to
`std::array<int, 0>`.
Many of these files already had `#include <array>`; I'm adding it to the
rest.
I wanted to add `-Wzero-length-array` to
`libcxx/utils/libcxx/test/params.py` to prevent future occurrences, but
it complained about product code 😿 :
```
In file included from /home/runner/_work/llvm-project/llvm-project/libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/long.pass.cpp:18:
In file included from /home/runner/_work/llvm-project/llvm-project/build/generic-cxx03/include/c++/v1/istream:170:
In file included from /home/runner/_work/llvm-project/llvm-project/build/generic-cxx03/include/c++/v1/ostream:172:
In file included from /home/runner/_work/llvm-project/llvm-project/build/generic-cxx03/include/c++/v1/__system_error/error_code.h:18:
In file included from /home/runner/_work/llvm-project/llvm-project/build/generic-cxx03/include/c++/v1/__system_error/error_category.h:15:
/home/runner/_work/llvm-project/llvm-project/build/generic-cxx03/include/c++/v1/string:811:25: error: zero size arrays are an extension [-Werror,-Wzero-length-array]
811 | char __padding_[sizeof(value_type) - 1];
| ^~~~~~~~~~~~~~~~~~~~~~
/home/runner/_work/llvm-project/llvm-project/build/generic-cxx03/include/c++/v1/string:817:19: note: in instantiation of member class 'std::basic_string<char>::__short' requested here
817 | static_assert(sizeof(__short) == (sizeof(value_type) * (__min_cap + 1)), "__short has an unexpected size.");
| ^
/home/runner/_work/llvm-project/llvm-project/build/generic-cxx03/include/c++/v1/string:2069:5: note: in instantiation of template class 'std::basic_string<char>' requested here
2069 | _LIBCPP_STRING_V1_EXTERN_TEMPLATE_LIST(_LIBCPP_DECLARE, char)
| ^
/home/runner/_work/llvm-project/llvm-project/build/generic-cxx03/include/c++/v1/__string/extern_template_lists.h:31:60: note: expanded from macro '_LIBCPP_STRING_V1_EXTERN_TEMPLATE_LIST'
31 | _Func(_LIBCPP_EXPORTED_FROM_ABI basic_string<_CharType>& basic_string<_CharType>::replace(size_type, size_type, value_type const*, size_type)) \
| ^
```
I pushed a tiny commit to fix unrelated comment typos, in an attempt to
clear out spurious CI failures.
65 lines
1.8 KiB
C++
65 lines
1.8 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// <algorithm>
|
|
|
|
// template<RandomAccessIterator Iter>
|
|
// requires ShuffleIterator<Iter>
|
|
// void
|
|
// random_shuffle(Iter first, Iter last);
|
|
|
|
// REQUIRES: c++03 || c++11 || c++14
|
|
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
|
|
|
|
#include <algorithm>
|
|
#include <array>
|
|
#include <cassert>
|
|
|
|
#include "test_macros.h"
|
|
#include "test_iterators.h"
|
|
|
|
template <class Iter>
|
|
void
|
|
test_with_iterator()
|
|
{
|
|
std::array<int, 0> empty = {};
|
|
std::random_shuffle(Iter(empty.data()), Iter(empty.data()));
|
|
|
|
const int all_elements[] = {1, 2, 3, 4};
|
|
int shuffled[] = {1, 2, 3, 4};
|
|
const unsigned size = sizeof(all_elements) / sizeof(all_elements[0]);
|
|
|
|
std::random_shuffle(Iter(shuffled), Iter(shuffled + size));
|
|
assert(std::is_permutation(shuffled, shuffled + size, all_elements));
|
|
|
|
std::random_shuffle(Iter(shuffled), Iter(shuffled + size));
|
|
assert(std::is_permutation(shuffled, shuffled + size, all_elements));
|
|
}
|
|
|
|
|
|
int main(int, char**)
|
|
{
|
|
int ia[] = {1, 2, 3, 4};
|
|
int ia1[] = {1, 4, 3, 2};
|
|
int ia2[] = {4, 1, 2, 3};
|
|
const unsigned sa = sizeof(ia)/sizeof(ia[0]);
|
|
|
|
std::random_shuffle(ia, ia+sa);
|
|
LIBCPP_ASSERT(std::equal(ia, ia+sa, ia1));
|
|
assert(std::is_permutation(ia, ia+sa, ia1));
|
|
|
|
std::random_shuffle(ia, ia+sa);
|
|
LIBCPP_ASSERT(std::equal(ia, ia+sa, ia2));
|
|
assert(std::is_permutation(ia, ia+sa, ia2));
|
|
|
|
test_with_iterator<random_access_iterator<int*> >();
|
|
test_with_iterator<int*>();
|
|
|
|
return 0;
|
|
}
|