7068aa9841
Clang has traditionally allowed C programs to implicitly convert integers to pointers and pointers to integers, despite it not being valid to do so except under special circumstances (like converting the integer 0, which is the null pointer constant, to a pointer). In C89, this would result in undefined behavior per 3.3.4, and in C99 this rule was strengthened to be a constraint violation instead. Constraint violations are most often handled as an error. This patch changes the warning to default to an error in all C modes (it is already an error in C++). This gives us better security posture by calling out potential programmer mistakes in code but still allows users who need this behavior to use -Wno-error=int-conversion to retain the warning behavior, or -Wno-int-conversion to silence the diagnostic entirely. Differential Revision: https://reviews.llvm.org/D129881
54 lines
1.2 KiB
Objective-C
54 lines
1.2 KiB
Objective-C
// RUN: %clang_analyze_cc1 -w -Wno-int-conversion %s -verify \
|
|
// RUN: -analyzer-checker=core,alpha.core,debug.ExprInspection
|
|
|
|
#ifdef HEADER // A clever trick to avoid splitting up the test.
|
|
extern void clang_analyzer_eval(int);
|
|
|
|
@interface NSObject
|
|
@end
|
|
|
|
@interface HeaderClass : NSObject
|
|
@property NSObject *prop;
|
|
@end
|
|
|
|
#else
|
|
#define HEADER
|
|
#include "ObjCProperties.m"
|
|
|
|
@implementation HeaderClass
|
|
- (void)foo {
|
|
if ((self.prop)) {
|
|
}
|
|
|
|
// This test tests that no dynamic bifurcation is performed on the property.
|
|
// The TRUE/FALSE dilemma correctly arises from eagerly-assume behavior
|
|
// inside the if-statement. The dynamic bifurcation at (self.prop) inside
|
|
// the if-statement was causing an UNKNOWN to show up as well due to
|
|
// extra parentheses being caught inside PseudoObjectExpr.
|
|
// This should not be UNKNOWN.
|
|
clang_analyzer_eval(self.prop); // expected-warning{{TRUE}}
|
|
// expected-warning@-1{{FALSE}}
|
|
}
|
|
@end
|
|
|
|
|
|
// The point of this test cases is to exercise properties in the static
|
|
// analyzer
|
|
|
|
@interface MyClass {
|
|
@private
|
|
id _X;
|
|
}
|
|
- (id)initWithY:(id)Y;
|
|
@property(copy, readwrite) id X;
|
|
@end
|
|
|
|
@implementation MyClass
|
|
@synthesize X = _X;
|
|
- (id)initWithY:(id)Y {
|
|
self.X = Y;
|
|
return self;
|
|
}
|
|
@end
|
|
#endif
|