ffe7950ebc
I'm trying to remove unused options from the `Analyses.def` file, then merge the rest of the useful options into the `AnalyzerOptions.def`. Then make sure one can set these by an `-analyzer-config XXX=YYY` style flag. Then surface the `-analyzer-config` to the `clang` frontend; After all of this, we can pursue the tablegen approach described https://discourse.llvm.org/t/rfc-tablegen-clang-static-analyzer-engine-options-for-better-documentation/61488 In this patch, I'm proposing flag deprecations. We should support deprecated analyzer flags for exactly one release. In this case I'm planning to drop this flag in `clang-16`. In the clang frontend, now we won't pass this option to the cc1 frontend, rather emit a warning diagnostic reminding the users about this deprecated flag, which will be turned into error in clang-16. Unfortunately, I had to remove all the tests referring to this flag, causing a mass change. I've also added a test for checking this warning. I've seen that `scan-build` also uses this flag, but I think we should remove that part only after we turn this into a hard error. Reviewed By: martong Differential Revision: https://reviews.llvm.org/D126215
100 lines
2.4 KiB
Plaintext
100 lines
2.4 KiB
Plaintext
// RUN: %clang_analyze_cc1 -analyzer-checker=core,osx.cocoa.RetainCount,debug.ExprInspection -verify -Wno-objc-root-class %s
|
|
// RUN: %clang_analyze_cc1 -analyzer-checker=core,osx.cocoa.RetainCount,debug.ExprInspection -verify -Wno-objc-root-class -fobjc-arc %s
|
|
|
|
void clang_analyzer_eval(bool);
|
|
void clang_analyzer_checkInlined(bool);
|
|
|
|
@interface IntWrapper
|
|
@property (readonly) int &value;
|
|
@end
|
|
|
|
@implementation IntWrapper
|
|
@synthesize value;
|
|
@end
|
|
|
|
void testReferenceConsistency(IntWrapper *w) {
|
|
clang_analyzer_eval(w.value == w.value); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(&w.value == &w.value); // expected-warning{{TRUE}}
|
|
|
|
if (w.value != 42)
|
|
return;
|
|
|
|
clang_analyzer_eval(w.value == 42); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void testReferenceAssignment(IntWrapper *w) {
|
|
w.value = 42;
|
|
clang_analyzer_eval(w.value == 42); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
|
|
struct IntWrapperStruct {
|
|
int value;
|
|
};
|
|
|
|
@interface StructWrapper
|
|
@property IntWrapperStruct inner;
|
|
@end
|
|
|
|
@implementation StructWrapper
|
|
@synthesize inner;
|
|
@end
|
|
|
|
void testConsistencyStruct(StructWrapper *w) {
|
|
clang_analyzer_eval(w.inner.value == w.inner.value); // expected-warning{{TRUE}}
|
|
|
|
int origValue = w.inner.value;
|
|
if (origValue != 42)
|
|
return;
|
|
|
|
clang_analyzer_eval(w.inner.value == 42); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
|
|
class CustomCopy {
|
|
public:
|
|
CustomCopy() : value(0) {}
|
|
CustomCopy(const CustomCopy &other) : value(other.value) {
|
|
clang_analyzer_checkInlined(true); // expected-warning{{TRUE}}
|
|
}
|
|
int value;
|
|
};
|
|
|
|
@interface CustomCopyWrapper
|
|
@property CustomCopy inner;
|
|
@end
|
|
|
|
@implementation CustomCopyWrapper
|
|
//@synthesize inner;
|
|
@end
|
|
|
|
void testConsistencyCustomCopy(CustomCopyWrapper *w) {
|
|
clang_analyzer_eval(w.inner.value == w.inner.value); // expected-warning{{TRUE}}
|
|
|
|
int origValue = w.inner.value;
|
|
if (origValue != 42)
|
|
return;
|
|
|
|
clang_analyzer_eval(w.inner.value == 42); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
@protocol NoDirectPropertyDecl
|
|
@property IntWrapperStruct inner;
|
|
@end
|
|
@interface NoDirectPropertyDecl <NoDirectPropertyDecl>
|
|
@end
|
|
@implementation NoDirectPropertyDecl
|
|
@synthesize inner;
|
|
@end
|
|
|
|
// rdar://67416721
|
|
void testNoDirectPropertyDecl(NoDirectPropertyDecl *w) {
|
|
clang_analyzer_eval(w.inner.value == w.inner.value); // expected-warning{{TRUE}}
|
|
|
|
int origValue = w.inner.value;
|
|
if (origValue != 42)
|
|
return;
|
|
|
|
clang_analyzer_eval(w.inner.value == 42); // expected-warning{{TRUE}}
|
|
}
|