While working on D53847, I noticed that this test would fail once we started recognizing the types in the modified `export` statement [0]. The tests would fail because Clang would emit a "declaration does not declare anything" diagnostic instead of the expected namespace scope diagnostic. I believe that the test is currently incorrectly passing because Clang doesn't parse the type and therefore doesn't treat the statement as a declaration. My understanding is that the intention of this test case is that it wants to export a `struct` type, which I believe requires a `struct` keyword, even for types with template parameters. With this change, the only error with these two statements should be the namespace scope issue. [0]: https://reviews.llvm.org/D53847?id=462032#inline-1297053 Reviewed By: erichkeane Differential Revision: https://reviews.llvm.org/D134578
38 lines
1.4 KiB
C++
38 lines
1.4 KiB
C++
// The intention of this file to check we could only export declarations in namesapce scope.
|
|
//
|
|
// RUN: %clang_cc1 -std=c++20 %s -verify
|
|
|
|
export module X;
|
|
|
|
export template <typename T>
|
|
struct X {
|
|
struct iterator {
|
|
T node;
|
|
};
|
|
void foo() {}
|
|
template <typename U>
|
|
U bar();
|
|
};
|
|
|
|
export template <typename T> struct X<T>::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}}
|
|
export template <typename T> void X<T>::foo(); // expected-error {{cannot export 'foo' as it is not at namespace scope}}
|
|
export template <typename T> template <typename U> U X<T>::bar(); // expected-error {{cannot export 'bar' as it is not at namespace scope}}
|
|
|
|
export struct Y {
|
|
struct iterator {
|
|
int node;
|
|
};
|
|
void foo() {}
|
|
template <typename U>
|
|
U bar();
|
|
};
|
|
|
|
export struct Y::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}}
|
|
export void Y::foo(); // expected-error {{cannot export 'foo' as it is not at namespace scope}}
|
|
export template <typename U> U Y::bar(); // expected-error {{cannot export 'bar' as it is not at namespace scope}}
|
|
|
|
export {
|
|
template <typename T> struct X<T>::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}}
|
|
struct Y::iterator; // expected-error {{cannot export 'iterator' as it is not at namespace scope}}
|
|
}
|