246398ece7
Summary: The parsing of GNU C extended asm statements was a little brittle and had a few issues: - It was using Parse::ParseTypeQualifierListOpt to parse the `volatile` qualifier. That parser is really meant for TypeQualifiers; an asm statement doesn't really have a type qualifier. This is still maybe nice to have, but not necessary. We now can check for the `volatile` token by properly expanding the grammer, rather than abusing Parse::ParseTypeQualifierListOpt. - The parsing of `goto` was position dependent, so `asm goto volatile` wouldn't parse. The qualifiers should be position independent to one another. Now they are. - We would warn on duplicate `volatile`, but the parse error for duplicate `goto` was a generic parse error and wasn't clear. - We need to add support for the recent GNU C extension `asm inline`. Adding support to the parser with the above issues highlighted the need for this refactoring. Link: https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html Reviewers: aaron.ballman Reviewed By: aaron.ballman Subscribers: aheejin, jfb, nathanchance, cfe-commits, echristo, efriedma, rsmith, chandlerc, craig.topper, erichkeane, jyu2, void, srhines Tags: #clang Differential Revision: https://reviews.llvm.org/D75563
60 lines
2.1 KiB
C
60 lines
2.1 KiB
C
// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -verify %s
|
|
|
|
void qualifiers(void) {
|
|
asm("");
|
|
asm volatile("");
|
|
asm inline("");
|
|
asm goto("" ::::foo);
|
|
foo:;
|
|
}
|
|
|
|
void unknown_qualifiers(void) {
|
|
asm noodle(""); // expected-error {{expected 'volatile', 'inline', 'goto', or '('}}
|
|
asm goto noodle("" ::::foo); // expected-error {{expected 'volatile', 'inline', 'goto', or '('}}
|
|
asm volatile noodle inline(""); // expected-error {{expected 'volatile', 'inline', 'goto', or '('}}
|
|
foo:;
|
|
}
|
|
|
|
void underscores(void) {
|
|
__asm__("");
|
|
__asm__ __volatile__("");
|
|
__asm__ __inline__("");
|
|
// Note: goto is not supported with underscore prefix+suffix.
|
|
__asm__ goto("" ::::foo);
|
|
foo:;
|
|
}
|
|
|
|
void permutations(void) {
|
|
asm goto inline volatile("" ::::foo);
|
|
asm goto inline("");
|
|
asm goto volatile inline("" ::::foo);
|
|
asm goto volatile("");
|
|
asm inline goto volatile("" ::::foo);
|
|
asm inline goto("" ::::foo);
|
|
asm inline volatile goto("" ::::foo);
|
|
asm inline volatile("");
|
|
asm volatile goto("" ::::foo);
|
|
asm volatile inline goto("" ::::foo);
|
|
asm volatile inline("");
|
|
foo:;
|
|
}
|
|
|
|
void duplicates(void) {
|
|
asm volatile volatile(""); // expected-error {{duplicate asm qualifier 'volatile'}}
|
|
__asm__ __volatile__ __volatile__(""); // expected-error {{duplicate asm qualifier 'volatile'}}
|
|
asm inline inline(""); // expected-error {{duplicate asm qualifier 'inline'}}
|
|
__asm__ __inline__ __inline__(""); // expected-error {{duplicate asm qualifier 'inline'}}
|
|
asm goto goto("" ::::foo); // expected-error {{duplicate asm qualifier 'goto'}}
|
|
__asm__ goto goto("" ::::foo); // expected-error {{duplicate asm qualifier 'goto'}}
|
|
foo:;
|
|
}
|
|
|
|
// globals
|
|
asm ("");
|
|
// <rdar://problem/7574870>
|
|
asm volatile (""); // expected-error {{meaningless 'volatile' on asm outside function}}
|
|
asm inline (""); // expected-error {{meaningless 'inline' on asm outside function}}
|
|
asm goto (""::::noodle); // expected-error {{meaningless 'goto' on asm outside function}}
|
|
// expected-error@-1 {{expected ')'}}
|
|
// expected-note@-2 {{to match this '('}}
|