86866107b8
Before D126061, Clang would warn about this code
```
struct X {
[[deprecated]] struct Y {};
};
```
with the warning
attribute 'deprecated' is ignored, place it after "struct" to apply attribute to type declaration
D126061 inadvertently caused this warning to no longer be emitted. This patch
restores the previous behavior.
The reason for the bug is that after D126061, C++11 attributes applied to a
member declaration are no longer placed in `DS.getAttributes()` but are instead
tracked in a separate list (`DeclAttrs`). In the case of a free-standing
decl-specifier-seq, we would simply ignore the contents of this list. Instead,
we now pass the list on to `Sema::ParsedFreeStandingDeclSpec()` so that it can
issue the appropriate warning.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D128499
56 lines
4.9 KiB
C++
56 lines
4.9 KiB
C++
// RUN: %clang_cc1 %s -verify -fsyntax-only
|
|
|
|
namespace test1 {
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) class A; // expected-warning{{attribute 'visibility' is ignored, place it after "class" to apply attribute to type declaration}} \
|
|
// expected-warning{{attribute 'aligned' is ignored, place it after "class" to apply attribute to type declaration}}
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) struct B; // expected-warning{{attribute 'visibility' is ignored, place it after "struct" to apply attribute to type declaration}} \
|
|
// expected-warning{{attribute 'aligned' is ignored, place it after "struct" to apply attribute to type declaration}}
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) union C; // expected-warning{{attribute 'visibility' is ignored, place it after "union" to apply attribute to type declaration}} \
|
|
// expected-warning{{attribute 'aligned' is ignored, place it after "union" to apply attribute to type declaration}}
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) enum D {D}; // expected-warning{{attribute 'visibility' is ignored, place it after "enum" to apply attribute to type declaration}} \
|
|
// expected-warning{{attribute 'aligned' is ignored, place it after "enum" to apply attribute to type declaration}}
|
|
|
|
// Test that we get the same warnings for type declarations nested in a record.
|
|
struct X {
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) class A; // expected-warning{{attribute 'visibility' is ignored, place it after "class" to apply attribute to type declaration}} \
|
|
// expected-warning{{attribute 'aligned' is ignored, place it after "class" to apply attribute to type declaration}}
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) struct B; // expected-warning{{attribute 'visibility' is ignored, place it after "struct" to apply attribute to type declaration}} \
|
|
// expected-warning{{attribute 'aligned' is ignored, place it after "struct" to apply attribute to type declaration}}
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) union C; // expected-warning{{attribute 'visibility' is ignored, place it after "union" to apply attribute to type declaration}} \
|
|
// expected-warning{{attribute 'aligned' is ignored, place it after "union" to apply attribute to type declaration}}
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) enum D {D}; // expected-warning{{attribute 'visibility' is ignored, place it after "enum" to apply attribute to type declaration}} \
|
|
// expected-warning{{attribute 'aligned' is ignored, place it after "enum" to apply attribute to type declaration}}
|
|
|
|
// Also test [[]] attribute syntax. (On a non-nested declaration, these
|
|
// generate a hard "misplaced attributes" error, which we test for
|
|
// elsewhere.)
|
|
[[gnu::visibility("hidden")]] [[gnu::aligned]] class E; // expected-warning{{attribute 'visibility' is ignored, place it after "class" to apply attribute to type declaration}} \
|
|
// expected-warning{{attribute 'aligned' is ignored, place it after "class" to apply attribute to type declaration}}
|
|
[[gnu::visibility("hidden")]] [[gnu::aligned]] struct F; // expected-warning{{attribute 'visibility' is ignored, place it after "struct" to apply attribute to type declaration}} \
|
|
// expected-warning{{attribute 'aligned' is ignored, place it after "struct" to apply attribute to type declaration}}
|
|
[[gnu::visibility("hidden")]] [[gnu::aligned]] union G; // expected-warning{{attribute 'visibility' is ignored, place it after "union" to apply attribute to type declaration}} \
|
|
// expected-warning{{attribute 'aligned' is ignored, place it after "union" to apply attribute to type declaration}}
|
|
[[gnu::visibility("hidden")]] [[gnu::aligned]] enum H {H}; // expected-warning{{attribute 'visibility' is ignored, place it after "enum" to apply attribute to type declaration}} \
|
|
// expected-warning{{attribute 'aligned' is ignored, place it after "enum" to apply attribute to type declaration}}
|
|
};
|
|
}
|
|
|
|
namespace test2 {
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) class A {} a;
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) struct B {} b;
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) union C {} c;
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) enum D {D} d;
|
|
|
|
struct X {
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) class A {} a;
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) struct B {} b;
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) union C {} c;
|
|
__attribute__((visibility("hidden"))) __attribute__((aligned)) enum D {D} d;
|
|
|
|
[[gnu::visibility("hidden")]] [[gnu::aligned]] class E {} e;
|
|
[[gnu::visibility("hidden")]] [[gnu::aligned]] struct F {} f;
|
|
[[gnu::visibility("hidden")]] [[gnu::aligned]] union G {} g;
|
|
[[gnu::visibility("hidden")]] [[gnu::aligned]] enum H {H} h;
|
|
};
|
|
}
|