15f3cd6bfc
Without this patch, clang will not wrap in an ElaboratedType node types written
without a keyword and nested name qualifier, which goes against the intent that
we should produce an AST which retains enough details to recover how things are
written.
The lack of this sugar is incompatible with the intent of the type printer
default policy, which is to print types as written, but to fall back and print
them fully qualified when they are desugared.
An ElaboratedTypeLoc without keyword / NNS uses no storage by itself, but still
requires pointer alignment due to pre-existing bug in the TypeLoc buffer
handling.
---
Troubleshooting list to deal with any breakage seen with this patch:
1) The most likely effect one would see by this patch is a change in how
a type is printed. The type printer will, by design and default,
print types as written. There are customization options there, but
not that many, and they mainly apply to how to print a type that we
somehow failed to track how it was written. This patch fixes a
problem where we failed to distinguish between a type
that was written without any elaborated-type qualifiers,
such as a 'struct'/'class' tags and name spacifiers such as 'std::',
and one that has been stripped of any 'metadata' that identifies such,
the so called canonical types.
Example:
```
namespace foo {
struct A {};
A a;
};
```
If one were to print the type of `foo::a`, prior to this patch, this
would result in `foo::A`. This is how the type printer would have,
by default, printed the canonical type of A as well.
As soon as you add any name qualifiers to A, the type printer would
suddenly start accurately printing the type as written. This patch
will make it print it accurately even when written without
qualifiers, so we will just print `A` for the initial example, as
the user did not really write that `foo::` namespace qualifier.
2) This patch could expose a bug in some AST matcher. Matching types
is harder to get right when there is sugar involved. For example,
if you want to match a type against being a pointer to some type A,
then you have to account for getting a type that is sugar for a
pointer to A, or being a pointer to sugar to A, or both! Usually
you would get the second part wrong, and this would work for a
very simple test where you don't use any name qualifiers, but
you would discover is broken when you do. The usual fix is to
either use the matcher which strips sugar, which is annoying
to use as for example if you match an N level pointer, you have
to put N+1 such matchers in there, beginning to end and between
all those levels. But in a lot of cases, if the property you want
to match is present in the canonical type, it's easier and faster
to just match on that... This goes with what is said in 1), if
you want to match against the name of a type, and you want
the name string to be something stable, perhaps matching on
the name of the canonical type is the better choice.
3) This patch could expose a bug in how you get the source range of some
TypeLoc. For some reason, a lot of code is using getLocalSourceRange(),
which only looks at the given TypeLoc node. This patch introduces a new,
and more common TypeLoc node which contains no source locations on itself.
This is not an inovation here, and some other, more rare TypeLoc nodes could
also have this property, but if you use getLocalSourceRange on them, it's not
going to return any valid locations, because it doesn't have any. The right fix
here is to always use getSourceRange() or getBeginLoc/getEndLoc which will dive
into the inner TypeLoc to get the source range if it doesn't find it on the
top level one. You can use getLocalSourceRange if you are really into
micro-optimizations and you have some outside knowledge that the TypeLocs you are
dealing with will always include some source location.
4) Exposed a bug somewhere in the use of the normal clang type class API, where you
have some type, you want to see if that type is some particular kind, you try a
`dyn_cast` such as `dyn_cast<TypedefType>` and that fails because now you have an
ElaboratedType which has a TypeDefType inside of it, which is what you wanted to match.
Again, like 2), this would usually have been tested poorly with some simple tests with
no qualifications, and would have been broken had there been any other kind of type sugar,
be it an ElaboratedType or a TemplateSpecializationType or a SubstTemplateParmType.
The usual fix here is to use `getAs` instead of `dyn_cast`, which will look deeper
into the type. Or use `getAsAdjusted` when dealing with TypeLocs.
For some reason the API is inconsistent there and on TypeLocs getAs behaves like a dyn_cast.
5) It could be a bug in this patch perhaps.
Let me know if you need any help!
Signed-off-by: Matheus Izvekov <mizvekov@gmail.com>
Differential Revision: https://reviews.llvm.org/D112374
356 lines
11 KiB
C++
356 lines
11 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -verify -Wbind-to-temporary-copy %s
|
|
// RUN: %clang_cc1 -fsyntax-only -verify -Wbind-to-temporary-copy -std=c++98 %s
|
|
// RUN: %clang_cc1 -fsyntax-only -verify -Wbind-to-temporary-copy -std=c++11 %s
|
|
|
|
// Make sure we don't produce invalid IR.
|
|
// RUN: %clang_cc1 -emit-llvm-only %s
|
|
// RUN: %clang_cc1 -emit-llvm-only -std=c++98 %s
|
|
// RUN: %clang_cc1 -emit-llvm-only -std=c++11 %s
|
|
|
|
namespace test1 {
|
|
static void foo(); // expected-warning {{function 'test1::foo' has internal linkage but is not defined}}
|
|
template <class T> static void bar(); // expected-warning {{function 'test1::bar<int>' has internal linkage but is not defined}}
|
|
|
|
void test() {
|
|
foo(); // expected-note {{used here}}
|
|
bar<int>(); // expected-note {{used here}}
|
|
}
|
|
}
|
|
|
|
namespace test2 {
|
|
namespace {
|
|
void foo(); // expected-warning {{function 'test2::(anonymous namespace)::foo' has internal linkage but is not defined}}
|
|
extern int var; // expected-warning {{variable 'test2::(anonymous namespace)::var' has internal linkage but is not defined}}
|
|
template <class T> void bar(); // expected-warning {{function 'test2::(anonymous namespace)::bar<int>' has internal linkage but is not defined}}
|
|
}
|
|
void test() {
|
|
foo(); // expected-note {{used here}}
|
|
var = 0; // expected-note {{used here}}
|
|
bar<int>(); // expected-note {{used here}}
|
|
}
|
|
}
|
|
|
|
namespace test3 {
|
|
namespace {
|
|
void foo();
|
|
extern int var;
|
|
template <class T> void bar();
|
|
}
|
|
|
|
void test() {
|
|
foo();
|
|
var = 0;
|
|
bar<int>();
|
|
}
|
|
|
|
namespace {
|
|
void foo() {}
|
|
int var = 0;
|
|
template <class T> void bar() {}
|
|
}
|
|
}
|
|
|
|
namespace test4 {
|
|
namespace {
|
|
struct A {
|
|
A(); // expected-warning {{function 'test4::(anonymous namespace)::A::A' has internal linkage but is not defined}}
|
|
~A();// expected-warning {{function 'test4::(anonymous namespace)::A::~A' has internal linkage but is not defined}}
|
|
virtual void foo(); // expected-warning {{function 'test4::(anonymous namespace)::A::foo' has internal linkage but is not defined}}
|
|
virtual void bar() = 0;
|
|
virtual void baz(); // expected-warning {{function 'test4::(anonymous namespace)::A::baz' has internal linkage but is not defined}}
|
|
};
|
|
}
|
|
|
|
void test(A &a) {
|
|
a.foo(); // expected-note {{used here}}
|
|
a.bar();
|
|
a.baz(); // expected-note {{used here}}
|
|
}
|
|
|
|
struct Test : A {
|
|
Test() {} // expected-note 2 {{used here}}
|
|
};
|
|
}
|
|
|
|
// rdar://problem/9014651
|
|
namespace test5 {
|
|
namespace {
|
|
struct A {};
|
|
}
|
|
|
|
template <class N> struct B {
|
|
static int var; // expected-warning {{variable 'test5::B<test5::(anonymous namespace)::A>::var' has internal linkage but is not defined}}
|
|
static void foo(); // expected-warning {{function 'test5::B<test5::(anonymous namespace)::A>::foo' has internal linkage but is not defined}}
|
|
};
|
|
extern template int B<A>::var;
|
|
|
|
void test() {
|
|
B<A>::var = 0; // expected-note {{used here}}
|
|
B<A>::foo(); // expected-note {{used here}}
|
|
}
|
|
}
|
|
|
|
namespace test6 {
|
|
template <class T> struct A {
|
|
static const int zero = 0;
|
|
static const int one = 1;
|
|
static const int two = 2;
|
|
|
|
int value;
|
|
|
|
A() : value(zero) {
|
|
value = one;
|
|
}
|
|
};
|
|
|
|
namespace { struct Internal; }
|
|
|
|
void test() {
|
|
A<Internal> a;
|
|
a.value = A<Internal>::two;
|
|
}
|
|
}
|
|
|
|
// We support (as an extension) private, undefined copy constructors when
|
|
// a temporary is bound to a reference even in C++98. Similarly, we shouldn't
|
|
// warn about this copy constructor being used without a definition.
|
|
namespace PR9323 {
|
|
namespace {
|
|
struct Uncopyable {
|
|
Uncopyable() {}
|
|
private:
|
|
Uncopyable(const Uncopyable&); // expected-note {{declared private here}}
|
|
};
|
|
}
|
|
void f(const Uncopyable&) {}
|
|
void test() {
|
|
f(Uncopyable());
|
|
#if __cplusplus <= 199711L // C++03 or earlier modes
|
|
// expected-warning@-2 {{C++98 requires an accessible copy constructor}}
|
|
#else
|
|
// expected-warning@-4 {{copying parameter of type 'Uncopyable' when binding a reference to a temporary would invoke an inaccessible constructor in C++98}}
|
|
#endif
|
|
};
|
|
}
|
|
|
|
|
|
namespace std { class type_info; };
|
|
namespace cxx11_odr_rules {
|
|
// Note: the way this test is written isn't really ideal, but there really
|
|
// isn't any other way to check that the odr-used logic for constants
|
|
// is working without working implicit capture in lambda-expressions.
|
|
// (The more accurate used-but-not-defined warning is the only other visible
|
|
// effect of accurate odr-used computation.)
|
|
//
|
|
// Note that the warning in question can trigger in cases some people would
|
|
// consider false positives; hopefully that happens rarely in practice.
|
|
//
|
|
// FIXME: Suppressing this test while I figure out how to fix a bug in the
|
|
// odr-use marking code.
|
|
|
|
namespace {
|
|
struct A {
|
|
static const int unused = 10;
|
|
static const int used1 = 20; // xpected-warning {{internal linkage}}
|
|
static const int used2 = 20; // xpected-warning {{internal linkage}}
|
|
virtual ~A() {}
|
|
};
|
|
}
|
|
|
|
void a(int,int);
|
|
A& p(const int&) { static A a; return a; }
|
|
|
|
// Check handling of default arguments
|
|
void b(int = A::unused);
|
|
|
|
void tests() {
|
|
// Basic test
|
|
a(A::unused, A::unused);
|
|
|
|
// Check that nesting an unevaluated or constant-evaluated context does
|
|
// the right thing.
|
|
a(A::unused, sizeof(int[10]));
|
|
|
|
// Check that the checks work with unevaluated contexts
|
|
(void)sizeof(p(A::used1));
|
|
(void)typeid(p(A::used1)); // expected-warning {{expression with side effects will be evaluated despite being used as an operand to 'typeid'}} xpected-note {{used here}}
|
|
|
|
// Misc other testing
|
|
a(A::unused, 1 ? A::used2 : A::used2); // xpected-note {{used here}}
|
|
b();
|
|
}
|
|
}
|
|
|
|
|
|
namespace OverloadUse {
|
|
namespace {
|
|
void f();
|
|
void f(int); // expected-warning {{function 'OverloadUse::(anonymous namespace)::f' has internal linkage but is not defined}}
|
|
void f(int, int); // expected-warning {{function 'OverloadUse::(anonymous namespace)::f' has internal linkage but is not defined}}
|
|
#if __cplusplus < 201103L
|
|
// expected-note@-3 {{here}}
|
|
// expected-note@-3 {{here}}
|
|
#endif
|
|
}
|
|
template<void x()> void t() { x(); }
|
|
template<void x(int)> void t(int*) { x(10); }
|
|
template<void x(int, int)> void t(int*, int*) {}
|
|
void g(int n) {
|
|
t<f>(&n); // expected-note {{used here}}
|
|
t<f>(&n, &n); // expected-note {{used here}}
|
|
#if __cplusplus < 201103L
|
|
// expected-warning@-3 {{non-type template argument referring to function 'f' with internal linkage}}
|
|
// expected-warning@-3 {{non-type template argument referring to function 'f' with internal linkage}}
|
|
#endif
|
|
}
|
|
}
|
|
|
|
namespace test7 {
|
|
typedef struct { // expected-warning {{add a tag name}}
|
|
void bar(); // expected-note {{this member}}
|
|
void foo() {
|
|
bar();
|
|
}
|
|
} A; // expected-note {{this typedef}}
|
|
}
|
|
|
|
namespace test8 {
|
|
typedef struct {
|
|
void bar(); // expected-warning {{function 'test8::(anonymous struct)::bar' has internal linkage but is not defined}}
|
|
void foo() {
|
|
bar(); // expected-note {{used here}}
|
|
}
|
|
} *A;
|
|
}
|
|
|
|
namespace test9 {
|
|
namespace {
|
|
struct X {
|
|
virtual void notused() = 0;
|
|
virtual void used() = 0; // expected-warning {{function 'test9::(anonymous namespace)::X::used' has internal linkage but is not defined}}
|
|
};
|
|
}
|
|
void test(X &x) {
|
|
x.notused();
|
|
x.X::used(); // expected-note {{used here}}
|
|
}
|
|
}
|
|
|
|
namespace test10 {
|
|
namespace {
|
|
struct X {
|
|
virtual void notused() = 0;
|
|
virtual void used() = 0; // expected-warning {{function 'test10::(anonymous namespace)::X::used' has internal linkage but is not defined}}
|
|
|
|
void test() {
|
|
notused();
|
|
(void)&X::notused;
|
|
(this->*&X::notused)();
|
|
X::used(); // expected-note {{used here}}
|
|
}
|
|
};
|
|
struct Y : X {
|
|
using X::notused;
|
|
};
|
|
}
|
|
}
|
|
|
|
namespace test11 {
|
|
namespace {
|
|
struct A {
|
|
virtual bool operator()() const = 0;
|
|
virtual void operator!() const = 0;
|
|
virtual bool operator+(const A&) const = 0;
|
|
virtual int operator[](int) const = 0;
|
|
virtual const A* operator->() const = 0;
|
|
int member;
|
|
};
|
|
|
|
struct B {
|
|
bool operator()() const; // expected-warning {{function 'test11::(anonymous namespace)::B::operator()' has internal linkage but is not defined}}
|
|
void operator!() const; // expected-warning {{function 'test11::(anonymous namespace)::B::operator!' has internal linkage but is not defined}}
|
|
bool operator+(const B&) const; // expected-warning {{function 'test11::(anonymous namespace)::B::operator+' has internal linkage but is not defined}}
|
|
int operator[](int) const; // expected-warning {{function 'test11::(anonymous namespace)::B::operator[]' has internal linkage but is not defined}}
|
|
const B* operator->() const; // expected-warning {{function 'test11::(anonymous namespace)::B::operator->' has internal linkage but is not defined}}
|
|
int member;
|
|
};
|
|
}
|
|
|
|
void test1(A &a1, A &a2) {
|
|
a1();
|
|
!a1;
|
|
a1 + a2;
|
|
a1[0];
|
|
(void)a1->member;
|
|
}
|
|
|
|
void test2(B &b1, B &b2) {
|
|
b1(); // expected-note {{used here}}
|
|
!b1; // expected-note {{used here}}
|
|
b1 + b2; // expected-note {{used here}}
|
|
b1[0]; // expected-note {{used here}}
|
|
(void)b1->member; // expected-note {{used here}}
|
|
}
|
|
}
|
|
|
|
namespace test12 {
|
|
class T1 {}; class T2 {}; class T3 {}; class T4 {}; class T5 {}; class T6 {};
|
|
class T7 {};
|
|
|
|
namespace {
|
|
struct Cls {
|
|
virtual void f(int) = 0;
|
|
virtual void f(int, double) = 0;
|
|
void g(int); // expected-warning {{function 'test12::(anonymous namespace)::Cls::g' has internal linkage but is not defined}}
|
|
void g(int, double);
|
|
virtual operator T1() = 0;
|
|
virtual operator T2() = 0;
|
|
virtual operator T3&() = 0;
|
|
operator T4(); // expected-warning {{function 'test12::(anonymous namespace)::Cls::operator T4' has internal linkage but is not defined}}
|
|
operator T5(); // expected-warning {{function 'test12::(anonymous namespace)::Cls::operator T5' has internal linkage but is not defined}}
|
|
operator T6&(); // expected-warning {{function 'test12::(anonymous namespace)::Cls::operator test12::T6 &' has internal linkage but is not defined}}
|
|
};
|
|
|
|
struct Cls2 {
|
|
Cls2(T7); // expected-warning {{function 'test12::(anonymous namespace)::Cls2::Cls2' has internal linkage but is not defined}}
|
|
};
|
|
}
|
|
|
|
void test(Cls &c) {
|
|
c.f(7);
|
|
c.g(7); // expected-note {{used here}}
|
|
(void)static_cast<T1>(c);
|
|
T2 t2 = c;
|
|
T3 &t3 = c;
|
|
(void)static_cast<T4>(c); // expected-note {{used here}}
|
|
T5 t5 = c; // expected-note {{used here}}
|
|
T6 &t6 = c; // expected-note {{used here}}
|
|
|
|
Cls2 obj1((T7())); // expected-note {{used here}}
|
|
}
|
|
}
|
|
|
|
namespace test13 {
|
|
namespace {
|
|
struct X {
|
|
virtual void f() { }
|
|
};
|
|
|
|
struct Y : public X {
|
|
virtual void f() = 0;
|
|
|
|
virtual void g() {
|
|
X::f();
|
|
}
|
|
};
|
|
}
|
|
}
|
|
|
|
namespace test14 {
|
|
extern "C" const int foo;
|
|
|
|
int f() {
|
|
return foo;
|
|
}
|
|
}
|