This switches everything to use the memory attribute proposed in https://discourse.llvm.org/t/rfc-unify-memory-effect-attributes/65579. The old argmemonly, inaccessiblememonly and inaccessiblemem_or_argmemonly attributes are dropped. The readnone, readonly and writeonly attributes are restricted to parameters only. The old attributes are auto-upgraded both in bitcode and IR. The bitcode upgrade is a policy requirement that has to be retained indefinitely. The IR upgrade is mainly there so it's not necessary to update all tests using memory attributes in this patch, which is already large enough. We could drop that part after migrating tests, or retain it longer term, to make it easier to import IR from older LLVM versions. High-level Function/CallBase APIs like doesNotAccessMemory() or setDoesNotAccessMemory() are mapped transparently to the memory attribute. Code that directly manipulates attributes (e.g. via AttributeList) on the other hand needs to switch to working with the memory attribute instead. Differential Revision: https://reviews.llvm.org/D135780
137 lines
4.5 KiB
LLVM
137 lines
4.5 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --check-attributes --check-globals
|
|
; RUN: opt -passes=attributor -S %s | FileCheck %s
|
|
|
|
@var1 = internal global [1 x i32] undef
|
|
@var2 = internal global i32 0
|
|
|
|
;.
|
|
; CHECK: @[[VAR1:[a-zA-Z0-9_$"\\.-]+]] = internal global [1 x i32] undef
|
|
; CHECK: @[[VAR2:[a-zA-Z0-9_$"\\.-]+]] = internal global i32 0
|
|
;.
|
|
define i32 addrspace(1)* @foo(i32 addrspace(4)* %arg) {
|
|
; CHECK: Function Attrs: nofree norecurse nosync nounwind willreturn memory(none)
|
|
; CHECK-LABEL: define {{[^@]+}}@foo
|
|
; CHECK-SAME: (i32 addrspace(4)* nofree readnone [[ARG:%.*]]) #[[ATTR0:[0-9]+]] {
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: [[TMP0:%.*]] = addrspacecast i32 addrspace(4)* [[ARG]] to i32 addrspace(1)*
|
|
; CHECK-NEXT: ret i32 addrspace(1)* [[TMP0]]
|
|
;
|
|
entry:
|
|
%0 = addrspacecast i32 addrspace(4)* %arg to i32 addrspace(1)*
|
|
ret i32 addrspace(1)* %0
|
|
}
|
|
|
|
define i32* @func1() {
|
|
; CHECK: Function Attrs: nofree norecurse nosync nounwind willreturn memory(none)
|
|
; CHECK-LABEL: define {{[^@]+}}@func1
|
|
; CHECK-SAME: () #[[ATTR0]] {
|
|
; CHECK-NEXT: ret i32* getelementptr inbounds ([1 x i32], [1 x i32]* @var1, i32 0, i32 0)
|
|
;
|
|
%ptr = call i32* @func1a([1 x i32]* @var1)
|
|
ret i32* %ptr
|
|
}
|
|
|
|
define internal i32* @func1a([1 x i32]* %arg) {
|
|
%ptr = getelementptr inbounds [1 x i32], [1 x i32]* %arg, i64 0, i64 0
|
|
ret i32* %ptr
|
|
}
|
|
|
|
define internal void @func2a(i32* %0) {
|
|
; CHECK: Function Attrs: nofree norecurse nosync nounwind willreturn memory(write)
|
|
; CHECK-LABEL: define {{[^@]+}}@func2a
|
|
; CHECK-SAME: (i32* nocapture nofree nonnull writeonly align 4 dereferenceable(4) [[TMP0:%.*]]) #[[ATTR1:[0-9]+]] {
|
|
; CHECK-NEXT: store i32 0, i32* @var2, align 4
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
store i32 0, i32* %0
|
|
ret void
|
|
}
|
|
|
|
define i32 @func2() {
|
|
; CHECK: Function Attrs: norecurse
|
|
; CHECK-LABEL: define {{[^@]+}}@func2
|
|
; CHECK-SAME: () #[[ATTR2:[0-9]+]] {
|
|
; CHECK-NEXT: [[TMP1:%.*]] = tail call i32 (i32*, ...) bitcast (void (i32*)* @func2a to i32 (i32*, ...)*)(i32* nonnull align 4 dereferenceable(4) @var2)
|
|
; CHECK-NEXT: [[TMP2:%.*]] = load i32, i32* @var2, align 4
|
|
; CHECK-NEXT: ret i32 [[TMP2]]
|
|
;
|
|
%1 = tail call i32 (i32*, ...) bitcast (void (i32*)* @func2a to i32 (i32*, ...)*)(i32* @var2)
|
|
%2 = load i32, i32* @var2
|
|
ret i32 %2
|
|
}
|
|
|
|
define i32 @func3(i1 %false) {
|
|
; CHECK: Function Attrs: norecurse
|
|
; CHECK-LABEL: define {{[^@]+}}@func3
|
|
; CHECK-SAME: (i1 [[FALSE:%.*]]) #[[ATTR2]] {
|
|
; CHECK-NEXT: [[TMP1:%.*]] = tail call i32 (i32*, ...) bitcast (void (i32*)* @func2a to i32 (i32*, ...)*)(i32* nonnull align 4 dereferenceable(4) @var2)
|
|
; CHECK-NEXT: br i1 [[FALSE]], label [[USE_BB:%.*]], label [[RET_BB:%.*]]
|
|
; CHECK: use_bb:
|
|
; CHECK-NEXT: ret i32 [[TMP1]]
|
|
; CHECK: ret_bb:
|
|
; CHECK-NEXT: [[TMP2:%.*]] = load i32, i32* @var2, align 4
|
|
; CHECK-NEXT: ret i32 [[TMP2]]
|
|
;
|
|
%1 = tail call i32 (i32*, ...) bitcast (void (i32*)* @func2a to i32 (i32*, ...)*)(i32* @var2)
|
|
br i1 %false, label %use_bb, label %ret_bb
|
|
use_bb:
|
|
ret i32 %1
|
|
ret_bb:
|
|
%2 = load i32, i32* @var2
|
|
ret i32 %2
|
|
}
|
|
|
|
define void @func4() {
|
|
; CHECK-LABEL: define {{[^@]+}}@func4() {
|
|
; CHECK-NEXT: call void @func5()
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
call void @func5(i32 0)
|
|
ret void
|
|
}
|
|
|
|
define internal void @func5(i32 %0) {
|
|
; CHECK-LABEL: define {{[^@]+}}@func5() {
|
|
; CHECK-NEXT: br label [[BLOCK:%.*]]
|
|
; CHECK: block:
|
|
; CHECK-NEXT: call void @func6(i8* blockaddress(@func5, [[BLOCK]]))
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
%tmp = alloca i8*
|
|
br label %block
|
|
|
|
block:
|
|
store i8* blockaddress(@func5, %block), i8** %tmp
|
|
%addr = load i8*, i8** %tmp
|
|
call void @func6(i8* %addr)
|
|
ret void
|
|
}
|
|
|
|
define i16 @foo3() {
|
|
; CHECK: Function Attrs: norecurse
|
|
; CHECK-LABEL: define {{[^@]+}}@foo3
|
|
; CHECK-SAME: () #[[ATTR2]] {
|
|
; CHECK-NEXT: [[CALL:%.*]] = call i16 bitcast (i16 (i16*, i16)* @bar3 to i16 ()*)()
|
|
; CHECK-NEXT: ret i16 [[CALL]]
|
|
;
|
|
%call = call i16 bitcast (i16 (i16*, i16) * @bar3 to i16 () *)()
|
|
ret i16 %call
|
|
}
|
|
define internal i16 @bar3(i16* %p1, i16 %p2) {
|
|
; CHECK: Function Attrs: nofree norecurse nosync nounwind willreturn memory(none)
|
|
; CHECK-LABEL: define {{[^@]+}}@bar3
|
|
; CHECK-SAME: (i16* nocapture nofree readnone [[P1:%.*]], i16 returned [[P2:%.*]]) #[[ATTR0]] {
|
|
; CHECK-NEXT: ret i16 [[P2]]
|
|
;
|
|
ret i16 %p2
|
|
}
|
|
|
|
; CHECK-LABEL: declare {{[^@]+}}@func6
|
|
; CHECK-SAME: (i8*)
|
|
declare void @func6(i8*)
|
|
;.
|
|
; CHECK: attributes #[[ATTR0]] = { nofree norecurse nosync nounwind willreturn memory(none) }
|
|
; CHECK: attributes #[[ATTR1]] = { nofree norecurse nosync nounwind willreturn memory(write) }
|
|
; CHECK: attributes #[[ATTR2]] = { norecurse }
|
|
;.
|