fd0ca2c4e9
This caused lld on mac to assert when building instrumented clang (or instrumented code in general). See comment on the code review for reproducer. > In many cases, we can use an alias to avoid a symbolic relocations, > instead of using the public, interposable symbol. When the instrumented > function is in a COMDAT, we can use a hidden alias, and still avoid > references to discarded sections. > > New compiler-rt tests are Linux only for now. > > Previous versions of this patch allowed the compiler to name the > generated alias, but that would only be valid when the functions were > local. Since the alias may be used across TUs we use a more > deterministic naming convention, and add a `.local` suffix to the alias > name just as we do for relative vtables aliases. > > Reviewed By: phosek > > Differential Revision: https://reviews.llvm.org/D137982 This reverts commit c42e50fede53bbcce79095e7c8115f26826c81ae.
30 lines
1.6 KiB
LLVM
30 lines
1.6 KiB
LLVM
;; Test comdat functions.
|
|
; RUN: opt < %s -mtriple=x86_64-linux -passes=pgo-instr-gen,instrprof -S | FileCheck %s --check-prefixes=ELF
|
|
; RUN: opt < %s -mtriple=x86_64-windows -passes=pgo-instr-gen,instrprof -S | FileCheck %s --check-prefixes=COFF
|
|
|
|
$linkonceodr = comdat any
|
|
$weakodr = comdat any
|
|
|
|
;; profc/profd have hash suffixes. This definition doesn't have value profiling,
|
|
;; so definitions with the same name in other modules must have the same CFG and
|
|
;; cannot have value profiling, either. profd can be made private for ELF.
|
|
; ELF: @__profc_linkonceodr.[[#]] = linkonce_odr hidden global {{.*}} comdat, align 8
|
|
; ELF: @__profd_linkonceodr.[[#]] = private global {{.*}} comdat($__profc_linkonceodr.[[#]]), align 8
|
|
; COFF: @__profc_linkonceodr.[[#]] = linkonce_odr hidden global {{.*}} comdat, align 8
|
|
; COFF: @__profd_linkonceodr.[[#]] = linkonce_odr hidden global {{.*}} comdat, align 8
|
|
define linkonce_odr void @linkonceodr() comdat {
|
|
ret void
|
|
}
|
|
|
|
;; weakodr in a comdat is not renamed. There is no guarantee that definitions in
|
|
;; other modules don't have value profiling. profd should be conservatively
|
|
;; non-private to prevent a caller from referencing a non-prevailing profd,
|
|
;; causing a linker error.
|
|
; ELF: @__profc_weakodr = weak_odr hidden global {{.*}} comdat, align 8
|
|
; ELF: @__profd_weakodr = weak_odr hidden global {{.*}} comdat($__profc_weakodr), align 8
|
|
; COFF: @__profc_weakodr = weak_odr hidden global {{.*}} comdat, align 8
|
|
; COFF: @__profd_weakodr = weak_odr hidden global {{.*}} comdat, align 8
|
|
define weak_odr void @weakodr() comdat {
|
|
ret void
|
|
}
|