8eea582dcb
Close https://github.com/llvm/llvm-project/issues/79240 Cite the comment from @mizvekov in //github.com/llvm/llvm-project/issues/79240: > There are two kinds of bugs / issues relevant here: > > Clang bugs that this change hides > Here we can add a Frontend flag that disables the GMF ODR check, just > so > we can keep tracking, testing and fixing these issues. > The Driver would just always pass that flag. > We could add that flag in this current issue. > Bugs in user code: > I don't think it's worth adding a corresponding Driver flag for > controlling the above Frontend flag, since we intend it's behavior to > become default as we fix the problems, and users interested in testing > the more strict behavior can just use the Frontend flag directly. This patch follows the suggestion: - Introduce the CC1 flag `-fskip-odr-check-in-gmf` which is by default off, so that the every existing test will still be tested with checking ODR violations. - Passing `-fskip-odr-check-in-gmf` in the driver to keep the behavior we intended. - Edit the document to tell the users who are still interested in more strict checks can use `-Xclang -fno-skip-odr-check-in-gmf` to get the existing behavior.
106 lines
2.6 KiB
C++
106 lines
2.6 KiB
C++
// RUN: rm -rf %t
|
|
// RUN: mkdir %t
|
|
// RUN: split-file %s %t
|
|
//
|
|
// RUN: %clang_cc1 -std=c++20 %t/A.cppm -emit-module-interface -o %t/A.pcm
|
|
// RUN: %clang_cc1 -std=c++20 -fprebuilt-module-path=%t -I%t -DDIFFERENT %t/B.cppm -verify
|
|
// RUN: %clang_cc1 -std=c++20 -fprebuilt-module-path=%t -I%t %t/B.cppm -verify
|
|
//
|
|
// Testing the behavior of `-fskip-odr-check-in-gmf`
|
|
// RUN: %clang_cc1 -std=c++20 -fskip-odr-check-in-gmf %t/A.cppm -emit-module-interface -o %t/A.pcm
|
|
// RUN: %clang_cc1 -std=c++20 -fskip-odr-check-in-gmf -fprebuilt-module-path=%t -I%t \
|
|
// RUN: -DDIFFERENT -DSKIP_ODR_CHECK_IN_GMF %t/B.cppm -verify
|
|
|
|
|
|
//--- foo.h
|
|
#ifndef FOO_H
|
|
#define FOO_H
|
|
|
|
template <class T>
|
|
concept Range = requires(T &t) { t.begin(); };
|
|
|
|
template<class _Tp>
|
|
concept __integer_like = true;
|
|
|
|
template <class _Tp>
|
|
concept __member_size = requires(_Tp &&t) { t.size(); };
|
|
|
|
template <class First, class Second>
|
|
concept C = requires(First x, Second y) { x + y; };
|
|
|
|
struct A {
|
|
public:
|
|
template <Range T>
|
|
using range_type = T;
|
|
};
|
|
|
|
struct __fn {
|
|
template <__member_size _Tp>
|
|
constexpr __integer_like auto operator()(_Tp&& __t) const {
|
|
return __t.size();
|
|
}
|
|
|
|
template <__integer_like _Tp, C<_Tp> Sentinel>
|
|
constexpr _Tp operator()(_Tp &&__t, Sentinel &&last) const {
|
|
return __t;
|
|
}
|
|
|
|
template <template <class> class H, class S, C<H<S>> Sentinel>
|
|
constexpr H<S> operator()(H<S> &&__s, Sentinel &&last) const {
|
|
return __s;
|
|
}
|
|
|
|
// Tests that we could find different concept definition indeed.
|
|
#ifndef DIFFERENT
|
|
template <__integer_like _Tp, __integer_like _Up, C<_Tp> Sentinel>
|
|
constexpr _Tp operator()(_Tp &&__t, _Up _u, Sentinel &&last) const {
|
|
return __t;
|
|
}
|
|
#else
|
|
template <__integer_like _Tp, __integer_like _Up, C<_Up> Sentinel>
|
|
constexpr _Tp operator()(_Tp &&__t, _Up _u, Sentinel &&last) const {
|
|
return __t;
|
|
}
|
|
#endif
|
|
};
|
|
#endif
|
|
|
|
//--- A.cppm
|
|
module;
|
|
#include "foo.h"
|
|
export module A;
|
|
|
|
//--- B.cppm
|
|
module;
|
|
#include "foo.h"
|
|
export module B;
|
|
import A;
|
|
|
|
#ifdef SKIP_ODR_CHECK_IN_GMF
|
|
// expected-error@B.cppm:* {{call to object of type '__fn' is ambiguous}}
|
|
// expected-note@* 1+{{candidate function}}
|
|
#elif defined(DIFFERENT)
|
|
// expected-error@foo.h:41 {{'__fn::operator()' from module 'A.<global>' is not present in definition of '__fn' provided earlier}}
|
|
// expected-note@* 1+{{declaration of 'operator()' does not match}}
|
|
#else
|
|
// expected-no-diagnostics
|
|
#endif
|
|
|
|
template <class T>
|
|
struct U {
|
|
auto operator+(U) { return 0; }
|
|
};
|
|
|
|
void foo() {
|
|
A a;
|
|
struct S {
|
|
int size() { return 0; }
|
|
auto operator+(S s) { return 0; }
|
|
};
|
|
__fn{}(S());
|
|
__fn{}(S(), S());
|
|
__fn{}(S(), S(), S());
|
|
|
|
__fn{}(U<int>(), U<int>());
|
|
}
|