8eea582dcb
Close https://github.com/llvm/llvm-project/issues/79240 Cite the comment from @mizvekov in //github.com/llvm/llvm-project/issues/79240: > There are two kinds of bugs / issues relevant here: > > Clang bugs that this change hides > Here we can add a Frontend flag that disables the GMF ODR check, just > so > we can keep tracking, testing and fixing these issues. > The Driver would just always pass that flag. > We could add that flag in this current issue. > Bugs in user code: > I don't think it's worth adding a corresponding Driver flag for > controlling the above Frontend flag, since we intend it's behavior to > become default as we fix the problems, and users interested in testing > the more strict behavior can just use the Frontend flag directly. This patch follows the suggestion: - Introduce the CC1 flag `-fskip-odr-check-in-gmf` which is by default off, so that the every existing test will still be tested with checking ODR violations. - Passing `-fskip-odr-check-in-gmf` in the driver to keep the behavior we intended. - Edit the document to tell the users who are still interested in more strict checks can use `-Xclang -fno-skip-odr-check-in-gmf` to get the existing behavior.
68 lines
1.8 KiB
C++
68 lines
1.8 KiB
C++
// RUN: rm -rf %t
|
|
// RUN: mkdir -p %t
|
|
// RUN: split-file %s %t
|
|
//
|
|
// RUN: %clang_cc1 -std=c++20 -emit-module-interface %t/a.cppm -o %t/a.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/b.cppm -fprebuilt-module-path=%t -emit-module-interface -o %t/b.pcm -verify
|
|
//
|
|
// Testing the behavior of `-fskip-odr-check-in-gmf`
|
|
// RUN: %clang_cc1 -std=c++20 -fskip-odr-check-in-gmf -emit-module-interface %t/a.cppm -o \
|
|
// RUN: %t/a.pcm
|
|
// RUN: %clang_cc1 -std=c++20 -fskip-odr-check-in-gmf %t/b.cppm -fprebuilt-module-path=%t \
|
|
// RUN: -emit-module-interface -DSKIP_ODR_CHECK_IN_GMF -o %t/b.pcm -verify
|
|
|
|
//--- foo.h
|
|
|
|
namespace std
|
|
{
|
|
template<class _Dom1>
|
|
void operator &&(_Dom1 __v, _Dom1 __w)
|
|
{
|
|
return;
|
|
}
|
|
}
|
|
|
|
//--- bar.h
|
|
namespace std
|
|
{
|
|
template<typename... _Types>
|
|
struct _Traits
|
|
{
|
|
static constexpr bool _S_copy_ctor =
|
|
(__is_trivial(_Types) && ...);
|
|
};
|
|
|
|
template<typename... _Types>
|
|
struct variant
|
|
{
|
|
void
|
|
swap(variant& __rhs)
|
|
noexcept((__is_trivial(_Types) && ...))
|
|
{
|
|
}
|
|
};
|
|
}
|
|
|
|
//--- a.cppm
|
|
module;
|
|
// The operator&& defined in 'foo.h' will pollute the
|
|
// expression '__is_trivial(_Types) && ...' in bar.h
|
|
#include "foo.h"
|
|
#include "bar.h"
|
|
export module a;
|
|
|
|
//--- b.cppm
|
|
module;
|
|
#include "bar.h"
|
|
export module b;
|
|
import a;
|
|
|
|
#ifdef SKIP_ODR_CHECK_IN_GMF
|
|
// expected-no-diagnostics
|
|
#else
|
|
// expected-error@* {{has different definitions in different modules; first difference is defined here found data member '_S_copy_ctor' with an initializer}}
|
|
// expected-note@* {{but in 'a.<global>' found data member '_S_copy_ctor' with a different initializer}}
|
|
// expected-error@* {{from module 'a.<global>' is not present in definition of 'variant<_Types...>' provided earlier}}
|
|
// expected-note@* {{declaration of 'swap' does not match}}
|
|
#endif
|