09dfc5713d
The greedy rewriter is used in many different flows and it has a lot of
convenience (work list management, debugging actions, tracing, etc). But
it combines two kinds of greedy behavior 1) how ops are matched, 2)
folding wherever it can.
These are independent forms of greedy and leads to inefficiency. E.g.,
cases where one need to create different phases in lowering and is
required to applying patterns in specific order split across different
passes. Using the driver one ends up needlessly retrying folding/having
multiple rounds of folding attempts, where one final run would have
sufficed.
Of course folks can locally avoid this behavior by just building their
own, but this is also a common requested feature that folks keep on
working around locally in suboptimal ways.
For downstream users, there should be no behavioral change. Updating
from the deprecated should just be a find and replace (e.g., `find ./
-type f -exec sed -i
's|applyPatternsAndFoldGreedily|applyPatternsGreedily|g' {} \;` variety)
as the API arguments hasn't changed between the two.
63 lines
2.0 KiB
C++
63 lines
2.0 KiB
C++
//===- FormExpressions.cpp - Form C-style expressions --------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file implements a pass that forms EmitC operations modeling C operators
|
|
// into C-style expressions using the emitc.expression op.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/Dialect/EmitC/IR/EmitC.h"
|
|
#include "mlir/Dialect/EmitC/Transforms/Passes.h"
|
|
#include "mlir/Dialect/EmitC/Transforms/Transforms.h"
|
|
#include "mlir/Transforms/GreedyPatternRewriteDriver.h"
|
|
|
|
namespace mlir {
|
|
namespace emitc {
|
|
#define GEN_PASS_DEF_FORMEXPRESSIONS
|
|
#include "mlir/Dialect/EmitC/Transforms/Passes.h.inc"
|
|
} // namespace emitc
|
|
} // namespace mlir
|
|
|
|
using namespace mlir;
|
|
using namespace emitc;
|
|
|
|
namespace {
|
|
struct FormExpressionsPass
|
|
: public emitc::impl::FormExpressionsBase<FormExpressionsPass> {
|
|
void runOnOperation() override {
|
|
Operation *rootOp = getOperation();
|
|
MLIRContext *context = rootOp->getContext();
|
|
|
|
// Wrap each C operator op with an expression op.
|
|
OpBuilder builder(context);
|
|
auto matchFun = [&](Operation *op) {
|
|
if (op->hasTrait<OpTrait::emitc::CExpression>() &&
|
|
!op->getParentOfType<emitc::ExpressionOp>() &&
|
|
op->getNumResults() == 1)
|
|
createExpression(op, builder);
|
|
};
|
|
rootOp->walk(matchFun);
|
|
|
|
// Fold expressions where possible.
|
|
RewritePatternSet patterns(context);
|
|
populateExpressionPatterns(patterns);
|
|
|
|
if (failed(applyPatternsGreedily(rootOp, std::move(patterns))))
|
|
return signalPassFailure();
|
|
}
|
|
|
|
void getDependentDialects(DialectRegistry ®istry) const override {
|
|
registry.insert<emitc::EmitCDialect>();
|
|
}
|
|
};
|
|
} // namespace
|
|
|
|
std::unique_ptr<Pass> mlir::emitc::createFormExpressionsPass() {
|
|
return std::make_unique<FormExpressionsPass>();
|
|
}
|