
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
117 lines
2.5 KiB
C
117 lines
2.5 KiB
C
// RUN: %clang_cc1 -std=c89 -w -fmerge-all-constants -emit-llvm < %s | FileCheck %s
|
|
|
|
// CHECK: @test1.x = internal constant [12 x i32] [i32 1
|
|
// CHECK: @__const.test2.x = private unnamed_addr constant [13 x i32] [i32 1,
|
|
// CHECK: @test5w = {{(dso_local )?}}global { i32, [4 x i8] } { i32 2, [4 x i8] undef }
|
|
// CHECK: @test5y = {{(dso_local )?}}global { double } { double 7.300000e+0{{[0]*}}1 }
|
|
|
|
// CHECK: @__const.test6.x = private unnamed_addr constant %struct.SelectDest { i8 1, i8 2, i32 3, i32 0 }
|
|
|
|
// CHECK: @test7 = {{(dso_local )?}}global [2 x %struct.test7s] [%struct.test7s { i32 1, i32 2 }, %struct.test7s { i32 4, i32 0 }]
|
|
|
|
void test1(void) {
|
|
// This should codegen as a "@test1.x" global.
|
|
const int x[] = { 1, 2, 3, 4, 6, 8, 9, 10, 123, 231, 123,23 };
|
|
foo(x);
|
|
|
|
// CHECK: @test1()
|
|
// CHECK: {{call.*@foo.*@test1.x}}
|
|
}
|
|
|
|
|
|
void test2(void) {
|
|
// This should codegen as a "@test2.x" global + memcpy.
|
|
int x[] = { 1, 2, 3, 4, 6, 8, 9, 10, 123, 231, 123,23, 24 };
|
|
foo(x);
|
|
|
|
// CHECK: @test2()
|
|
// CHECK: %x = alloca [13 x i32]
|
|
// CHECK: call void @llvm.memcpy
|
|
// CHECK: call{{.*}}@foo{{.*}}ptr noundef %
|
|
}
|
|
|
|
|
|
void test3(void) {
|
|
// This should codegen as a memset.
|
|
int x[100] = { 0 };
|
|
foo(x);
|
|
|
|
// CHECK: @test3()
|
|
// CHECK: %x = alloca [100 x i32]
|
|
// CHECK: call void @llvm.memset
|
|
}
|
|
|
|
void test4(void) {
|
|
char a[10] = "asdf";
|
|
char b[10] = { "asdf" };
|
|
// CHECK: @test4()
|
|
// CHECK: %a = alloca [10 x i8]
|
|
// CHECK: %b = alloca [10 x i8]
|
|
// CHECK: call void @llvm.memcpy
|
|
// CHECK: call void @llvm.memcpy
|
|
}
|
|
|
|
|
|
union test5u { int i; double d; };
|
|
|
|
void test5(void) {
|
|
union test5u ola = (union test5u) 351;
|
|
union test5u olb = (union test5u) 1.0;
|
|
}
|
|
|
|
union test5u test5w = (union test5u)2;
|
|
union test5u test5y = (union test5u)73.0;
|
|
|
|
|
|
|
|
// PR6660 - sqlite miscompile
|
|
struct SelectDest {
|
|
unsigned char eDest;
|
|
unsigned char affinity;
|
|
int iParm;
|
|
int iMem;
|
|
};
|
|
|
|
void test6(void) {
|
|
struct SelectDest x = {1, 2, 3};
|
|
test6f(&x);
|
|
}
|
|
|
|
struct test7s { int a; int b; } test7[] = {
|
|
{1, 2},
|
|
{4},
|
|
};
|
|
|
|
#pragma pack(push, 2)
|
|
struct test8s { int f0; char f1; } test8g = {};
|
|
|
|
|
|
// PR7519
|
|
|
|
struct S {
|
|
void (*x) (struct S *);
|
|
};
|
|
|
|
extern struct S *global_dc;
|
|
void cp_diagnostic_starter(struct S *);
|
|
|
|
void init_error(void) {
|
|
global_dc->x = cp_diagnostic_starter;
|
|
}
|
|
|
|
|
|
|
|
// ABI crash in recursive struct-through-function-pointer.
|
|
typedef struct {
|
|
int x5a;
|
|
} x5;
|
|
|
|
typedef struct x2 *x0;
|
|
typedef long (*x1)(x0 x0a, x5 x6);
|
|
struct x2 {
|
|
x1 x4;
|
|
};
|
|
long x3(x0 x0a, x5 a) {
|
|
return x0a->x4(x0a, a);
|
|
}
|