Daniel Paoliello
4fabe6ffae
Use internal linkage for __NoopCoro_ResumeDestroy ( #159407 )
...
`__NoopCoro_ResumeDestroy` currently has private linkage, which causes
[issues for
Arm64EC](https://github.com/llvm/llvm-project/issues/158341 ). The
Arm64EC lowering is trying to mangle and add thunks for
`__NoopCoro_ResumeDestroy`, since it sees that it's address is taken
(and, therefore, might be called from x64 code via a function pointer).
MSVC's linker requires that the function be placed in COMDAT (`LNK1361:
non COMDAT symbol '.L#__NoopCoro_ResumeDestroy' in hybrid binary`) which
trips an assert in the verifier (`comdat global value has private
linkage`) and the subsequent linking step fails since the private symbol
isn't in the symbol table.
Since there is no reason to use private linkage for
`__NoopCoro_ResumeDestroy` and other coro related functions have also
been [switched to internal linkage to improve
debugging](https://github.com/llvm/llvm-project/pull/151224 ), this
change switches to using internal linkage.
Fixes #158341
2025-09-18 09:24:34 -07:00
..
2025-05-02 08:17:58 +00:00
2025-08-08 11:09:34 +02:00
2025-09-15 05:03:02 -05:00
2025-05-19 17:26:05 -07:00
2025-09-12 20:01:17 +02:00
2025-09-02 09:33:28 -04:00
2025-09-17 10:20:59 +00:00
2025-05-02 08:17:58 +00:00
2025-06-24 12:32:50 +01:00
2025-08-08 11:09:34 +02:00
2025-09-16 09:47:09 -07:00
2025-08-08 11:09:34 +02:00
2025-09-03 15:42:52 +00:00
2025-09-18 09:24:34 -07:00
2025-09-10 18:17:01 +02:00
2025-08-08 11:09:34 +02:00
2025-04-10 07:08:09 -07:00
2025-08-08 11:09:34 +02:00
2024-12-25 01:29:01 -08:00
2024-11-06 11:53:33 +00:00
2025-09-18 14:44:04 +00:00
2025-08-08 11:09:34 +02:00
2025-06-17 19:58:24 -04:00
2025-06-26 22:35:38 -07:00
2025-01-03 09:25:08 -08:00
2025-09-10 10:25:21 +00:00
2025-09-05 16:22:22 +02:00
2025-01-29 16:56:47 +01:00
2025-08-08 11:09:34 +02:00
2025-02-13 11:39:02 -08:00
2025-04-09 13:58:33 +02:00
2025-05-15 15:00:05 +02:00
2025-09-17 12:37:28 +02:00
2024-11-21 10:07:39 -08:00
2025-09-11 06:22:21 +00:00
2025-01-04 10:56:45 -08:00
2025-03-18 15:06:39 +01:00
2025-09-10 10:32:52 +08:00
2024-11-12 09:11:47 +00:00
2025-09-12 20:01:17 +02:00
2025-09-12 20:01:17 +02:00
2025-08-08 11:09:34 +02:00
2025-07-28 22:29:31 +01:00
2025-08-08 11:09:34 +02:00
2025-08-26 19:31:50 +01:00
2025-09-12 20:01:17 +02:00
2025-09-02 06:10:50 -05:00
2025-07-15 10:41:32 +02:00
2025-08-19 09:44:00 +02:00
2025-09-18 10:49:42 +08:00
2025-09-17 10:20:59 +00:00
2025-09-03 10:55:39 +01:00
2025-01-29 16:56:47 +01:00
2025-08-08 10:12:39 -07:00
2025-08-08 11:09:34 +02:00
2025-09-10 15:34:35 -07:00
2025-09-12 20:01:17 +02:00
2025-03-14 15:50:49 +00:00
2025-09-17 11:27:06 +02:00
2025-07-10 11:23:33 -05:00
2025-03-11 11:39:21 +08:00
2025-06-24 12:32:50 +01:00
2025-09-09 11:38:54 +00:00
2025-07-28 12:08:43 +05:30
2025-09-12 20:01:17 +02:00
2025-09-02 10:20:32 +00:00
2025-07-27 13:53:26 +01:00
2025-01-29 16:56:47 +01:00
2025-06-24 12:32:50 +01:00
2024-11-21 08:06:56 +00:00
2025-07-22 16:01:49 +02:00
2025-09-17 14:28:30 +01:00
2025-09-09 13:23:30 +00:00
2025-09-12 20:01:17 +02:00
2025-09-17 14:48:10 +01:00
2025-09-12 20:01:17 +02:00
2025-06-04 16:47:20 +01:00
2025-04-30 22:06:37 +01:00
2025-03-12 09:50:50 -07:00
2025-08-08 11:09:34 +02:00
2024-11-21 08:06:56 +00:00
2025-07-30 14:04:11 -07:00
2025-08-08 11:09:34 +02:00
2025-08-08 11:09:34 +02:00
2025-09-15 20:27:33 -07:00
2025-09-12 20:01:17 +02:00
2025-06-06 12:43:24 -07:00
2025-08-08 11:09:34 +02:00
2025-08-08 11:09:34 +02:00
2025-05-10 08:26:26 -07:00
2025-09-12 20:01:17 +02:00
2025-08-08 11:09:34 +02:00
2025-09-12 20:01:17 +02:00
2025-08-08 11:09:34 +02:00
2025-09-10 15:34:35 -07:00
2025-09-18 14:44:04 +00:00
2025-09-12 20:01:17 +02:00
2025-08-01 16:54:48 +00:00
2025-04-30 15:01:00 +02:00
2025-09-01 09:27:12 +02:00
2025-04-08 21:57:29 +07:00
2025-08-08 11:09:34 +02:00
2025-09-01 08:31:40 +08:00
2025-06-05 09:14:17 -07:00
2024-11-06 11:53:33 +00:00
2025-09-12 20:01:17 +02:00
2025-09-17 23:50:38 +08:00
2025-08-22 10:27:57 +02:00
2025-09-05 08:53:38 +02:00
2025-09-17 09:44:17 +00:00
2025-06-06 12:43:24 -07:00
2024-12-03 20:54:36 +00:00
2025-09-15 12:50:03 -07:00
2025-03-14 15:50:49 +00:00
2025-09-12 20:01:17 +02:00
2025-07-16 13:12:28 -07:00
2025-05-21 11:33:57 -07:00
2025-04-09 10:36:12 -07:00
2025-09-15 14:29:32 -05:00
2025-08-08 11:09:34 +02:00
2025-08-28 19:13:53 -07:00
2025-04-05 16:49:05 +02:00
2025-08-11 09:25:01 +02:00
2025-09-17 11:44:47 +01:00
2025-09-10 15:34:35 -07:00
2025-06-26 21:35:35 -07:00
2025-06-27 11:28:07 -07:00
2025-01-27 20:08:53 -08:00