
This reverts commit 22561cfb443267905d4190f0e2a738e6b412457f and fixes b7b9ccf44988edf49886743ae5c3cf4184db211f (#112079). The problem is that x86_64 and Arm 32-bit have memory regions above the stack that are readable but not writeable. First Arm: ``` (lldb) memory region --all <...> [0x00000000fffcf000-0x00000000ffff0000) rw- [stack] [0x00000000ffff0000-0x00000000ffff1000) r-x [vectors] [0x00000000ffff1000-0xffffffffffffffff) --- ``` Then x86_64: ``` $ cat /proc/self/maps <...> 7ffdcd148000-7ffdcd16a000 rw-p 00000000 00:00 0 [stack] 7ffdcd193000-7ffdcd196000 r--p 00000000 00:00 0 [vvar] 7ffdcd196000-7ffdcd197000 r-xp 00000000 00:00 0 [vdso] ffffffffff600000-ffffffffff601000 --xp 00000000 00:00 0 [vsyscall] ``` Compare this to AArch64 where the test did pass: ``` $ cat /proc/self/maps <...> ffffb87dc000-ffffb87dd000 r--p 00000000 00:00 0 [vvar] ffffb87dd000-ffffb87de000 r-xp 00000000 00:00 0 [vdso] ffffb87de000-ffffb87e0000 r--p 0002a000 00:3c 76927217 /usr/lib/aarch64-linux-gnu/ld-linux-aarch64.so.1 ffffb87e0000-ffffb87e2000 rw-p 0002c000 00:3c 76927217 /usr/lib/aarch64-linux-gnu/ld-linux-aarch64.so.1 fffff4216000-fffff4237000 rw-p 00000000 00:00 0 [stack] ``` To solve this, look up the memory region of the stack pointer (using https://lldb.llvm.org/resources/lldbgdbremote.html#qmemoryregioninfo-addr) and constrain the read to within that region. Since we know the stack is all readable and writeable. I have also added skipIfRemote to the tests, since getting them working in that context is too complex to be worth it. Memory write failures now display the range they tried to write, and register write errors will show the name of the register where possible. The patch also includes a workaround for a an issue where the test code could mistake an `x` response that happens to begin with an `O` for an output packet (stdout). This workaround will not be necessary one we start using the [new implementation](https://discourse.llvm.org/t/rfc-fixing-incompatibilties-of-the-x-packet-w-r-t-gdb/84288) of the `x` packet. --------- Co-authored-by: Pavel Labath <pavel@labath.sk>
135 lines
5.5 KiB
Python
135 lines
5.5 KiB
Python
import lldb
|
|
import time
|
|
import unittest
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.gdbclientutils import *
|
|
from lldbsuite.test.lldbreverse import ReverseTestBase
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class TestReverseContinueWatchpoints(ReverseTestBase):
|
|
@skipIfRemote
|
|
def test_reverse_continue_watchpoint(self):
|
|
self.reverse_continue_watchpoint_internal(async_mode=False)
|
|
|
|
@skipIfRemote
|
|
def test_reverse_continue_watchpoint_async(self):
|
|
self.reverse_continue_watchpoint_internal(async_mode=True)
|
|
|
|
def reverse_continue_watchpoint_internal(self, async_mode):
|
|
target, process, initial_threads, watch_addr = self.setup_recording(async_mode)
|
|
|
|
error = lldb.SBError()
|
|
wp_opts = lldb.SBWatchpointOptions()
|
|
wp_opts.SetWatchpointTypeWrite(lldb.eWatchpointWriteTypeOnModify)
|
|
watchpoint = target.WatchpointCreateByAddress(watch_addr, 4, wp_opts, error)
|
|
self.assertTrue(watchpoint)
|
|
|
|
watch_var = target.EvaluateExpression("*g_watched_var_ptr")
|
|
self.assertEqual(watch_var.GetValueAsSigned(-1), 2)
|
|
|
|
# Reverse-continue to the function "trigger_watchpoint".
|
|
status = process.ContinueInDirection(lldb.eRunReverse)
|
|
self.assertSuccess(status)
|
|
self.expect_async_state_changes(
|
|
async_mode, process, [lldb.eStateRunning, lldb.eStateStopped]
|
|
)
|
|
# We should stop at the point just before the location was modified.
|
|
watch_var = target.EvaluateExpression("*g_watched_var_ptr")
|
|
self.assertEqual(watch_var.GetValueAsSigned(-1), 1)
|
|
self.expect(
|
|
"thread list",
|
|
STOPPED_DUE_TO_WATCHPOINT,
|
|
substrs=["stopped", "trigger_watchpoint", "stop reason = watchpoint 1"],
|
|
)
|
|
|
|
# Stepping forward one instruction should change the value of the variable.
|
|
initial_threads[0].StepInstruction(False)
|
|
self.expect_async_state_changes(
|
|
async_mode, process, [lldb.eStateRunning, lldb.eStateStopped]
|
|
)
|
|
watch_var = target.EvaluateExpression("*g_watched_var_ptr")
|
|
self.assertEqual(watch_var.GetValueAsSigned(-1), 2)
|
|
self.expect(
|
|
"thread list",
|
|
STOPPED_DUE_TO_WATCHPOINT,
|
|
substrs=["stopped", "trigger_watchpoint", "stop reason = watchpoint 1"],
|
|
)
|
|
|
|
@skipIfRemote
|
|
def test_reverse_continue_skip_watchpoint(self):
|
|
self.reverse_continue_skip_watchpoint_internal(async_mode=False)
|
|
|
|
@skipIfRemote
|
|
def test_reverse_continue_skip_watchpoint_async(self):
|
|
self.reverse_continue_skip_watchpoint_internal(async_mode=True)
|
|
|
|
def reverse_continue_skip_watchpoint_internal(self, async_mode):
|
|
target, process, initial_threads, watch_addr = self.setup_recording(async_mode)
|
|
|
|
# Reverse-continue over a watchpoint whose condition is false
|
|
# (via function call).
|
|
# This tests that we continue in the correct direction after hitting
|
|
# the watchpoint.
|
|
error = lldb.SBError()
|
|
wp_opts = lldb.SBWatchpointOptions()
|
|
wp_opts.SetWatchpointTypeWrite(lldb.eWatchpointWriteTypeOnModify)
|
|
watchpoint = target.WatchpointCreateByAddress(watch_addr, 4, wp_opts, error)
|
|
self.assertTrue(watchpoint)
|
|
watchpoint.SetCondition("false_condition()")
|
|
status = process.ContinueInDirection(lldb.eRunReverse)
|
|
self.expect_async_state_changes(
|
|
async_mode, process, [lldb.eStateRunning, lldb.eStateStopped]
|
|
)
|
|
self.assertSuccess(status)
|
|
self.expect(
|
|
"thread list",
|
|
STOPPED_DUE_TO_HISTORY_BOUNDARY,
|
|
substrs=["stopped", "stop reason = history boundary"],
|
|
)
|
|
|
|
def setup_recording(self, async_mode):
|
|
"""
|
|
Record execution of code between "start_recording" and "stop_recording" breakpoints.
|
|
|
|
Returns with the target stopped at "stop_recording", with recording disabled,
|
|
ready to reverse-execute.
|
|
"""
|
|
self.build()
|
|
target = self.dbg.CreateTarget("")
|
|
process = self.connect(target)
|
|
|
|
# Record execution from the start of the function "start_recording"
|
|
# to the start of the function "stop_recording". We want to keep the
|
|
# interval that we record as small as possible to minimize the run-time
|
|
# of our single-stepping recorder.
|
|
start_recording_bkpt = target.BreakpointCreateByName("start_recording", None)
|
|
initial_threads = lldbutil.continue_to_breakpoint(process, start_recording_bkpt)
|
|
self.assertEqual(len(initial_threads), 1)
|
|
target.BreakpointDelete(start_recording_bkpt.GetID())
|
|
|
|
frame0 = initial_threads[0].GetFrameAtIndex(0)
|
|
watched_var_ptr = frame0.FindValue(
|
|
"g_watched_var_ptr", lldb.eValueTypeVariableGlobal
|
|
)
|
|
watch_addr = watched_var_ptr.GetValueAsUnsigned(0)
|
|
self.assertTrue(watch_addr > 0)
|
|
|
|
self.start_recording()
|
|
stop_recording_bkpt = target.BreakpointCreateByName("stop_recording", None)
|
|
lldbutil.continue_to_breakpoint(process, stop_recording_bkpt)
|
|
target.BreakpointDelete(stop_recording_bkpt.GetID())
|
|
self.stop_recording()
|
|
|
|
self.dbg.SetAsync(async_mode)
|
|
self.expect_async_state_changes(async_mode, process, [lldb.eStateStopped])
|
|
|
|
return target, process, initial_threads, watch_addr
|
|
|
|
def expect_async_state_changes(self, async_mode, process, states):
|
|
if not async_mode:
|
|
return
|
|
listener = self.dbg.GetListener()
|
|
lldbutil.expect_state_changes(self, listener, process, states)
|