3e25ae605e
Previously, Itanium ABI guard variables were set after initialization was
complete for non-block declared variables with static and thread storage
duration. That resulted in initialization of such variables being restarted
in cases where the variable was referenced while it was still under
construction. Per C++20 [class.cdtor]p2, such references are permitted
(though the value obtained by such an access is unspecified). The late
initialization resulted in recursive reinitialization loops for cases like
this:
template<typename T>
struct ct {
struct mc {
mc() { ct<T>::smf(); }
void mf() const {}
};
thread_local static mc tlsdm;
static void smf() { tlsdm.mf(); }
};
template<typename T>
thread_local typename ct<T>::mc ct<T>::tlsdm;
int main() {
ct<int>::smf();
}
With this change, guard variables are set before initialization is started
so as to avoid such reinitialization loops.
Fixes https://github.com/llvm/llvm-project/issues/57828
Reviewed By: rjmccall
Differential Revision: https://reviews.llvm.org/D135919
217 lines
7.8 KiB
C++
217 lines
7.8 KiB
C++
// RUN: %clang_cc1 %std_cxx98-14 -no-opaque-pointers -triple=x86_64-apple-darwin10 -emit-llvm -fexceptions %s -o - |FileCheck %s --check-prefixes=CHECK,PRE17
|
|
// RUN: %clang_cc1 %std_cxx98-14 -no-opaque-pointers -triple=x86_64-apple-darwin10 -emit-llvm %s -o - |FileCheck %s --check-prefixes=CHECK-NOEXC,PRE17
|
|
// RUN: %clang_cc1 %std_cxx98-14 -no-opaque-pointers -triple=x86_64-apple-darwin10 -emit-llvm -mframe-pointer=non-leaf %s -o - \
|
|
// RUN: | FileCheck -check-prefix CHECK-FP %s
|
|
// RUN: %clang_cc1 %std_cxx98-14 -no-opaque-pointers -triple=x86_64-apple-darwin10 -emit-llvm %s -o - -fno-builtin \
|
|
// RUN: | FileCheck -check-prefix CHECK-NOBUILTIN %s
|
|
// RUN: %clang_cc1 %std_cxx17- -no-opaque-pointers -triple=x86_64-apple-darwin10 -emit-llvm -fexceptions %s -o - | FileCheck %s
|
|
|
|
struct A {
|
|
A();
|
|
~A();
|
|
};
|
|
|
|
struct B { B(); ~B(); };
|
|
|
|
struct C { void *field; };
|
|
|
|
struct D { ~D(); };
|
|
|
|
// CHECK: @__dso_handle = external hidden global i8
|
|
// CHECK: @c ={{.*}} global %struct.C zeroinitializer, align 8
|
|
|
|
// PR6205: The casts should not require global initializers
|
|
// CHECK: @_ZN6PR59741cE = external global %"struct.PR5974::C"
|
|
// CHECK: @_ZN6PR59741aE ={{.*}} global %"struct.PR5974::A"* getelementptr inbounds (%"struct.PR5974::C", %"struct.PR5974::C"* @_ZN6PR59741cE, i32 0, i32 0)
|
|
// CHECK: @_ZN6PR59741bE ={{.*}} global %"struct.PR5974::B"* bitcast (i8* getelementptr (i8, i8* bitcast (%"struct.PR5974::C"* @_ZN6PR59741cE to i8*), i64 4) to %"struct.PR5974::B"*), align 8
|
|
|
|
// CHECK: call void @_ZN1AC1Ev(%struct.A* {{[^,]*}} @a)
|
|
// CHECK: call i32 @__cxa_atexit(void (i8*)* bitcast (void (%struct.A*)* @_ZN1AD1Ev to void (i8*)*), i8* getelementptr inbounds (%struct.A, %struct.A* @a, i32 0, i32 0), i8* @__dso_handle)
|
|
A a;
|
|
|
|
// CHECK: call void @_ZN1BC1Ev(%struct.B* {{[^,]*}} @b)
|
|
// CHECK: call i32 @__cxa_atexit(void (i8*)* bitcast (void (%struct.B*)* @_ZN1BD1Ev to void (i8*)*), i8* getelementptr inbounds (%struct.B, %struct.B* @b, i32 0, i32 0), i8* @__dso_handle)
|
|
B b;
|
|
|
|
// PR6205: this should not require a global initializer
|
|
// CHECK-NOT: call void @_ZN1CC1Ev(%struct.C* @c)
|
|
C c;
|
|
|
|
// CHECK: call i32 @__cxa_atexit(void (i8*)* bitcast (void (%struct.D*)* @_ZN1DD1Ev to void (i8*)*), i8* getelementptr inbounds (%struct.D, %struct.D* @d, i32 0, i32 0), i8* @__dso_handle)
|
|
D d;
|
|
|
|
// <rdar://problem/7458115>
|
|
namespace test1 {
|
|
int f();
|
|
const int x = f(); // This has side-effects and gets emitted immediately.
|
|
const int y = x - 1; // This gets deferred.
|
|
const int z = ~y; // This also gets deferred, but gets "undeferred" before y.
|
|
int test() { return z; }
|
|
// CHECK-LABEL: define{{.*}} i32 @_ZN5test14testEv()
|
|
|
|
// All of these initializers end up delayed, so we check them later.
|
|
}
|
|
|
|
// <rdar://problem/8246444>
|
|
namespace test2 {
|
|
struct allocator { allocator(); ~allocator(); };
|
|
struct A { A(const allocator &a = allocator()); ~A(); };
|
|
|
|
A a;
|
|
// CHECK: call void @_ZN5test29allocatorC1Ev(
|
|
// CHECK: invoke void @_ZN5test21AC1ERKNS_9allocatorE(
|
|
// CHECK: call void @_ZN5test29allocatorD1Ev(
|
|
// CHECK: call i32 @__cxa_atexit({{.*}} @_ZN5test21AD1Ev {{.*}} @_ZN5test21aE
|
|
}
|
|
|
|
namespace test3 {
|
|
// Tested at the beginning of the file.
|
|
const char * const var = "string";
|
|
extern const char * const var;
|
|
|
|
const char *test() { return var; }
|
|
}
|
|
|
|
namespace test4 {
|
|
struct A {
|
|
A();
|
|
};
|
|
extern int foo();
|
|
|
|
// This needs an initialization function and guard variables.
|
|
// CHECK: load i8, i8* bitcast (i64* @_ZGVN5test41xE to i8*)
|
|
// CHECK: store i8 1, i8* bitcast (i64* @_ZGVN5test41xE to i8*)
|
|
// CHECK-NEXT: [[CALL:%.*]] = call noundef i32 @_ZN5test43fooEv
|
|
// CHECK-NEXT: store i32 [[CALL]], i32* @_ZN5test41xE
|
|
__attribute__((weak)) int x = foo();
|
|
}
|
|
|
|
namespace PR5974 {
|
|
struct A { int a; };
|
|
struct B { int b; };
|
|
struct C : A, B { int c; };
|
|
|
|
extern C c;
|
|
|
|
// These should not require global initializers.
|
|
A* a = &c;
|
|
B* b = &c;
|
|
}
|
|
|
|
// PR9570: the indirect field shouldn't crash IR gen.
|
|
namespace test5 {
|
|
static union {
|
|
unsigned bar[4096] __attribute__((aligned(128)));
|
|
};
|
|
}
|
|
|
|
namespace std { struct type_info; }
|
|
|
|
namespace test6 {
|
|
struct A { virtual ~A(); };
|
|
struct B : A {};
|
|
extern A *p;
|
|
|
|
// We must emit a dynamic initializer for 'q', because it could throw.
|
|
B *const q = &dynamic_cast<B&>(*p);
|
|
// CHECK: call void @__cxa_bad_cast()
|
|
// CHECK: store {{.*}} @_ZN5test6L1qE
|
|
|
|
// We don't need to emit 'r' at all, because it has internal linkage, is
|
|
// unused, and its initialization has no side-effects.
|
|
B *const r = dynamic_cast<B*>(p);
|
|
// CHECK-NOT: call void @__cxa_bad_cast()
|
|
// CHECK-NOT: store {{.*}} @_ZN5test6L1rE
|
|
|
|
// This can throw, so we need to emit it.
|
|
const std::type_info *const s = &typeid(*p);
|
|
// CHECK: store {{.*}} @_ZN5test6L1sE
|
|
|
|
// This can't throw, so we don't.
|
|
const std::type_info *const t = &typeid(p);
|
|
// CHECK-NOT: @_ZN5test6L1tE
|
|
|
|
extern B *volatile v;
|
|
// CHECK: store {{.*}} @_ZN5test6L1wE
|
|
B *const w = dynamic_cast<B*>(v);
|
|
|
|
// CHECK: load volatile
|
|
// CHECK: store {{.*}} @_ZN5test6L1xE
|
|
const int x = *(volatile int*)0x1234;
|
|
|
|
namespace {
|
|
int a = int();
|
|
volatile int b = int();
|
|
int c = a;
|
|
int d = b;
|
|
// CHECK-NOT: store {{.*}} @_ZN5test6{{[A-Za-z0-9_]*}}1aE
|
|
// CHECK-NOT: store {{.*}} @_ZN5test6{{[A-Za-z0-9_]*}}1bE
|
|
// CHECK-NOT: store {{.*}} @_ZN5test6{{[A-Za-z0-9_]*}}1cE
|
|
// CHECK: load volatile {{.*}} @_ZN5test6{{[A-Za-z0-9_]*}}1bE
|
|
// CHECK: store {{.*}} @_ZN5test6{{[A-Za-z0-9_]*}}1dE
|
|
}
|
|
}
|
|
|
|
namespace test7 {
|
|
struct A { A(); };
|
|
struct B { ~B(); int n; };
|
|
struct C { C() = default; C(const C&); int n; };
|
|
struct D {};
|
|
|
|
// CHECK: call void @_ZN5test71AC1Ev({{.*}}@_ZN5test7L1aE)
|
|
const A a = A();
|
|
|
|
// CHECK: call i32 @__cxa_atexit({{.*}} @_ZN5test71BD1Ev{{.*}} @_ZN5test7L2b1E
|
|
// CHECK: call i32 @__cxa_atexit({{.*}} @_ZN5test71BD1Ev{{.*}} @_ZGRN5test72b2E
|
|
// CHECK: call void @_ZN5test71BD1Ev(
|
|
// CHECK: store {{.*}} @_ZN5test7L2b3E
|
|
const B b1 = B();
|
|
const B &b2 = B();
|
|
const int b3 = B().n;
|
|
|
|
// CHECK-NOT: @_ZN5test7L2c1E
|
|
// PRE17: call void @llvm.memset{{.*}} @_ZN5test7L2c1E
|
|
// CHECK-NOT: @_ZN5test7L2c1E
|
|
// CHECK: @_ZN5test7L2c2E
|
|
// CHECK-NOT: @_ZN5test7L2c3E
|
|
// PRE17: @_ZN5test7L2c4E
|
|
const C c1 = C();
|
|
const C c2 = static_cast<const C&>(C());
|
|
const int c3 = C().n;
|
|
const int c4 = C(C()).n;
|
|
|
|
// CHECK-NOT: @_ZN5test7L1dE
|
|
const D d = D();
|
|
|
|
// CHECK: store {{.*}} @_ZN5test71eE
|
|
int f(), e = f();
|
|
}
|
|
|
|
|
|
// At the end of the file, we check that y is initialized before z.
|
|
|
|
// CHECK: define internal void [[TEST1_Z_INIT:@.*]]()
|
|
// CHECK: load i32, i32* @_ZN5test1L1yE
|
|
// CHECK-NEXT: xor
|
|
// CHECK-NEXT: store i32 {{.*}}, i32* @_ZN5test1L1zE
|
|
// CHECK: define internal void [[TEST1_Y_INIT:@.*]]()
|
|
// CHECK: load i32, i32* @_ZN5test1L1xE
|
|
// CHECK-NEXT: sub
|
|
// CHECK-NEXT: store i32 {{.*}}, i32* @_ZN5test1L1yE
|
|
|
|
// CHECK: define internal void @_GLOBAL__sub_I_global_init.cpp() #{{[0-9]+}} section "__TEXT,__StaticInit,regular,pure_instructions" {
|
|
// CHECK: call void [[TEST1_Y_INIT]]
|
|
// CHECK: call void [[TEST1_Z_INIT]]
|
|
|
|
// rdar://problem/8090834: this should be nounwind
|
|
// CHECK-NOEXC: define internal void @_GLOBAL__sub_I_global_init.cpp() [[NUW:#[0-9]+]] section "__TEXT,__StaticInit,regular,pure_instructions" {
|
|
// CHECK-NOEXC: attributes [[NUW]] = { noinline nounwind{{.*}} }
|
|
|
|
// Make sure we mark global initializers with the no-builtins attribute.
|
|
// CHECK-NOBUILTIN: define internal void @_GLOBAL__sub_I_global_init.cpp() [[NUW:#[0-9]+]] section "__TEXT,__StaticInit,regular,pure_instructions" {
|
|
// CHECK-NOBUILTIN: attributes [[NUW]] = { noinline nounwind{{.*}}"no-builtins"{{.*}} }
|
|
|
|
// PR21811: attach the appropriate attribute to the global init function
|
|
// CHECK-FP: define internal void @_GLOBAL__sub_I_global_init.cpp() [[NUX:#[0-9]+]] section "__TEXT,__StaticInit,regular,pure_instructions" {
|
|
// CHECK-FP: attributes [[NUX]] = { noinline nounwind {{.*}}"frame-pointer"="non-leaf"{{.*}} }
|