7068aa9841
Clang has traditionally allowed C programs to implicitly convert integers to pointers and pointers to integers, despite it not being valid to do so except under special circumstances (like converting the integer 0, which is the null pointer constant, to a pointer). In C89, this would result in undefined behavior per 3.3.4, and in C99 this rule was strengthened to be a constraint violation instead. Constraint violations are most often handled as an error. This patch changes the warning to default to an error in all C modes (it is already an error in C++). This gives us better security posture by calling out potential programmer mistakes in code but still allows users who need this behavior to use -Wno-error=int-conversion to retain the warning behavior, or -Wno-int-conversion to silence the diagnostic entirely. Differential Revision: https://reviews.llvm.org/D129881
26 lines
1.3 KiB
Objective-C
26 lines
1.3 KiB
Objective-C
// RUN: %clang_cc1 -fsyntax-only -verify %s
|
|
// rdar://10904488
|
|
|
|
@interface Test
|
|
- (int)objectAtIndexedSubscript:(int)index; // expected-note {{method 'objectAtIndexedSubscript:' declared here}}
|
|
- (void)setObject:(int)object atIndexedSubscript:(int)index; // expected-note {{parameter of type 'int' is declared here}}
|
|
@end
|
|
|
|
@interface NSMutableDictionary
|
|
- (int)objectForKeyedSubscript:(id)key; // expected-note {{method 'objectForKeyedSubscript:' declared here}}
|
|
- (void)setObject:(int)object forKeyedSubscript:(id)key; // expected-note {{parameter of type 'int' is declared here}}
|
|
@end
|
|
|
|
int main(void) {
|
|
Test *array;
|
|
int i = array[10]; // expected-error {{method for accessing array element must have Objective-C object return type instead of 'int'}}
|
|
array[2] = i; // expected-error {{cannot assign to this array because assigning method's 2nd parameter of type 'int' is not an Objective-C pointer type}}
|
|
|
|
NSMutableDictionary *dict;
|
|
id key, val;
|
|
val = dict[key]; // expected-error {{method for accessing dictionary element must have Objective-C object return type instead of 'int'}} \
|
|
// expected-error {{incompatible integer to pointer conversion assigning to 'id' from 'int'}}
|
|
dict[key] = val; // expected-error {{method object parameter type 'int' is not object type}}
|
|
}
|
|
|