
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
44 lines
1.5 KiB
C++
44 lines
1.5 KiB
C++
//===-- IDebugDelegate.h ----------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef liblldb_Plugins_Process_Windows_IDebugDelegate_H_
|
|
#define liblldb_Plugins_Process_Windows_IDebugDelegate_H_
|
|
|
|
#include "ForwardDecl.h"
|
|
#include "lldb/lldb-forward.h"
|
|
#include "lldb/lldb-types.h"
|
|
#include <string>
|
|
|
|
namespace lldb_private {
|
|
class Status;
|
|
class HostThread;
|
|
|
|
// IDebugDelegate
|
|
//
|
|
// IDebugDelegate defines an interface which allows implementors to receive
|
|
// notification of events that happen in a debugged process.
|
|
class IDebugDelegate {
|
|
public:
|
|
virtual ~IDebugDelegate() {}
|
|
|
|
virtual void OnExitProcess(uint32_t exit_code) = 0;
|
|
virtual void OnDebuggerConnected(lldb::addr_t image_base) = 0;
|
|
virtual ExceptionResult OnDebugException(bool first_chance,
|
|
const ExceptionRecord &record) = 0;
|
|
virtual void OnCreateThread(const HostThread &thread) = 0;
|
|
virtual void OnExitThread(lldb::tid_t thread_id, uint32_t exit_code) = 0;
|
|
virtual void OnLoadDll(const ModuleSpec &module_spec,
|
|
lldb::addr_t module_addr) = 0;
|
|
virtual void OnUnloadDll(lldb::addr_t module_addr) = 0;
|
|
virtual void OnDebugString(const std::string &string) = 0;
|
|
virtual void OnDebuggerError(const Status &error, uint32_t type) = 0;
|
|
};
|
|
}
|
|
|
|
#endif
|