JF Bastien 2df59c5068 Support tests in freestanding
Summary:
Freestanding is *weird*. The standard allows it to differ in a bunch of odd
manners from regular C++, and the committee would like to improve that
situation. I'd like to make libc++ behave better with what freestanding should
be, so that it can be a tool we use in improving the standard. To do that we
need to try stuff out, both with "freestanding the language mode" and
"freestanding the library subset".

Let's start with the super basic: run the libc++ tests in freestanding, using
clang as the compiler, and see what works. The easiest hack to do this:

In utils/libcxx/test/config.py add:

  self.cxx.compile_flags += ['-ffreestanding']

Run the tests and they all fail.

Why? Because in freestanding `main` isn't special. This "not special" property
has two effects: main doesn't get mangled, and main isn't allowed to omit its
`return` statement. The first means main gets mangled and the linker can't
create a valid executable for us to test. The second means we spew out warnings
(ew) and the compiler doesn't insert the `return` we omitted, and main just
falls of the end and does whatever undefined behavior (if you're luck, ud2
leading to non-zero return code).

Let's start my work with the basics. This patch changes all libc++ tests to
declare `main` as `int main(int, char**` so it mangles consistently (enabling us
to declare another `extern "C"` main for freestanding which calls the mangled
one), and adds `return 0;` to all places where it was missing. This touches 6124
files, and I apologize.

The former was done with The Magic Of Sed.

The later was done with a (not quite correct but decent) clang tool:

  https://gist.github.com/jfbastien/793819ff360baa845483dde81170feed

This works for most tests, though I did have to adjust a few places when e.g.
the test runs with `-x c`, macros are used for main (such as for the filesystem
tests), etc.

Once this is in we can create a freestanding bot which will prevent further
regressions. After that, we can start the real work of supporting C++
freestanding fairly well in libc++.

<rdar://problem/47754795>

Reviewers: ldionne, mclow.lists, EricWF

Subscribers: christof, jkorous, dexonsmith, arphaman, miyuki, libcxx-commits

Differential Revision: https://reviews.llvm.org/D57624

llvm-svn: 353086
2019-02-04 20:31:13 +00:00

156 lines
4.3 KiB
C++

//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//
// UNSUPPORTED: libcpp-has-no-threads
// UNSUPPORTED: c++98, c++03
// <future>
// template <class F, class... Args>
// future<typename result_of<F(Args...)>::type>
// async(F&& f, Args&&... args);
// template <class F, class... Args>
// future<typename result_of<F(Args...)>::type>
// async(launch policy, F&& f, Args&&... args);
#include <future>
#include <atomic>
#include <memory>
#include <cassert>
#include "test_macros.h"
typedef std::chrono::high_resolution_clock Clock;
typedef std::chrono::milliseconds ms;
std::atomic_bool invoked = ATOMIC_VAR_INIT(false);
int f0()
{
invoked = true;
std::this_thread::sleep_for(ms(200));
return 3;
}
int i = 0;
int& f1()
{
invoked = true;
std::this_thread::sleep_for(ms(200));
return i;
}
void f2()
{
invoked = true;
std::this_thread::sleep_for(ms(200));
}
std::unique_ptr<int> f3(int j)
{
invoked = true;
std::this_thread::sleep_for(ms(200));
return std::unique_ptr<int>(new int(j));
}
std::unique_ptr<int> f4(std::unique_ptr<int>&& p)
{
invoked = true;
std::this_thread::sleep_for(ms(200));
return std::move(p);
}
void f5(int j)
{
std::this_thread::sleep_for(ms(200));
((void)j);
TEST_THROW(j);
}
template <class Ret, class CheckLamdba, class ...Args>
void test(CheckLamdba&& getAndCheckFn, bool IsDeferred, Args&&... args) {
// Reset global state.
invoked = false;
// Create the future and wait
std::future<Ret> f = std::async(std::forward<Args>(args)...);
std::this_thread::sleep_for(ms(300));
// Check that deferred async's have not invoked the function.
assert(invoked == !IsDeferred);
// Time the call to f.get() and check that the returned value matches
// what is expected.
Clock::time_point t0 = Clock::now();
assert(getAndCheckFn(f));
Clock::time_point t1 = Clock::now();
// If the async is deferred it should take more than 100ms, otherwise
// it should take less than 100ms.
if (IsDeferred) {
assert(t1-t0 > ms(100));
} else {
assert(t1-t0 < ms(100));
}
}
int main(int, char**)
{
// The default launch policy is implementation defined. libc++ defines
// it to be std::launch::async.
bool DefaultPolicyIsDeferred = false;
bool DPID = DefaultPolicyIsDeferred;
std::launch AnyPolicy = std::launch::async | std::launch::deferred;
LIBCPP_ASSERT(AnyPolicy == std::launch::any);
{
auto checkInt = [](std::future<int>& f) { return f.get() == 3; };
test<int>(checkInt, DPID, f0);
test<int>(checkInt, false, std::launch::async, f0);
test<int>(checkInt, true, std::launch::deferred, f0);
test<int>(checkInt, DPID, AnyPolicy, f0);
}
{
auto checkIntRef = [&](std::future<int&>& f) { return &f.get() == &i; };
test<int&>(checkIntRef, DPID, f1);
test<int&>(checkIntRef, false, std::launch::async, f1);
test<int&>(checkIntRef, true, std::launch::deferred, f1);
test<int&>(checkIntRef, DPID, AnyPolicy, f1);
}
{
auto checkVoid = [](std::future<void>& f) { f.get(); return true; };
test<void>(checkVoid, DPID, f2);
test<void>(checkVoid, false, std::launch::async, f2);
test<void>(checkVoid, true, std::launch::deferred, f2);
test<void>(checkVoid, DPID, AnyPolicy, f2);
}
{
using Ret = std::unique_ptr<int>;
auto checkUPtr = [](std::future<Ret>& f) { return *f.get() == 3; };
test<Ret>(checkUPtr, DPID, f3, 3);
test<Ret>(checkUPtr, DPID, f4, std::unique_ptr<int>(new int(3)));
}
#ifndef TEST_HAS_NO_EXCEPTIONS
{
std::future<void> f = std::async(f5, 3);
std::this_thread::sleep_for(ms(300));
try { f.get(); assert (false); } catch ( int ) {}
}
{
std::future<void> f = std::async(std::launch::deferred, f5, 3);
std::this_thread::sleep_for(ms(300));
try { f.get(); assert (false); } catch ( int ) {}
}
#endif
return 0;
}