0e62d5cf55
Ensure that FormatStringConverter's constructor fails with a sensible error message rather than asserting if the format string is not a narrow string literal. Also, ensure that we don't even get that far in modernize-use-std-print and modernize-use-std-format by checking that the format string parameter is a char pointer. Fixes #92896
67 lines
3.1 KiB
C++
67 lines
3.1 KiB
C++
// RUN: %check_clang_tidy -check-suffixes=,STRICT \
|
|
// RUN: -std=c++20 %s modernize-use-std-format %t -- \
|
|
// RUN: -config="{CheckOptions: { \
|
|
// RUN: modernize-use-std-format.StrictMode: true, \
|
|
// RUN: modernize-use-std-format.StrFormatLikeFunctions: '::strprintf; mynamespace::strprintf2; bad_format_type_strprintf', \
|
|
// RUN: modernize-use-std-format.ReplacementFormatFunction: 'fmt::format', \
|
|
// RUN: modernize-use-std-format.FormatHeader: '<fmt/core.h>' \
|
|
// RUN: }}" \
|
|
// RUN: -- -isystem %clang_tidy_headers
|
|
// RUN: %check_clang_tidy -check-suffixes=,NOTSTRICT \
|
|
// RUN: -std=c++20 %s modernize-use-std-format %t -- \
|
|
// RUN: -config="{CheckOptions: { \
|
|
// RUN: modernize-use-std-format.StrFormatLikeFunctions: '::strprintf; mynamespace::strprintf2; bad_format_type_strprintf', \
|
|
// RUN: modernize-use-std-format.ReplacementFormatFunction: 'fmt::format', \
|
|
// RUN: modernize-use-std-format.FormatHeader: '<fmt/core.h>' \
|
|
// RUN: }}" \
|
|
// RUN: -- -isystem %clang_tidy_headers
|
|
|
|
#include <cstdio>
|
|
#include <string>
|
|
// CHECK-FIXES: #include <fmt/core.h>
|
|
|
|
std::string strprintf(const char *, ...);
|
|
|
|
namespace mynamespace {
|
|
std::string strprintf2(const char *, ...);
|
|
}
|
|
|
|
std::string strprintf_test(const std::string &name, double value) {
|
|
return strprintf("'%s'='%f'\n", name.c_str(), value);
|
|
// CHECK-MESSAGES: [[@LINE-1]]:10: warning: use 'fmt::format' instead of 'strprintf' [modernize-use-std-format]
|
|
// CHECK-FIXES: return fmt::format("'{}'='{:f}'\n", name, value);
|
|
|
|
return mynamespace::strprintf2("'%s'='%f'\n", name.c_str(), value);
|
|
// CHECK-MESSAGES: [[@LINE-1]]:10: warning: use 'fmt::format' instead of 'strprintf2' [modernize-use-std-format]
|
|
// CHECK-FIXES: return fmt::format("'{}'='{:f}'\n", name, value);
|
|
}
|
|
|
|
std::string StrFormat_strict_conversion() {
|
|
const unsigned char uc = 'A';
|
|
return strprintf("Integer %hhd from unsigned char\n", uc);
|
|
// CHECK-MESSAGES: [[@LINE-1]]:10: warning: use 'fmt::format' instead of 'strprintf' [modernize-use-std-format]
|
|
// CHECK-FIXES-NOTSTRICT: return fmt::format("Integer {} from unsigned char\n", uc);
|
|
// CHECK-FIXES-STRICT: return fmt::format("Integer {} from unsigned char\n", static_cast<signed char>(uc));
|
|
}
|
|
|
|
// Ensure that MatchesAnyListedNameMatcher::NameMatcher::match() can cope with a
|
|
// NamedDecl that has no name when we're trying to match unqualified_strprintf.
|
|
std::string A(const std::string &in)
|
|
{
|
|
return "_" + in;
|
|
}
|
|
|
|
// Issue #92896: Ensure that the check doesn't assert if the argument is
|
|
// promoted to something that isn't a string.
|
|
struct S {
|
|
S(...);
|
|
};
|
|
std::string bad_format_type_strprintf(const S &, ...);
|
|
|
|
std::string unsupported_format_parameter_type()
|
|
{
|
|
// No fixes here because the format parameter of the function called is not a
|
|
// string.
|
|
return bad_format_type_strprintf("");
|
|
}
|