0f46e31cfb
As part of the migration to ptradd (https://discourse.llvm.org/t/rfc-replacing-getelementptr-with-ptradd/68699), we need to change the representation of the `inrange` attribute, which is used for vtable splitting. Currently, inrange is specified as follows: ``` getelementptr inbounds ({ [4 x ptr], [4 x ptr] }, ptr @vt, i64 0, inrange i32 1, i64 2) ``` The `inrange` is placed on a GEP index, and all accesses must be "in range" of that index. The new representation is as follows: ``` getelementptr inbounds inrange(-16, 16) ({ [4 x ptr], [4 x ptr] }, ptr @vt, i64 0, i32 1, i64 2) ``` This specifies which offsets are "in range" of the GEP result. The new representation will continue working when canonicalizing to ptradd representation: ``` getelementptr inbounds inrange(-16, 16) (i8, ptr @vt, i64 48) ``` The inrange offsets are relative to the return value of the GEP. An alternative design could make them relative to the source pointer instead. The result-relative format was chosen on the off-chance that we want to extend support to non-constant GEPs in the future, in which case this variant is more expressive. This implementation "upgrades" the old inrange representation in bitcode by simply dropping it. This is a very niche feature, and I don't think trying to upgrade it is worthwhile. Let me know if you disagree.
201 lines
3.9 KiB
C++
201 lines
3.9 KiB
C++
// RUN: %clang_cc1 %s -triple=x86_64-apple-darwin10 -emit-llvm -o - | FileCheck %s
|
|
|
|
// See Test9 for test description.
|
|
// CHECK: @_ZTTN5Test91BE = linkonce_odr unnamed_addr constant
|
|
namespace Test1 {
|
|
|
|
// Check that we don't initialize the vtable pointer in A::~A(), since the destructor body is trivial.
|
|
struct A {
|
|
virtual void f();
|
|
~A();
|
|
};
|
|
|
|
// CHECK-LABEL: define{{.*}} void @_ZN5Test11AD2Ev
|
|
// CHECK-NOT: store ptr getelementptr inbounds ({ [3 x ptr] }, ptr @_ZTVN5Test11AE, i64 0, i64 2), ptr
|
|
A::~A()
|
|
{
|
|
}
|
|
|
|
}
|
|
|
|
namespace Test2 {
|
|
|
|
// Check that we do initialize the vtable pointer in A::~A() since the destructor body isn't trivial.
|
|
struct A {
|
|
virtual void f();
|
|
~A();
|
|
};
|
|
|
|
// CHECK-LABEL: define{{.*}} void @_ZN5Test21AD2Ev
|
|
// CHECK: store ptr getelementptr inbounds inrange(-16, 8) ({ [3 x ptr] }, ptr @_ZTVN5Test21AE, i32 0, i32 0, i32 2), ptr
|
|
A::~A() {
|
|
f();
|
|
}
|
|
|
|
}
|
|
|
|
namespace Test3 {
|
|
|
|
// Check that we don't initialize the vtable pointer in A::~A(), since the destructor body is trivial
|
|
// and Field's destructor body is also trivial.
|
|
struct Field {
|
|
~Field() { }
|
|
};
|
|
|
|
struct A {
|
|
virtual void f();
|
|
~A();
|
|
|
|
Field field;
|
|
};
|
|
|
|
// CHECK-LABEL: define{{.*}} void @_ZN5Test31AD2Ev
|
|
// CHECK-NOT: store ptr getelementptr inbounds inrange(-16, 8) ({ [3 x ptr] }, ptr @_ZTVN5Test31AE, i32 0, i32 0, i32 2), ptr
|
|
A::~A() {
|
|
|
|
}
|
|
|
|
}
|
|
|
|
namespace Test4 {
|
|
|
|
// Check that we do initialize the vtable pointer in A::~A(), since Field's destructor body
|
|
// isn't trivial.
|
|
|
|
void f();
|
|
|
|
struct Field {
|
|
~Field() { f(); }
|
|
};
|
|
|
|
struct A {
|
|
virtual void f();
|
|
~A();
|
|
|
|
Field field;
|
|
};
|
|
|
|
// CHECK-LABEL: define{{.*}} void @_ZN5Test41AD2Ev
|
|
// CHECK: store ptr getelementptr inbounds inrange(-16, 8) ({ [3 x ptr] }, ptr @_ZTVN5Test41AE, i32 0, i32 0, i32 2), ptr
|
|
A::~A()
|
|
{
|
|
}
|
|
|
|
}
|
|
|
|
namespace Test5 {
|
|
|
|
// Check that we do initialize the vtable pointer in A::~A(), since Field's destructor isn't
|
|
// available in this translation unit.
|
|
|
|
struct Field {
|
|
~Field();
|
|
};
|
|
|
|
struct A {
|
|
virtual void f();
|
|
~A();
|
|
|
|
Field field;
|
|
};
|
|
|
|
// CHECK-LABEL: define{{.*}} void @_ZN5Test51AD2Ev
|
|
// CHECK: store ptr getelementptr inbounds inrange(-16, 8) ({ [3 x ptr] }, ptr @_ZTVN5Test51AE, i32 0, i32 0, i32 2), ptr
|
|
A::~A()
|
|
{
|
|
}
|
|
|
|
}
|
|
|
|
namespace Test6 {
|
|
|
|
// Check that we do initialize the vtable pointer in A::~A(), since Field has a member
|
|
// variable with a non-trivial destructor body.
|
|
|
|
struct NonTrivialDestructorBody {
|
|
~NonTrivialDestructorBody();
|
|
};
|
|
|
|
struct Field {
|
|
NonTrivialDestructorBody nonTrivialDestructorBody;
|
|
};
|
|
|
|
struct A {
|
|
virtual void f();
|
|
~A();
|
|
|
|
Field field;
|
|
};
|
|
|
|
// CHECK-LABEL: define{{.*}} void @_ZN5Test61AD2Ev
|
|
// CHECK: store ptr getelementptr inbounds inrange(-16, 8) ({ [3 x ptr] }, ptr @_ZTVN5Test61AE, i32 0, i32 0, i32 2), ptr
|
|
A::~A()
|
|
{
|
|
}
|
|
|
|
}
|
|
|
|
namespace Test7 {
|
|
|
|
// Check that we do initialize the vtable pointer in A::~A(), since Field has a base
|
|
// class with a non-trivial destructor body.
|
|
|
|
struct NonTrivialDestructorBody {
|
|
~NonTrivialDestructorBody();
|
|
};
|
|
|
|
struct Field : NonTrivialDestructorBody { };
|
|
|
|
struct A {
|
|
virtual void f();
|
|
~A();
|
|
|
|
Field field;
|
|
};
|
|
|
|
// CHECK-LABEL: define{{.*}} void @_ZN5Test71AD2Ev
|
|
// CHECK: store ptr getelementptr inbounds inrange(-16, 8) ({ [3 x ptr] }, ptr @_ZTVN5Test71AE, i32 0, i32 0, i32 2), ptr
|
|
A::~A()
|
|
{
|
|
}
|
|
|
|
}
|
|
|
|
namespace Test8 {
|
|
|
|
// Check that we do initialize the vtable pointer in A::~A(), since Field has a virtual base
|
|
// class with a non-trivial destructor body.
|
|
|
|
struct NonTrivialDestructorBody {
|
|
~NonTrivialDestructorBody();
|
|
};
|
|
|
|
struct Field : virtual NonTrivialDestructorBody { };
|
|
|
|
struct A {
|
|
virtual void f();
|
|
~A();
|
|
|
|
Field field;
|
|
};
|
|
|
|
// CHECK-LABEL: define{{.*}} void @_ZN5Test81AD2Ev
|
|
// CHECK: store ptr getelementptr inbounds inrange(-16, 8) ({ [3 x ptr] }, ptr @_ZTVN5Test81AE, i32 0, i32 0, i32 2), ptr
|
|
A::~A()
|
|
{
|
|
}
|
|
|
|
}
|
|
|
|
namespace Test9 {
|
|
|
|
// Check that we emit a VTT for B, even though we don't initialize the vtable pointer in the destructor.
|
|
struct A { virtual ~A () { } };
|
|
struct B : virtual A {};
|
|
struct C : virtual B {
|
|
virtual ~C();
|
|
};
|
|
C::~C() {}
|
|
|
|
}
|