
As part of the migration to ptradd (https://discourse.llvm.org/t/rfc-replacing-getelementptr-with-ptradd/68699), we need to change the representation of the `inrange` attribute, which is used for vtable splitting. Currently, inrange is specified as follows: ``` getelementptr inbounds ({ [4 x ptr], [4 x ptr] }, ptr @vt, i64 0, inrange i32 1, i64 2) ``` The `inrange` is placed on a GEP index, and all accesses must be "in range" of that index. The new representation is as follows: ``` getelementptr inbounds inrange(-16, 16) ({ [4 x ptr], [4 x ptr] }, ptr @vt, i64 0, i32 1, i64 2) ``` This specifies which offsets are "in range" of the GEP result. The new representation will continue working when canonicalizing to ptradd representation: ``` getelementptr inbounds inrange(-16, 16) (i8, ptr @vt, i64 48) ``` The inrange offsets are relative to the return value of the GEP. An alternative design could make them relative to the source pointer instead. The result-relative format was chosen on the off-chance that we want to extend support to non-constant GEPs in the future, in which case this variant is more expressive. This implementation "upgrades" the old inrange representation in bitcode by simply dropping it. This is a very niche feature, and I don't think trying to upgrade it is worthwhile. Let me know if you disagree.
61 lines
1.8 KiB
C++
61 lines
1.8 KiB
C++
// RUN: %clang_cc1 %s -triple=amdgcn-amd-amdhsa -std=c++11 -emit-llvm -o - | FileCheck %s
|
|
|
|
struct Field {
|
|
Field();
|
|
~Field();
|
|
};
|
|
|
|
struct Base {
|
|
Base();
|
|
~Base();
|
|
};
|
|
|
|
struct A : Base {
|
|
A();
|
|
~A();
|
|
|
|
virtual void f();
|
|
|
|
Field field;
|
|
};
|
|
|
|
// CHECK-LABEL: define{{.*}} void @_ZN1AC2Ev(ptr {{[^,]*}} %this) unnamed_addr
|
|
// CHECK: call void @_ZN4BaseC2Ev(
|
|
// CHECK: store ptr addrspace(1) getelementptr inbounds inrange(-16, 8) ({ [3 x ptr addrspace(1)] }, ptr addrspace(1) @_ZTV1A, i32 0, i32 0, i32 2)
|
|
// CHECK: call void @_ZN5FieldC1Ev(
|
|
// CHECK: ret void
|
|
A::A() { }
|
|
|
|
// CHECK-LABEL: define{{.*}} void @_ZN1AD2Ev(ptr {{[^,]*}} %this) unnamed_addr
|
|
// CHECK: store ptr addrspace(1) getelementptr inbounds inrange(-16, 8) ({ [3 x ptr addrspace(1)] }, ptr addrspace(1) @_ZTV1A, i32 0, i32 0, i32 2)
|
|
// CHECK: call void @_ZN5FieldD1Ev(
|
|
// CHECK: call void @_ZN4BaseD2Ev(
|
|
// CHECK: ret void
|
|
A::~A() { }
|
|
|
|
struct B : Base {
|
|
virtual void f();
|
|
|
|
Field field;
|
|
};
|
|
|
|
void f() { B b; }
|
|
|
|
// CHECK-LABEL: define linkonce_odr void @_ZN1BC1Ev(ptr {{[^,]*}} %this) unnamed_addr
|
|
// CHECK: call void @_ZN1BC2Ev(
|
|
|
|
// CHECK-LABEL: define linkonce_odr void @_ZN1BD1Ev(ptr {{[^,]*}} %this) unnamed_addr
|
|
// CHECK: call void @_ZN1BD2Ev(
|
|
|
|
// CHECK-LABEL: define linkonce_odr void @_ZN1BC2Ev(ptr {{[^,]*}} %this) unnamed_addr
|
|
// CHECK: call void @_ZN4BaseC2Ev(
|
|
// CHECK: store ptr addrspace(1) getelementptr inbounds inrange(-16, 8) ({ [3 x ptr addrspace(1)] }, ptr addrspace(1) @_ZTV1B, i32 0, i32 0, i32 2)
|
|
// CHECK: call void @_ZN5FieldC1Ev
|
|
// CHECK: ret void
|
|
|
|
// CHECK-LABEL: define linkonce_odr void @_ZN1BD2Ev(ptr {{[^,]*}} %this) unnamed_addr
|
|
// CHECK: store ptr addrspace(1) getelementptr inbounds inrange(-16, 8) ({ [3 x ptr addrspace(1)] }, ptr addrspace(1) @_ZTV1B, i32 0, i32 0, i32 2)
|
|
// CHECK: call void @_ZN5FieldD1Ev(
|
|
// CHECK: call void @_ZN4BaseD2Ev(
|
|
// CHECK: ret void
|