1130e923e2
This patch changes `ScriptedThreadPlan::GetStopDescription` behavior by discarding its return value since it is optional in the first place (the user doesn't need to provide a return value in their implementation). This patch also addresses the test failures in TestStepScripted following 9a9ec22 and re-enables the tests that were XFAIL'd previously. The issue here was that the `Stream*` that's passed to `ThreadPlanPython::GetDescription` wasn't being passed by reference to the python method so it was never updated to reflect how the python method interacted with it. This patch solves this issue by making a temporary `StreamSP` that will be passed to the python method by reference, after what we will copy its content to the caller `Stream` pointer argument. --------- Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
49 lines
1.7 KiB
C++
49 lines
1.7 KiB
C++
//===-- ScriptedThreadPlanPythonInterface.h ---------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLDB_PLUGINS_SCRIPTINTERPRETER_PYTHON_INTERFACES_SCRIPTEDTHREADPLANPYTHONINTERFACE_H
|
|
#define LLDB_PLUGINS_SCRIPTINTERPRETER_PYTHON_INTERFACES_SCRIPTEDTHREADPLANPYTHONINTERFACE_H
|
|
|
|
#include "lldb/Host/Config.h"
|
|
|
|
#if LLDB_ENABLE_PYTHON
|
|
|
|
#include "ScriptedPythonInterface.h"
|
|
#include "lldb/Interpreter/Interfaces/ScriptedThreadPlanInterface.h"
|
|
#include <optional>
|
|
|
|
namespace lldb_private {
|
|
class ScriptedThreadPlanPythonInterface : public ScriptedThreadPlanInterface,
|
|
public ScriptedPythonInterface {
|
|
public:
|
|
ScriptedThreadPlanPythonInterface(ScriptInterpreterPythonImpl &interpreter);
|
|
|
|
llvm::Expected<StructuredData::GenericSP>
|
|
CreatePluginObject(const llvm::StringRef class_name,
|
|
lldb::ThreadPlanSP thread_plan_sp,
|
|
const StructuredDataImpl &args_sp) override;
|
|
|
|
llvm::SmallVector<llvm::StringLiteral> GetAbstractMethods() const override {
|
|
return {};
|
|
}
|
|
|
|
llvm::Expected<bool> ExplainsStop(Event *event) override;
|
|
|
|
llvm::Expected<bool> ShouldStop(Event *event) override;
|
|
|
|
llvm::Expected<bool> IsStale() override;
|
|
|
|
lldb::StateType GetRunState() override;
|
|
|
|
llvm::Error GetStopDescription(lldb::StreamSP &stream) override;
|
|
};
|
|
} // namespace lldb_private
|
|
|
|
#endif // LLDB_ENABLE_PYTHON
|
|
#endif // LLDB_PLUGINS_SCRIPTINTERPRETER_PYTHON_INTERFACES_SCRIPTEDTHREADPLANPYTHONINTERFACE_H
|