In the interest of keeping the ConstString StringPool small, this patch aims to remove the use of ConstString from OptionValueProperties. We can maintain quick lookups by using an llvm::StringMap to find the correct index by name. Differential Revision: https://reviews.llvm.org/D152210