shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity
llvm-project/llvm/utils/TableGen
History
Chandler Carruth 41ed4034dd [x86] Revert the X86FoldTablesEmitter due to more miscompiles. 
In testing, we've found yet another miscompile caused by the new tables.
And this one is even less clear how to fix (we could teach it to fold
a 16-bit load instead of the 32-bit load it wants, or block folding
entirely).

Also, the approach to excluding instructions seems increasingly to not
scale well.

I have left a more detailed analysis on the review log for the original
patch (https://reviews.llvm.org/D32684) along with suggested path
forward. I will land an additional test case that I wrote which covers
the code that was miscompiling (folding into the output of `pextrw`) in
a subsequent commit to keep this a pure revert.

For each commit reverted here, I've restricted the revert to the
non-test code touching the x86 fold table emission until the last commit
where I did revert the test updates. This means the *new* test cases
added for `insertps` and `xchg` remain untouched (and continue to pass).

Reverted commits:
r304540: [X86] Don't fold into memory operands into insertps in the ...
r304347: [TableGen] Adapt more places to getValueAsString now ...
r304163: [X86] Don't fold away the memory operand of an xchg.
r304123: Don't capture a temporary std::string in a StringRef.
r304122: Resubmit "[X86] Adding new LLVM TableGen backend that ..."

Original commit was in r304088, and after a string of fixes was reverted
previously in r304121 to fix build bots, and then re-landed in r304122.

llvm-svn: 304762
2017-06-06 02:15:31 +00:00
..
AsmMatcherEmitter.cpp
[TableGen] Adapt more places to getValueAsString now returning a StringRef instead of a std::string.
2017-05-31 21:12:46 +00:00
AsmWriterEmitter.cpp
[TableGen] Adapt more places to getValueAsString now returning a StringRef instead of a std::string.
2017-05-31 21:12:46 +00:00
AsmWriterInst.cpp
[TableGen] Remove the CGIOpNo from AsmWriterOperand as its not used for anything. NFC
2016-01-22 05:59:37 +00:00
AsmWriterInst.h
[TableGen] Reorder fields in AsmWriterOperand to remove padding and reduce size. NFC
2016-01-22 05:59:40 +00:00
Attributes.cpp
[TableGen] Adapt more places to getValueAsString now returning a StringRef instead of a std::string.
2017-05-31 21:12:46 +00:00
CallingConvEmitter.cpp
Cleanup dump() functions.
2017-01-28 02:02:38 +00:00
CMakeLists.txt
[x86] Revert the X86FoldTablesEmitter due to more miscompiles.
2017-06-06 02:15:31 +00:00
CodeEmitterGen.cpp
[TableGen] Adapt more places to getValueAsString now returning a StringRef instead of a std::string.
2017-05-31 21:12:46 +00:00
CodeGenDAGPatterns.cpp
[TableGen] Adapt more places to getValueAsString now returning a StringRef instead of a std::string.
2017-05-31 21:12:46 +00:00
CodeGenDAGPatterns.h
[TableGen] Adapt more places to getValueAsString now returning a StringRef instead of a std::string.
2017-05-31 21:12:46 +00:00
CodeGenInstruction.cpp
[TableGen] Add EncoderMethod to RegisterOperand
2017-05-15 10:13:07 +00:00
CodeGenInstruction.h
This reapplies r281304. The issue was that I had missed
2016-09-14 08:20:03 +00:00
CodeGenIntrinsics.h
TableGen: Add IntrHasSideEffects property for intrinsics
2017-04-28 21:01:46 +00:00
CodeGenMapTable.cpp
[TableGen] Make CodeGenMapTable understand the namespace field of an instruction
2017-03-27 07:13:44 +00:00
CodeGenRegisters.cpp
[TableGen] Remove code for renaming anonymous register classes as it can never execute.
2017-06-01 06:56:13 +00:00
CodeGenRegisters.h
[TableGen] Use StringRef to capture getValueAsString in a couple more places. NFC
2017-06-01 06:56:11 +00:00
CodeGenSchedule.cpp
[TableGen] Adapt more places to getValueAsString now returning a StringRef instead of a std::string.
2017-05-31 21:12:46 +00:00
CodeGenSchedule.h
Revert "Revert "[misched] Extend scheduler to handle unsupported features""
2016-06-24 08:43:27 +00:00
CodeGenTarget.cpp
[MVT] add v1i1 MVT
2017-05-18 11:29:41 +00:00
CodeGenTarget.h
TableGen: Use StringRef instead of const std::string& in return vals.
2016-12-04 05:48:16 +00:00
CTagsEmitter.cpp
Use StringRef for MemoryBuffer identifier API (NFC)
2016-10-01 16:38:28 +00:00
DAGISelEmitter.cpp
TableGen: Use StringRef instead of const std::string& in return vals.
2016-12-04 05:48:16 +00:00
DAGISelMatcher.cpp
[TableGen] Remove getHash support from DAGISelMatcher. It hasn't been used for some time.
2016-05-06 02:37:59 +00:00
DAGISelMatcher.h
[TableGen] Remove isSafeToReorderWithPatternPredicate from DAGISelMatchers as its not used anymore.
2016-05-06 06:21:27 +00:00
DAGISelMatcherEmitter.cpp
[tablegen] Use categories on options that only matter to one emitter.
2017-03-27 13:15:13 +00:00
DAGISelMatcherGen.cpp
TableGen: Use StringRef instead of const std::string& in return vals.
2016-12-04 05:48:16 +00:00
DAGISelMatcherOpt.cpp
[TableGen] Use less stack in DAGISelMatcherOpt
2017-02-06 19:41:44 +00:00
DFAPacketizerEmitter.cpp
Fix some Clang-tidy and Include What You Use warnings; other minor fixes (NFC).
2016-11-30 17:48:10 +00:00
DisassemblerEmitter.cpp
TableGen: Use StringRef instead of const std::string& in return vals.
2016-12-04 05:48:16 +00:00
FastISelEmitter.cpp
Turn a TableGen FastISelEmitter warning into an error.
2017-01-30 19:03:26 +00:00
FixedLenDecoderEmitter.cpp
[TableGen] Adapt more places to getValueAsString now returning a StringRef instead of a std::string.
2017-05-31 21:12:46 +00:00
GlobalISelEmitter.cpp
[TableGen] Make Record::getValueAsString and getValueAsListOfStrings return StringRefs instead of std::string
2017-05-31 19:01:11 +00:00
InstrInfoEmitter.cpp
[AMDGPU, PowerPC, TableGen] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).
2016-12-12 22:23:53 +00:00
IntrinsicEmitter.cpp
[IR] Abstract away ArgNo+1 attribute indexing as much as possible
2017-05-03 18:17:31 +00:00
LLVMBuild.txt
…
OptParserEmitter.cpp
[TableGen] Make Record::getValueAsString and getValueAsListOfStrings return StringRefs instead of std::string
2017-05-31 19:01:11 +00:00
PseudoLoweringEmitter.cpp
TableGen: Use StringInit instead of std::string for DagInit arg names
2016-12-05 06:00:46 +00:00
RegisterBankEmitter.cpp
[TableGen] Adapt more places to getValueAsString now returning a StringRef instead of a std::string.
2017-05-31 21:12:46 +00:00
RegisterInfoEmitter.cpp
[TableGen] Adapt more places to getValueAsString now returning a StringRef instead of a std::string.
2017-05-31 21:12:46 +00:00
SearchableTableEmitter.cpp
[TableGen] Adapt more places to getValueAsString now returning a StringRef instead of a std::string.
2017-05-31 21:12:46 +00:00
SequenceToOffsetTable.h
[NFC] Header cleanup
2016-04-18 09:17:29 +00:00
SubtargetEmitter.cpp
[TableGen] Adapt more places to getValueAsString now returning a StringRef instead of a std::string.
2017-05-31 21:12:46 +00:00
SubtargetFeatureInfo.cpp
[globalisel][tablegen] Compute available feature bits correctly.
2017-04-29 17:30:09 +00:00
SubtargetFeatureInfo.h
[globalisel][tablegen] Compute available feature bits correctly.
2017-04-29 17:30:09 +00:00
TableGen.cpp
[x86] Revert the X86FoldTablesEmitter due to more miscompiles.
2017-06-06 02:15:31 +00:00
TableGenBackends.h
[x86] Revert the X86FoldTablesEmitter due to more miscompiles.
2017-06-06 02:15:31 +00:00
tdtags
…
Types.cpp
[globalisel][tablegen] Import SelectionDAG's rule predicates and support the equivalent in GIRule.
2017-04-21 15:59:56 +00:00
Types.h
Check that emitted instructions meet their predicates on all targets except ARM, Mips, and X86.
2016-11-19 13:05:44 +00:00
X86DisassemblerShared.h
…
X86DisassemblerTables.cpp
[X86] Fix for bugzilla 31576 - add support for "data32" instruction prefix
2017-01-18 08:07:51 +00:00
X86DisassemblerTables.h
…
X86EVEX2VEXTablesEmitter.cpp
Another instance where GCC doesn't understand implicit construction of StringLiteral.
2017-03-24 14:17:56 +00:00
X86ModRMFilters.cpp
…
X86ModRMFilters.h
…
X86RecognizableInstr.cpp
[X86] Moving X86Local namespace from .cpp to .h file to use it in memory folding TableGen backend.
2017-05-11 11:51:12 +00:00
X86RecognizableInstr.h
[X86] Moving X86Local namespace from .cpp to .h file to use it in memory folding TableGen backend.
2017-05-11 11:51:12 +00:00