165545c7a4
Although I cannot find any mention of this in the specification, both gdb and lldb agree on sending an initial + packet after establishing the connection. OTOH, gdbserver and lldb-server behavior is subtly different. While lldb-server *expects* the initial ack, and drops the connection if it is not received, gdbserver will just ignore a spurious ack at _any_ point in the connection. This patch changes lldb's behavior to match that of gdb. An ACK packet is ignored at any point in the connection (except when expecting an ACK packet, of course). This is inline with the "be strict in what you generate, and lenient in what you accept" philosophy, and also enables us to remove some special cases from the server code. I've extended the same handling to NAK (-) packets, mainly because I don't see a reason to treat them differently here. (The background here is that we had a stub which was sending spurious + packets. This bug has since been fixed, but I think this change makes sense nonetheless.) Differential Revision: https://reviews.llvm.org/D114520
72 lines
2.3 KiB
C++
72 lines
2.3 KiB
C++
//===-- GDBRemoteCommunicationTest.cpp ------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
#include "GDBRemoteTestUtils.h"
|
|
#include "llvm/Testing/Support/Error.h"
|
|
|
|
using namespace lldb_private::process_gdb_remote;
|
|
using namespace lldb_private;
|
|
using namespace lldb;
|
|
typedef GDBRemoteCommunication::PacketResult PacketResult;
|
|
|
|
namespace {
|
|
|
|
class TestClient : public GDBRemoteCommunication {
|
|
public:
|
|
TestClient()
|
|
: GDBRemoteCommunication("test.client", "test.client.listener") {}
|
|
|
|
PacketResult ReadPacket(StringExtractorGDBRemote &response) {
|
|
return GDBRemoteCommunication::ReadPacket(response, std::chrono::seconds(1),
|
|
/*sync_on_timeout*/ false);
|
|
}
|
|
};
|
|
|
|
class GDBRemoteCommunicationTest : public GDBRemoteTest {
|
|
public:
|
|
void SetUp() override {
|
|
ASSERT_THAT_ERROR(GDBRemoteCommunication::ConnectLocally(client, server),
|
|
llvm::Succeeded());
|
|
}
|
|
|
|
protected:
|
|
TestClient client;
|
|
MockServer server;
|
|
|
|
bool Write(llvm::StringRef packet) {
|
|
ConnectionStatus status;
|
|
return server.Write(packet.data(), packet.size(), status, nullptr) ==
|
|
packet.size();
|
|
}
|
|
};
|
|
} // end anonymous namespace
|
|
|
|
// Test that we can decode packets correctly. In particular, verify that
|
|
// checksum calculation works.
|
|
TEST_F(GDBRemoteCommunicationTest, ReadPacket) {
|
|
struct TestCase {
|
|
llvm::StringLiteral Packet;
|
|
llvm::StringLiteral Payload;
|
|
};
|
|
static constexpr TestCase Tests[] = {
|
|
{{"$#00"}, {""}},
|
|
{{"$foobar#79"}, {"foobar"}},
|
|
{{"$}]#da"}, {"}"}}, // Escaped }
|
|
{{"$x*%#c7"}, {"xxxxxxxxx"}}, // RLE
|
|
{{"+$#00"}, {""}}, // Spurious ACK
|
|
{{"-$#00"}, {""}}, // Spurious NAK
|
|
};
|
|
for (const auto &Test : Tests) {
|
|
SCOPED_TRACE(Test.Packet + " -> " + Test.Payload);
|
|
StringExtractorGDBRemote response;
|
|
ASSERT_TRUE(Write(Test.Packet));
|
|
ASSERT_EQ(PacketResult::Success, client.ReadPacket(response));
|
|
ASSERT_EQ(Test.Payload, response.GetStringRef());
|
|
ASSERT_EQ(PacketResult::Success, server.GetAck());
|
|
}
|
|
}
|