1b4f161978
Testing `openmp` on Solaris/amd64 shows a large number of failures, all
due to the same issue:
```
# .---command stderr------------
# | openmp/runtime/test/ompt/misc/interoperability.cpp:67:16: error: CHECK-SAME: expected string not found in input
# | // CHECK-SAME: parent_task_frame.reenter={{0x[0-f]+}}
# | ^
# | <stdin>:5:101: note: scanning from here
# | 281474976710658: ompt_event_parallel_begin: parent_task_id=281474976710659, parent_task_frame.exit=0, parent_task_frame.reenter=7fffbedffe90, parallel_id=281474976710661, requested_team_size=2, codeptr_ra=408b8e, invoker=2
```
The testsuite expects pointers to be printed with a `0x` prefix when
using the `%p` format, while Solaris `libc` just prints them in hex
without a prefix.
However, this difference is completely benign. ISO C (up to C23,
7.23.6.1) states
```
p The argument shall be a pointer to void or a pointer to a character
type. The value of the pointer is converted to a sequence of printing
characters, in an implementation-defined manner.
```
I saw two ways around this:
- replace every instance of `%p` with a macro (`KMP_PTR_FMT`, defined as
`"%p"` or `"0x%p" as appropriate), or
- adjust the testsuite to make the `0x` prefix optional
The second route seemed less intrusive and more readable, so that's what
this patch does. While large, it's also completely mechanical.
Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.
84 lines
3.0 KiB
C
84 lines
3.0 KiB
C
// RUN: %libomp-compile-and-run | %sort-threads | FileCheck %s
|
|
// REQUIRES: ompt
|
|
|
|
// taskwait with depend clause was introduced with gcc-9
|
|
// UNSUPPORTED: gcc-4, gcc-5, gcc-6, gcc-7, gcc-8
|
|
|
|
// icc does not yet support taskwait with depend clause
|
|
// XFAIL: icc
|
|
|
|
// support for taskwait with depend clause introduced in clang-14
|
|
// UNSUPPORTED: clang-5, clang-6, clang-6, clang-8, clang-9, clang-10, clang-11, clang-12, clang-13
|
|
|
|
#include "callback.h"
|
|
#include <omp.h>
|
|
|
|
int main() {
|
|
int x = 0;
|
|
#pragma omp parallel num_threads(2)
|
|
{
|
|
#pragma omp master
|
|
{
|
|
print_ids(0);
|
|
printf("%" PRIu64 ": address of x: %p\n", ompt_get_thread_data()->value,
|
|
&x);
|
|
#pragma omp task depend(out : x)
|
|
{ x++; }
|
|
print_fuzzy_address(1);
|
|
#pragma omp taskwait depend(in: x)
|
|
print_fuzzy_address(2);
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
// Check if libomp supports the callbacks for this test.
|
|
// CHECK-NOT: {{^}}0: Could not register callback 'ompt_callback_task_create'
|
|
// CHECK-NOT: {{^}}0: Could not register callback 'ompt_callback_dependences'
|
|
// CHECK-NOT: {{^}}0: Could not register callback 'ompt_callback_task_depende
|
|
|
|
// CHECK: {{^}}0: NULL_POINTER=[[NULL:.*$]]
|
|
|
|
// make sure initial data pointers are null
|
|
// CHECK-NOT: 0: new_task_data initially not null
|
|
|
|
// CHECK: {{^}}[[MASTER_ID:[0-9]+]]: ompt_event_implicit_task_begin:
|
|
// CHECK-SAME: parallel_id=[[PARALLEL_ID:[0-9]+]],
|
|
// CHECK-SAME: task_id=[[IMPLICIT_TASK_ID:[0-9]+]]
|
|
|
|
// CHECK: {{^}}[[MASTER_ID]]: task level 0: parallel_id=[[PARALLEL_ID]],
|
|
// CHECK-SAME: task_id=[[IMPLICIT_TASK_ID]], exit_frame=[[EXIT:(0x)?[0-f]+]],
|
|
// CHECK-SAME: reenter_frame=[[NULL]]
|
|
|
|
// CHECK: {{^}}[[MASTER_ID]]: address of x: [[ADDRX:(0x)?[0-f]+]]
|
|
|
|
// CHECK: {{^}}[[MASTER_ID]]: ompt_event_task_create:
|
|
// CHECK-SAME: parent_task_id={{[0-9]+}}, parent_task_frame.exit=[[EXIT]],
|
|
// CHECK-SAME: parent_task_frame.reenter={{(0x)?[0-f]+}},
|
|
// CHECK-SAME: new_task_id=[[FIRST_TASK:[0-f]+]],
|
|
// CHECK-SAME: codeptr_ra=[[RETURN_ADDRESS:(0x)?[0-f]+]]{{[0-f][0-f]}},
|
|
// CHECK-SAME: task_type=ompt_task_explicit=4, has_dependences=yes
|
|
|
|
// CHECK: {{^}}[[MASTER_ID]]: ompt_event_dependences:
|
|
// CHECK-SAME: task_id=[[FIRST_TASK]], deps=[([[ADDRX]],
|
|
// CHECK-SAME: ompt_dependence_type_inout)], ndeps=1
|
|
|
|
// CHECK: {{^}}[[MASTER_ID]]: fuzzy_address={{.*}}[[RETURN_ADDRESS]]
|
|
|
|
// CHECK: {{^}}[[MASTER_ID]]: ompt_event_task_create:
|
|
// CHECK-SAME: parent_task_id={{[0-9]+}}, parent_task_frame.exit=[[EXIT]],
|
|
// CHECK-SAME: parent_task_frame.reenter={{(0x)?[0-f]+}},
|
|
// CHECK-SAME: new_task_id=[[SECOND_TASK:[0-f]+]],
|
|
// CHECK-SAME: codeptr_ra=[[RETURN_ADDRESS:(0x)?[0-f]+]]{{[0-f][0-f]}},
|
|
// CHECK-SAME: task_type=ompt_task_taskwait|ompt_task_undeferred|
|
|
// CHECK-SAME: ompt_task_mergeable=1207959568, has_dependences=yes
|
|
|
|
// CHECK: {{^}}[[MASTER_ID]]: ompt_event_dependences:
|
|
// CHECK-SAME: task_id=[[SECOND_TASK]], deps=[([[ADDRX]],
|
|
// CHECK-SAME: ompt_dependence_type_in)], ndeps=1
|
|
|
|
// CHECK: {{^}}[[MASTER_ID]]: ompt_event_task_end: task_id=[[SECOND_TASK]]
|
|
|
|
// CHECK: {{^}}[[MASTER_ID]]: fuzzy_address={{.*}}[[RETURN_ADDRESS]]
|